From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87495168 for ; Thu, 24 Jun 2021 11:50:35 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id x22so2809849pll.11 for ; Thu, 24 Jun 2021 04:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1NBhOpdFrFXN612ppL4gJ9nkWeOTOGB0kA5VL7u3oI0=; b=poPjKalCBQbjajhtmSRxl4/nxS8RFLQFavYUQuNpzfQby3SCFgcBVtspZVCRxUFRWm EW7x/UsNudzFXvhAFMXzdVhfCDKO7GvKHLjD9r4Wh4T4Ro0+/c8ngHl0uzKqybfLdgXW GJroG6k4oPOaClgQP+K6zo/FN0X32tv8IxqZuW1FCAWrCTEztTfRkUNZdF2nWlx4OeiR o7twtfpKzgqS3itVETbnV8BpuO5S9ZKyMyd2qgJiV4n7eBPWJOp7O+s14EC0auBnWF5k A4qtW4UefVkXq/cLv295UDphoDtgZL612pxhuJsYEWaryHJdu6x1cyb16kEoRU7eh9Xx Y94g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1NBhOpdFrFXN612ppL4gJ9nkWeOTOGB0kA5VL7u3oI0=; b=b66DFcxgUP0u31wonLV3c9eSkddnTSrhH0PMX0pFEgISsbRReqjiHepSrjN69WswwM LGpCs2lJV8xsHTIyUpP+BmbCAdb44wamB1H1g/+6XlMeG3JavpVZDVYrSaF1K1+PG6Mm uiLiyn+O68OSTE+0jDl8a4msCoEIFtJsjcqQzNcJJ4V8GQlaLAdCXrEY5mWGRA2UUBeW kOKCwW+cRrPnMFYcb2Jl0we+ALlrZXZC+iJLjdsUkAJIkgCFoD8IMvd30HwBNc5yTbHx +1K3uw7f1pgu2a+ibn29uqU+OW94F4b7ogHTGq5xgqROKhhE3rVTAKGgEUe+YnkFL+Ny 3pYQ== X-Gm-Message-State: AOAM533Qp/OE1UhpVdrxOiZScbMbWffXa/7sZfMGKkgBQkXF5jFjfdCR YbItFhBdPj1rIwdWypJpGukV1442o8PRcnPw X-Google-Smtp-Source: ABdhPJwPgS8I8F1fTQGFGwHpoDuOE97EeXTfhOLfTiMi1HfyWVc/nTAfT2T7hVJ2hTriMsxou8L4PQ== X-Received: by 2002:a17:90b:148f:: with SMTP id js15mr4960088pjb.182.1624535435076; Thu, 24 Jun 2021 04:50:35 -0700 (PDT) Received: from localhost ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id b6sm2278206pgw.67.2021.06.24.04.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 04:50:34 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Thu, 24 Jun 2021 19:47:05 +0800 To: Benjamin Poirier Cc: Dan Carpenter , linux-staging@lists.linux.dev, netdev@vger.kernel.org, Shung-Hsi Yu , Manish Chopra , "supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER" , Greg Kroah-Hartman , open list Subject: Re: [RFC 01/19] staging: qlge: fix incorrect truesize accounting Message-ID: <20210624114705.ehmzmysl3vdylg3x@Rk> References: <20210621134902.83587-1-coiby.xu@gmail.com> <20210621134902.83587-2-coiby.xu@gmail.com> <20210621141027.GJ1861@kadam> <20210622113649.vm2hfh2veqr4dq6y@Rk> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Wed, Jun 23, 2021 at 01:55:15PM +0900, Benjamin Poirier wrote: >On 2021-06-22 19:36 +0800, Coiby Xu wrote: >> On Mon, Jun 21, 2021 at 05:10:27PM +0300, Dan Carpenter wrote: >> > On Mon, Jun 21, 2021 at 09:48:44PM +0800, Coiby Xu wrote: >> > > Commit 7c734359d3504c869132166d159c7f0649f0ab34 ("qlge: Size RX buffers >> > > based on MTU") introduced page_chunk structure. We should add >> > > qdev->lbq_buf_size to skb->truesize after __skb_fill_page_desc. >> > > >> > >> > Add a Fixes tag. >> >> I will fix it in next version, thanks! >> >> > >> > The runtime impact of this is just that ethtool will report things >> > incorrectly, right? It's not 100% from the commit message. Could you >> > please edit the commit message so that an ignoramous like myself can >> > understand it? > >truesize is used in socket memory accounting, the stuff behind sysctl >net.core.rmem_max, SO_RCVBUF, ss -m, ... > >Some helpful chap wrote a page about it a while ago: >http://vger.kernel.org/~davem/skb_sk.html Thanks for the explanation and the reference! > >> >> I'm not sure how it would affect ethtool. But according to "git log >> --grep=truesize", it affects coalescing SKBs. Btw, I fixed the issue >> according to the definition of truesize which according to Linux Kernel >> Network by Rami Rosen, it's defined as follows, >> > The total memory allocated for the SKB (including the SKB structure >> > itself and the size of the allocated data block). >> >> I'll edit the commit message to include it, thanks! >> >> > >> > Why is this an RFC instead of just a normal patch which we can apply? >> >> After doing the tests mentioned in the cover letter, I found Red Hat's >> network QE team has quite a rigorous test suite. But I needed to return the >> machine before having the time to learn about the test suite and run it by >> myself. So I mark it as an RFC before I borrow the machine again to run the >> test suite. > >Interesting. Is this test suite based on a public project? The test suite is written for Beaker [1] but it seems it's not public. [1] https://fedoraproject.org/wiki/QA/Beaker -- Best regards, Coiby