linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Phillip Potter <phil@philpotter.co.uk>, gregkh@linuxfoundation.org
Cc: kbuild-all@lists.01.org, Larry.Finger@lwfinger.net,
	dan.carpenter@oracle.com, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH 01/23] staging: rtl8188eu: remove all RT_TRACE calls from os_dep/ioctl_linux.c
Date: Fri, 25 Jun 2021 11:20:12 +0800	[thread overview]
Message-ID: <202106251142.ofJM1wly-lkp@intel.com> (raw)
In-Reply-To: <20210625000756.6313-2-phil@philpotter.co.uk>

[-- Attachment #1: Type: text/plain, Size: 7142 bytes --]

Hi Phillip,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Phillip-Potter/staging-rtl8188eu-remove-include-rtw_debug-h/20210625-081023
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git fcc84fe12fd8271ea0d94cbac4ae02f9162f56fd
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8e9ae03b206ecabeadc3fa9ca135a7f2d354c596
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Phillip-Potter/staging-rtl8188eu-remove-include-rtw_debug-h/20210625-081023
        git checkout 8e9ae03b206ecabeadc3fa9ca135a7f2d354c596
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/staging/rtl8188eu/os_dep/ioctl_linux.c: In function 'rtw_wx_set_rate':
>> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:1271:5: warning: variable 'datarates' set but not used [-Wunused-but-set-variable]
    1271 |  u8 datarates[NumRates];
         |     ^~~~~~~~~
   At top level:
   drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:50:27: warning: 'iw_operation_mode' defined but not used [-Wunused-const-variable=]
      50 | static const char * const iw_operation_mode[] = {
         |                           ^~~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
   Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
   Selected by
   - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
   - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC


vim +/datarates +1271 drivers/staging/rtl8188eu/os_dep/ioctl_linux.c

a2c60d42d97cdb Larry Finger    2013-08-21  1265  
a2c60d42d97cdb Larry Finger    2013-08-21  1266  static int rtw_wx_set_rate(struct net_device *dev,
a2c60d42d97cdb Larry Finger    2013-08-21  1267  			   struct iw_request_info *a,
a2c60d42d97cdb Larry Finger    2013-08-21  1268  			   union iwreq_data *wrqu, char *extra)
a2c60d42d97cdb Larry Finger    2013-08-21  1269  {
c78a964c251bb8 Sudip Mukherjee 2014-11-07  1270  	int i;
a2c60d42d97cdb Larry Finger    2013-08-21 @1271  	u8 datarates[NumRates];
a2c60d42d97cdb Larry Finger    2013-08-21  1272  	u32	target_rate = wrqu->bitrate.value;
a2c60d42d97cdb Larry Finger    2013-08-21  1273  	u32	fixed = wrqu->bitrate.fixed;
a2c60d42d97cdb Larry Finger    2013-08-21  1274  	u32	ratevalue = 0;
a2c60d42d97cdb Larry Finger    2013-08-21  1275  	u8 mpdatarate[NumRates] = {11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0, 0xff};
a2c60d42d97cdb Larry Finger    2013-08-21  1276  
a2c60d42d97cdb Larry Finger    2013-08-21  1277  	if (target_rate == -1) {
a2c60d42d97cdb Larry Finger    2013-08-21  1278  		ratevalue = 11;
a2c60d42d97cdb Larry Finger    2013-08-21  1279  		goto set_rate;
a2c60d42d97cdb Larry Finger    2013-08-21  1280  	}
3a90d8186659b1 Michael Straube 2020-06-29  1281  	target_rate /= 100000;
a2c60d42d97cdb Larry Finger    2013-08-21  1282  
a2c60d42d97cdb Larry Finger    2013-08-21  1283  	switch (target_rate) {
a2c60d42d97cdb Larry Finger    2013-08-21  1284  	case 10:
a2c60d42d97cdb Larry Finger    2013-08-21  1285  		ratevalue = 0;
a2c60d42d97cdb Larry Finger    2013-08-21  1286  		break;
a2c60d42d97cdb Larry Finger    2013-08-21  1287  	case 20:
a2c60d42d97cdb Larry Finger    2013-08-21  1288  		ratevalue = 1;
a2c60d42d97cdb Larry Finger    2013-08-21  1289  		break;
a2c60d42d97cdb Larry Finger    2013-08-21  1290  	case 55:
a2c60d42d97cdb Larry Finger    2013-08-21  1291  		ratevalue = 2;
a2c60d42d97cdb Larry Finger    2013-08-21  1292  		break;
a2c60d42d97cdb Larry Finger    2013-08-21  1293  	case 60:
a2c60d42d97cdb Larry Finger    2013-08-21  1294  		ratevalue = 3;
a2c60d42d97cdb Larry Finger    2013-08-21  1295  		break;
a2c60d42d97cdb Larry Finger    2013-08-21  1296  	case 90:
a2c60d42d97cdb Larry Finger    2013-08-21  1297  		ratevalue = 4;
a2c60d42d97cdb Larry Finger    2013-08-21  1298  		break;
a2c60d42d97cdb Larry Finger    2013-08-21  1299  	case 110:
a2c60d42d97cdb Larry Finger    2013-08-21  1300  		ratevalue = 5;
a2c60d42d97cdb Larry Finger    2013-08-21  1301  		break;
a2c60d42d97cdb Larry Finger    2013-08-21  1302  	case 120:
a2c60d42d97cdb Larry Finger    2013-08-21  1303  		ratevalue = 6;
a2c60d42d97cdb Larry Finger    2013-08-21  1304  		break;
a2c60d42d97cdb Larry Finger    2013-08-21  1305  	case 180:
a2c60d42d97cdb Larry Finger    2013-08-21  1306  		ratevalue = 7;
a2c60d42d97cdb Larry Finger    2013-08-21  1307  		break;
a2c60d42d97cdb Larry Finger    2013-08-21  1308  	case 240:
a2c60d42d97cdb Larry Finger    2013-08-21  1309  		ratevalue = 8;
a2c60d42d97cdb Larry Finger    2013-08-21  1310  		break;
a2c60d42d97cdb Larry Finger    2013-08-21  1311  	case 360:
a2c60d42d97cdb Larry Finger    2013-08-21  1312  		ratevalue = 9;
a2c60d42d97cdb Larry Finger    2013-08-21  1313  		break;
a2c60d42d97cdb Larry Finger    2013-08-21  1314  	case 480:
a2c60d42d97cdb Larry Finger    2013-08-21  1315  		ratevalue = 10;
a2c60d42d97cdb Larry Finger    2013-08-21  1316  		break;
a2c60d42d97cdb Larry Finger    2013-08-21  1317  	case 540:
a2c60d42d97cdb Larry Finger    2013-08-21  1318  		ratevalue = 11;
a2c60d42d97cdb Larry Finger    2013-08-21  1319  		break;
a2c60d42d97cdb Larry Finger    2013-08-21  1320  	default:
a2c60d42d97cdb Larry Finger    2013-08-21  1321  		ratevalue = 11;
a2c60d42d97cdb Larry Finger    2013-08-21  1322  		break;
a2c60d42d97cdb Larry Finger    2013-08-21  1323  	}
a2c60d42d97cdb Larry Finger    2013-08-21  1324  
a2c60d42d97cdb Larry Finger    2013-08-21  1325  set_rate:
a2c60d42d97cdb Larry Finger    2013-08-21  1326  
a2c60d42d97cdb Larry Finger    2013-08-21  1327  	for (i = 0; i < NumRates; i++) {
a2c60d42d97cdb Larry Finger    2013-08-21  1328  		if (ratevalue == mpdatarate[i]) {
a2c60d42d97cdb Larry Finger    2013-08-21  1329  			datarates[i] = mpdatarate[i];
a2c60d42d97cdb Larry Finger    2013-08-21  1330  			if (fixed == 0)
a2c60d42d97cdb Larry Finger    2013-08-21  1331  				break;
a2c60d42d97cdb Larry Finger    2013-08-21  1332  		} else {
a2c60d42d97cdb Larry Finger    2013-08-21  1333  			datarates[i] = 0xff;
a2c60d42d97cdb Larry Finger    2013-08-21  1334  		}
a2c60d42d97cdb Larry Finger    2013-08-21  1335  	}
a2c60d42d97cdb Larry Finger    2013-08-21  1336  
c78a964c251bb8 Sudip Mukherjee 2014-11-07  1337  	return 0;
a2c60d42d97cdb Larry Finger    2013-08-21  1338  }
a2c60d42d97cdb Larry Finger    2013-08-21  1339  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54837 bytes --]

  reply	other threads:[~2021-06-25  3:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25  0:07 [PATCH 00/23] staging: rtl8188eu: remove include/rtw_debug.h Phillip Potter
2021-06-25  0:07 ` [PATCH 01/23] staging: rtl8188eu: remove all RT_TRACE calls from os_dep/ioctl_linux.c Phillip Potter
2021-06-25  3:20   ` kernel test robot [this message]
2021-06-25  0:07 ` [PATCH 02/23] staging: rtl8188eu: remove all RT_TRACE calls from os_dep/xmit_linux.c Phillip Potter
2021-06-25  0:07 ` [PATCH 03/23] staging: rtl8188eu: remove all RT_TRACE calls from os_dep/os_intfs.c Phillip Potter
2021-06-25  0:07 ` [PATCH 04/23] staging: rtl8188eu: remove all RT_TRACE calls from os_dep/mlme_linux.c Phillip Potter
2021-06-25  0:07 ` [PATCH 05/23] staging: rtl8188eu: remove all RT_TRACE calls from os_dep/recv_linux.c Phillip Potter
2021-06-25  0:07 ` [PATCH 06/23] staging: rtl8188eu: remove all RT_TRACE calls from core/rtw_security.c Phillip Potter
2021-06-25  0:07 ` [PATCH 07/23] staging: rtl8188eu: remove all RT_TRACE calls from core/rtw_sta_mgt.c Phillip Potter
2021-06-25  0:07 ` [PATCH 08/23] staging: rtl8188eu: remove all RT_TRACE calls from core/rtw_mlme_ext.c Phillip Potter
2021-06-25  0:07 ` [PATCH 09/23] staging: rtl8188eu: remove all RT_TRACE calls from core/rtw_mlme.c Phillip Potter
2021-06-25  0:07 ` [PATCH 10/23] staging: rtl8188eu: remove all RT_TRACE calls from core/rtw_led.c Phillip Potter
2021-06-25  0:07 ` [PATCH 11/23] staging: rtl8188eu: remove all RT_TRACE calls from core/rtw_wlan_util.c Phillip Potter
2021-06-25  0:07 ` [PATCH 12/23] staging: rtl8188eu: remove all RT_TRACE calls from core/rtw_ieee80211.c Phillip Potter
2021-06-25  5:18   ` kernel test robot
2021-06-25  0:07 ` [PATCH 13/23] staging: rtl8188eu: remove all RT_TRACE calls from core/rtw_ioctl_set.c Phillip Potter
2021-06-25  0:07 ` [PATCH 14/23] staging: rtl8188eu: remove all RT_TRACE calls from core/rtw_recv.c Phillip Potter
2021-06-25  0:07 ` [PATCH 15/23] staging: rtl8188eu: remove all RT_TRACE calls from core/rtw_pwrctrl.c Phillip Potter
2021-06-25  0:07 ` [PATCH 16/23] staging: rtl8188eu: remove all RT_TRACE calls from core/rtw_xmit.c Phillip Potter
2021-06-25  0:07 ` [PATCH 17/23] staging: rtl8188eu: remove all RT_TRACE calls from hal/rtl8188eu_xmit.c Phillip Potter
2021-06-25  0:07 ` [PATCH 18/23] staging: rtl8188eu: remove all RT_TRACE calls from hal/hal_intf.c Phillip Potter
2021-06-25  0:07 ` [PATCH 19/23] staging: rtl8188eu: remove all RT_TRACE calls from hal/rtl8188eu_recv.c Phillip Potter
2021-06-25  0:07 ` [PATCH 20/23] staging: rtl8188eu: remove RT_TRACE macro Phillip Potter
2021-06-25  0:07 ` [PATCH 21/23] staging: rtl8188eu: remove DRIVER_PREFIX preprocessor definition Phillip Potter
2021-06-25  0:07 ` [PATCH 22/23] staging: rtl8188eu: remove GlobalDebugLevel variable Phillip Potter
2021-06-25  0:07 ` [PATCH 23/23] staging: rtl8188eu: remove include/rtw_debug.h header Phillip Potter
2021-06-25 12:43 ` [PATCH 00/23] staging: rtl8188eu: remove include/rtw_debug.h Dan Carpenter
2021-06-25 17:42   ` Phillip Potter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202106251142.ofJM1wly-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    --subject='Re: [PATCH 01/23] staging: rtl8188eu: remove all RT_TRACE calls from os_dep/ioctl_linux.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).