From: Dan Carpenter <dan.carpenter@oracle.com> To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linuxarm@huawei.com, mauro.chehab@huawei.com, Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v9 3/5] mfd: hi6421-spmi-pmic: move driver from staging Date: Mon, 28 Jun 2021 11:13:18 +0300 [thread overview] Message-ID: <20210628081318.GL2040@kadam> (raw) In-Reply-To: <6cdd91b60115dae8a62bea01ca7548c0a6642448.1624640087.git.mchehab+huawei@kernel.org> On Fri, Jun 25, 2021 at 07:06:12PM +0200, Mauro Carvalho Chehab wrote: > +static int hi6421_spmi_pmic_probe(struct spmi_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + int ret; > + struct hi6421_spmi_pmic *ddata; > + ddata = devm_kzalloc(dev, sizeof(*ddata), GFP_KERNEL); No blank line. Checkpatch. > + if (!ddata) > + return -ENOMEM; > + > + ddata->regmap = devm_regmap_init_spmi_ext(pdev, ®map_config); > + if (IS_ERR(ddata->regmap)) > + return PTR_ERR(ddata->regmap); > + > + mutex_init(&ddata->enable_mutex); > + > + dev_set_drvdata(&pdev->dev, ddata); > + > + ret = devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, > + hi6421v600_devs, ARRAY_SIZE(hi6421v600_devs), > + NULL, 0, NULL); > + if (ret < 0) > + dev_err(dev, "Failed to add child devices: %d\n", ret); > + > + return ret; > +} regards, dan carpenter
prev parent reply other threads:[~2021-06-28 8:13 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-25 17:06 [PATCH v9 0/5] Move Hisilicon 6421v600 SPMI and USB drivers out of staging Mauro Carvalho Chehab 2021-06-25 17:06 ` [PATCH v9 1/5] staging: hikey9xx: split hi6421v600 irq into a separate driver Mauro Carvalho Chehab 2021-06-25 17:06 ` [PATCH v9 2/5] regulator: hi6421v600-regulator: fix platform drvdata Mauro Carvalho Chehab 2021-06-26 3:41 ` Axel Lin 2021-06-29 10:23 ` Mauro Carvalho Chehab 2021-06-25 17:06 ` [PATCH v9 3/5] mfd: hi6421-spmi-pmic: move driver from staging Mauro Carvalho Chehab 2021-06-28 8:13 ` Dan Carpenter [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210628081318.GL2040@kadam \ --to=dan.carpenter@oracle.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-staging@lists.linux.dev \ --cc=linuxarm@huawei.com \ --cc=mauro.chehab@huawei.com \ --cc=mchehab+huawei@kernel.org \ --cc=robh+dt@kernel.org \ --subject='Re: [PATCH v9 3/5] mfd: hi6421-spmi-pmic: move driver from staging' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).