From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: Remove an unused variable and some lines of code
Date: Fri, 2 Jul 2021 11:35:21 +0300 [thread overview]
Message-ID: <20210702083521.GV2040@kadam> (raw)
In-Reply-To: <20210702074840.GT2040@kadam>
On Fri, Jul 02, 2021 at 10:48:40AM +0300, Dan Carpenter wrote:
> On Thu, Jul 01, 2021 at 04:47:07PM +0200, Fabio M. De Francesco wrote:
> > Remove set but unused iw_operation_mode[]. Remove all the lines of
> > code from the function rtw_wx_set_rate, except the "return 0;" line
> > to not break userland code that somewhat uses this IOCTL.
> >
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> > .../staging/rtl8188eu/os_dep/ioctl_linux.c | 72 -------------------
> > 1 file changed, 72 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> > index b958a8d882b0..a66d8838c034 100644
> > --- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> > +++ b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> > @@ -46,11 +46,6 @@ static u32 rtw_rates[] = {1000000, 2000000, 5500000, 11000000,
> > 6000000, 9000000, 12000000, 18000000, 24000000, 36000000,
> > 48000000, 54000000};
> >
> > -static const char * const iw_operation_mode[] = {
> > - "Auto", "Ad-Hoc", "Managed", "Master", "Repeater",
> > - "Secondary", "Monitor"
> > -};
> > -
> > void indicate_wx_scan_complete_event(struct adapter *padapter)
> > {
> > union iwreq_data wrqu;
> > @@ -1266,73 +1261,6 @@ static int rtw_wx_set_rate(struct net_device *dev,
> > struct iw_request_info *a,
> > union iwreq_data *wrqu, char *extra)
> > {
>
> Just delete this whole file. It doesn't do anything now.
Sorry, I meant function, not file. *chortle*. :P
regards,
dan carpenter
next prev parent reply other threads:[~2021-07-02 8:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 14:47 [PATCH] staging: rtl8188eu: Remove an unused variable and some lines of code Fabio M. De Francesco
2021-07-02 7:48 ` Dan Carpenter
2021-07-02 8:35 ` Dan Carpenter [this message]
2021-07-02 12:14 ` Fabio M. De Francesco
2021-07-02 12:42 ` Dan Carpenter
2021-07-02 12:46 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210702083521.GV2040@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).