archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <>
To: Kees Cook <>
Cc: Mauro Carvalho Chehab <>,
	Mauro Carvalho Chehab <>,
	Hans Verkuil <>,
	Greg Kroah-Hartman <>,
	Martiros Shakhzadyan <>,,,,
Subject: Re: [PATCH] media: atomisp: Perform a single memset() for union
Date: Sun, 11 Jul 2021 18:16:49 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sun, Jul 11, 2021 at 07:51:01AM -0700, Kees Cook wrote:
> There is no need to memset() both dvs_grid_info and dvs_stat_grid_info
> separately: they are part of the same union. Instead, just zero the
> union itself. This additionally avoids a false positive (due to a
> gcc optimization bug[1]) when building with the coming FORTIFY_SOURCE
> improvements:
> In function 'fortify_memset_chk',
>     inlined from 'sh_css_pipe_get_grid_info' at drivers/staging/media/atomisp/pci/sh_css.c:5186:3,
>     inlined from 'ia_css_stream_create' at drivers/staging/media/atomisp/pci/sh_css.c:9442:10:
> ./include/linux/fortify-string.h:199:4: warning: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wattribute-warning]
>   199 |    __write_overflow_field();
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~
> [1]
> Signed-off-by: Kees Cook <>

Acked-by: Sakari Ailus <>

Sakari Ailus

      reply	other threads:[~2021-07-11 15:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-11 14:51 [PATCH] media: atomisp: Perform a single memset() for union Kees Cook
2021-07-11 15:16 ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).