From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F0A772 for ; Tue, 13 Jul 2021 21:54:57 +0000 (UTC) Received: by mail-io1-f43.google.com with SMTP id y16so6053758iol.12 for ; Tue, 13 Jul 2021 14:54:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vQR14mDYGRZudVO/vm+/uumKq9eJAAdAbt89gWEA6Es=; b=VZwnvp0vevBdlpzSXpbbHyO+2SJelGWcJpwp7/EIz3WvI6E6rt+SUJ9iO3GyqDYtjQ VBz0ak5pM7x8FXPoPDcehmpluO7LT0XbTtm0MtoVuRg/JAbf/OVlMF1lwx+09T0b8K8n tA0VBOLD+dgJ4OGZ8sesSYfeW+Oi5d+65Czs7ie0GUFL4DhoK0gAliB8/gTze3nrxosR Zm88xhnbdz4tclozFZtE0c/IjYe5nYD4yabpoj9mlaLKYI8FFPdwPUoSTX15bWyTc78j DxG4kgS/s7eFX0Mcq0V9lNaoiPyqlPcKtaAJJ7myudMK8yb1WMt1v4jXawbrOPhtpTsT Q0bQ== X-Gm-Message-State: AOAM533C1OEe196Q4VPz3ou3GLVFKDFbsPy4O4Hl+93pAXQvy4NsgXbs PodMWNtTGaVsZz1YxnlHJg== X-Google-Smtp-Source: ABdhPJxa7LGy2aor+8xsTD+ZHPFkSK5n13X7esyQ/aYx7n9iEBpWYKVigQ+MizNcawUTJTTMHrd28A== X-Received: by 2002:a02:ad08:: with SMTP id s8mr6042037jan.40.1626213296380; Tue, 13 Jul 2021 14:54:56 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id i2sm113580ilq.83.2021.07.13.14.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 14:54:55 -0700 (PDT) Received: (nullmailer pid 911660 invoked by uid 1000); Tue, 13 Jul 2021 21:54:52 -0000 Date: Tue, 13 Jul 2021 15:54:52 -0600 From: Rob Herring To: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman , linuxarm@huawei.com, mauro.chehab@huawei.com, Lee Jones , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v12 7/9] mfd: hi6421-spmi-pmic: move driver from staging Message-ID: <20210713215452.GA904937@robh.at.kernel.org> References: <0648370f8e83af64b56e06fb6c32196bb8cee151.1625477735.git.mchehab+huawei@kernel.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0648370f8e83af64b56e06fb6c32196bb8cee151.1625477735.git.mchehab+huawei@kernel.org> On Mon, Jul 05, 2021 at 11:38:48AM +0200, Mauro Carvalho Chehab wrote: > This driver is ready for mainstream. So, move it out of staging. > > Signed-off-by: Mauro Carvalho Chehab > --- > .../mfd/hisilicon,hi6421-spmi-pmic.yaml | 134 ++++++++++++++++++ > MAINTAINERS | 7 + > drivers/mfd/Kconfig | 16 +++ > drivers/mfd/Makefile | 1 + > drivers/mfd/hi6421-spmi-pmic.c | 66 +++++++++ > drivers/staging/Kconfig | 2 - > drivers/staging/Makefile | 1 - > drivers/staging/hikey9xx/Kconfig | 19 --- > drivers/staging/hikey9xx/Makefile | 3 - > drivers/staging/hikey9xx/TODO | 5 - > drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 66 --------- > .../hikey9xx/hisilicon,hi6421-spmi-pmic.yaml | 134 ------------------ > 12 files changed, 224 insertions(+), 230 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml > create mode 100644 drivers/mfd/hi6421-spmi-pmic.c > delete mode 100644 drivers/staging/hikey9xx/Kconfig > delete mode 100644 drivers/staging/hikey9xx/Makefile > delete mode 100644 drivers/staging/hikey9xx/TODO > delete mode 100644 drivers/staging/hikey9xx/hi6421-spmi-pmic.c > delete mode 100644 drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml > new file mode 100644 > index 000000000000..a2963bea87ea > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml > @@ -0,0 +1,134 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/hisilicon,hi6421-spmi-pmic.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HiSilicon 6421v600 SPMI PMIC > + > +maintainers: > + - Mauro Carvalho Chehab > + > +description: | > + HiSilicon 6421v600 should be connected inside a MIPI System Power Management > + (SPMI) bus. It provides interrupts and power supply. > + > + The GPIO and interrupt settings are represented as part of the top-level PMIC > + node. > + > + The SPMI controller part is provided by > + Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml > + > +properties: > + $nodename: > + pattern: "pmic@[0-9a-f]" > + > + compatible: > + const: hisilicon,hi6421v600-spmi > + > + reg: > + maxItems: 1 > + > + '#interrupt-cells': > + const: 2 > + > + interrupt-controller: true > + > + interrupts: > + maxItems: 1 > + description: GPIO used for IRQs > + > + regulators: > + type: object additionalProperties: false > + > + properties: > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + patternProperties: > + '^ldo[0-9]+@[0-9a-f]$': Doesn't match the example. Adding the above will highlight that. There's not a reg property, so you shouldn't have unit-addresses. > + type: object > + > + $ref: "/schemas/regulator/regulator.yaml#" Add: unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - regulators > + > +additionalProperties: false > + > +examples: > + - | > + /* pmic properties */ > + > + pmic: pmic@0 { > + compatible = "hisilicon,hi6421v600-spmi"; > + reg = <0 0>; > + > + #interrupt-cells = <2>; > + interrupt-controller; > + interrupts = <&gpio28 0 0>; > + > + regulators { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ldo3: LDO3 { > + regulator-name = "ldo3"; > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <2000000>; > + regulator-boot-on; > + }; > + > + ldo4: LDO4 { > + regulator-name = "ldo4"; > + regulator-min-microvolt = <1725000>; > + regulator-max-microvolt = <1900000>; > + regulator-boot-on; > + }; > + > + ldo9: LDO9 { > + regulator-name = "ldo9"; > + regulator-min-microvolt = <1750000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + }; > + > + ldo15: LDO15 { > + regulator-name = "ldo15"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3000000>; > + regulator-always-on; > + }; > + > + ldo16: LDO16 { > + regulator-name = "ldo16"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3000000>; > + regulator-boot-on; > + }; > + > + ldo17: LDO17 { > + regulator-name = "ldo17"; > + regulator-min-microvolt = <2500000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + ldo33: LDO33 { > + regulator-name = "ldo33"; > + regulator-min-microvolt = <2500000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + }; > + > + ldo34: LDO34 { > + regulator-name = "ldo34"; > + regulator-min-microvolt = <2600000>; > + regulator-max-microvolt = <3300000>; > + }; > + }; > + };