From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Phillip Potter <phil@philpotter.co.uk>,
gregkh@linuxfoundation.org, dan.carpenter@oracle.com,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory
Date: Tue, 20 Jul 2021 11:00:36 +0200 [thread overview]
Message-ID: <20210720090035.GB1406@agape.jhs> (raw)
In-Reply-To: <7bc43fb0-2dab-190b-c480-9e77cff863d4@lwfinger.net>
Hi all,
On Mon, Jul 19, 2021 at 06:46:16PM -0500, Larry Finger wrote:
> On 7/19/21 5:46 PM, Phillip Potter wrote:
> > Move all C source files from the core subdirectory to the root
> > folder of the driver, and adjust Makefile accordingly. The ultmate
> > goal is to remove hal layer and fold its functionalty into the main
> > sources. At this point, the distinction between hal and core will be
> > meaningless, so this is the first step towards simplifying the file
> > layout.
> >
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> > ---
> > drivers/staging/rtl8188eu/Makefile | 34 +++++++++----------
> > drivers/staging/rtl8188eu/{core => }/rtw_ap.c | 0
> > .../staging/rtl8188eu/{core => }/rtw_cmd.c | 0
> > .../staging/rtl8188eu/{core => }/rtw_efuse.c | 0
> > .../rtl8188eu/{core => }/rtw_ieee80211.c | 0
> > .../rtl8188eu/{core => }/rtw_ioctl_set.c | 0
> > .../staging/rtl8188eu/{core => }/rtw_iol.c | 0
>
>
> I think this is just source churning. The current setup with include. core.
> hal and os_dep subdirectories are not opressive.
>
> Larry
>
>
maybe the information we will need one day is:
will the core/-os_dep/-hal/-include/-directory-structure be
welcomed in mainline wireless subsystem, when an rtl* driver
will be perfectly tuned?
At the moment I can't see such a directory organization
in any of the realtek wireless driver.
Sure there's time for that ;),
Thank you,
fabio
next prev parent reply other threads:[~2021-07-20 9:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 22:46 [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory Phillip Potter
2021-07-19 23:46 ` Larry Finger
2021-07-20 9:00 ` Fabio Aiuto [this message]
2021-07-20 22:54 ` Phillip Potter
2021-07-21 7:51 ` Fabio Aiuto
2021-07-21 0:22 ` Larry Finger
2021-07-21 7:47 ` Fabio Aiuto
2021-07-21 7:49 ` Phillip Potter
2021-07-21 17:33 ` Larry Finger
2021-07-21 18:28 ` Dan Carpenter
2021-07-21 19:18 ` Larry Finger
2021-07-22 10:44 ` Phillip Potter
2021-07-22 13:28 ` Greg KH
2021-07-22 16:30 ` Larry Finger
2021-07-22 22:12 ` Phillip Potter
2021-07-20 22:51 ` Phillip Potter
2021-07-21 8:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720090035.GB1406@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).