* [PATCH] staging: rtl8723bs: select CONFIG_CRYPTO_LIB_ARC4
@ 2021-07-21 15:35 Arnd Bergmann
2021-07-21 16:26 ` Fabio Aiuto
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-07-21 15:35 UTC (permalink / raw)
To: Greg Kroah-Hartman, Fabio Aiuto
Cc: Arnd Bergmann, linux-staging, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The other rtlwifi drivers already have this, but r8723bs
was converted to the generic implementation without adding
the select:
ERROR: modpost: "arc4_crypt" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
ERROR: modpost: "arc4_setkey" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
Fixes: 1b11e893eda0 ("staging: rtl8723bs: replace private arc4 encryption with in-kernel one")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/staging/rtl8723bs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8723bs/Kconfig b/drivers/staging/rtl8723bs/Kconfig
index a88467334dac..7eae820eae3b 100644
--- a/drivers/staging/rtl8723bs/Kconfig
+++ b/drivers/staging/rtl8723bs/Kconfig
@@ -5,6 +5,7 @@ config RTL8723BS
depends on m
select WIRELESS_EXT
select WEXT_PRIV
+ select CRYPTO_LIB_ARC4
help
This option enables support for RTL8723BS SDIO drivers, such as
the wifi found on the 1st gen Intel Compute Stick, the CHIP
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: select CONFIG_CRYPTO_LIB_ARC4
2021-07-21 15:35 [PATCH] staging: rtl8723bs: select CONFIG_CRYPTO_LIB_ARC4 Arnd Bergmann
@ 2021-07-21 16:26 ` Fabio Aiuto
0 siblings, 0 replies; 2+ messages in thread
From: Fabio Aiuto @ 2021-07-21 16:26 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Greg Kroah-Hartman, Arnd Bergmann, linux-staging, linux-kernel
On Wed, Jul 21, 2021 at 05:35:44PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The other rtlwifi drivers already have this, but r8723bs
> was converted to the generic implementation without adding
> the select:
>
> ERROR: modpost: "arc4_crypt" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
> ERROR: modpost: "arc4_setkey" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
>
> Fixes: 1b11e893eda0 ("staging: rtl8723bs: replace private arc4 encryption with in-kernel one")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/rtl8723bs/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rtl8723bs/Kconfig b/drivers/staging/rtl8723bs/Kconfig
> index a88467334dac..7eae820eae3b 100644
> --- a/drivers/staging/rtl8723bs/Kconfig
> +++ b/drivers/staging/rtl8723bs/Kconfig
> @@ -5,6 +5,7 @@ config RTL8723BS
> depends on m
> select WIRELESS_EXT
> select WEXT_PRIV
> + select CRYPTO_LIB_ARC4
> help
> This option enables support for RTL8723BS SDIO drivers, such as
> the wifi found on the 1st gen Intel Compute Stick, the CHIP
> --
> 2.29.2
>
Acked-by: Fabio Aiuto <fabioaiuto83@gmail.com>
thank you,
fabio
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-21 16:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 15:35 [PATCH] staging: rtl8723bs: select CONFIG_CRYPTO_LIB_ARC4 Arnd Bergmann
2021-07-21 16:26 ` Fabio Aiuto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).