From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from challenge-bot.com (ozzloy.lifeafterking.org [208.85.243.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD0D46D19 for ; Tue, 17 Aug 2021 04:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=challenge-bot.com; s=20180430; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=80wuYmqec+tkN81Ry5/hAJbtjz7ZSJszLbUYJbgNwnc=; b=RMLTzz8heejfvkbtBduZvmdqg S9yiMzEJiTPyJW7XTmDP8mzwAl6/i99oxuw5iDkQw5udghxROT+R3DANsuX4z+AtiYFt6YF/7RJc4 S6rTHDZdRo2xCYMCjxOQsYfmkX9ipcDO2TpadfNQXveV+GQA35NPchXc1VcB0lQ6C9EDQ=; Received: from ozzloy by challenge-bot.com with local (Exim 4.92) (envelope-from ) id 1mFqkI-0004Om-NX; Mon, 16 Aug 2021 21:30:38 -0700 Date: Mon, 16 Aug 2021 21:30:38 -0700 From: daniel watson To: Greg Kroah-Hartman Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging:iio:ade7854 surround complex defines in parentheses Message-ID: <20210817043038.GA9492@challenge-bot.com> References: <20210815023115.13016-1-ozzloy@challenge-bot.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) If this is a false positive from checkpatch, I can submit it as an example to the checkpatch maintainers. Do you think I should? On Sun, Aug 15, 2021 at 08:25:51AM +0200, Greg Kroah-Hartman wrote: > On Sat, Aug 14, 2021 at 07:31:15PM -0700, daniel watson wrote: > > Error found by checkpatch.pl > > What error? $ git checkout 36a21d5172 drivers/staging/iio/meter/ade7854.h # before Updated 1 path from 638ccd1543654 $ ./scripts/checkpatch.pl --terse --types COMPLEX_MACRO \ drivers/staging/iio/meter/ade7854.h drivers/staging/iio/meter/ade7854.h:142: ERROR: Macros with complex values should be enclosed in parentheses drivers/staging/iio/meter/ade7854.h:143: ERROR: Macros with complex values should be enclosed in parentheses drivers/staging/iio/meter/ade7854.h:144: ERROR: Macros with complex values should be enclosed in parentheses total: 3 errors, 0 warnings, 0 checks, 173 lines checked $ git checkout 143b51a80978 drivers/staging/iio/meter/ade7854.h # after Updated 1 path from 21c208a36476a $ ./scripts/checkpatch.pl --terse --types COMPLEX_MACRO \ drivers/staging/iio/meter/ade7854.h $ > > Signed-off-by: daniel watson > > Capitalize your name? I can remake this patch with my name capitalized if the patch is worth remaking. I'll be sure to capitalize in future sign-off lines for Linux. > This is not a real change that is needed, just look at the code to > verify that. Agreed, this is not a huge change. I thought small changes were acceptable, if they get rid of errors from checkpatch. I got that impression from this video Write and Submit your first Linux kernel Patch https://youtu.be/LLBrBBImJt4 At around 15 minutes, you create a patch which removes curly braces from an if-else. That seemed comparable to the change in this patch. That video was posted over a decade ago, so I would understand if things are different now. > > thanks, > > greg k-h You're welcome! Thank you too, that was a super fast response! I am happy to get a direct response from you!