From: kernel test robot <lkp@intel.com>
To: sidraya.bj@pathpartnertech.com, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, prashanth.ka@pathpartnertech.com,
praneeth@ti.com, mchehab@kernel.org, linux-media@vger.kernel.org,
praveen.ap@pathpartnertech.com,
Sidraya <sidraya.bj@pathpartnertech.com>
Subject: Re: [PATCH 27/30] media: platform: vxd: Kconfig: Add Video decoder Kconfig and Makefile
Date: Thu, 19 Aug 2021 13:59:53 +0800 [thread overview]
Message-ID: <202108191330.Z8vEIQLg-lkp@intel.com> (raw)
In-Reply-To: <20210818141037.19990-28-sidraya.bj@pathpartnertech.com>
[-- Attachment #1: Type: text/plain, Size: 8098 bytes --]
Hi,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on staging/staging-testing driver-core/driver-core-testing linus/master v5.14-rc6 next-20210818]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/sidraya-bj-pathpartnertech-com/TI-Video-Decoder-driver-upstreaming-to-v5-14-rc6-kernel/20210818-221811
base: git://linuxtv.org/media_tree.git master
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/f42ae4f45639a6214f9e775d4280061bf52fc229
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review sidraya-bj-pathpartnertech-com/TI-Video-Decoder-driver-upstreaming-to-v5-14-rc6-kernel/20210818-221811
git checkout f42ae4f45639a6214f9e775d4280061bf52fc229
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/staging/media/vxd/decoder/../common/img_mem_unified.c: In function 'unified_free':
>> drivers/staging/media/vxd/decoder/../common/img_mem_unified.c:159:17: error: implicit declaration of function 'vunmap'; did you mean 'kunmap'? [-Werror=implicit-function-declaration]
159 | vunmap(buffer->kptr);
| ^~~~~~
| kunmap
drivers/staging/media/vxd/decoder/../common/img_mem_unified.c: In function 'unified_map_km':
>> drivers/staging/media/vxd/decoder/../common/img_mem_unified.c:197:24: error: implicit declaration of function 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]
197 | buffer->kptr = vmap((struct page **)pages, num_pages, VM_MAP, prot);
| ^~~~
| kmap
>> drivers/staging/media/vxd/decoder/../common/img_mem_unified.c:197:63: error: 'VM_MAP' undeclared (first use in this function); did you mean 'VM_MTE'?
197 | buffer->kptr = vmap((struct page **)pages, num_pages, VM_MAP, prot);
| ^~~~~~
| VM_MTE
drivers/staging/media/vxd/decoder/../common/img_mem_unified.c:197:63: note: each undeclared identifier is reported only once for each function it appears in
cc1: some warnings being treated as errors
vim +159 drivers/staging/media/vxd/decoder/../common/img_mem_unified.c
76b88427fbba69 Sidraya 2021-08-18 145
76b88427fbba69 Sidraya 2021-08-18 146 static void unified_free(struct heap *heap, struct buffer *buffer)
76b88427fbba69 Sidraya 2021-08-18 147 {
76b88427fbba69 Sidraya 2021-08-18 148 void *dev = buffer->device;
76b88427fbba69 Sidraya 2021-08-18 149 void *sgt = buffer->priv;
76b88427fbba69 Sidraya 2021-08-18 150 void *sgl;
76b88427fbba69 Sidraya 2021-08-18 151
76b88427fbba69 Sidraya 2021-08-18 152 dev_dbg(dev, "%s:%d buffer %d (0x%p)\n", __func__, __LINE__,
76b88427fbba69 Sidraya 2021-08-18 153 buffer->id, buffer);
76b88427fbba69 Sidraya 2021-08-18 154
76b88427fbba69 Sidraya 2021-08-18 155 if (buffer->kptr) {
76b88427fbba69 Sidraya 2021-08-18 156 dev_dbg(dev, "%s vunmap 0x%p\n", __func__, buffer->kptr);
76b88427fbba69 Sidraya 2021-08-18 157 dma_unmap_sg(dev, img_mmu_get_sgl(sgt), img_mmu_get_orig_nents(sgt),
76b88427fbba69 Sidraya 2021-08-18 158 DMA_FROM_DEVICE);
76b88427fbba69 Sidraya 2021-08-18 @159 vunmap(buffer->kptr);
76b88427fbba69 Sidraya 2021-08-18 160 }
76b88427fbba69 Sidraya 2021-08-18 161
76b88427fbba69 Sidraya 2021-08-18 162 sgl = img_mmu_get_sgl(sgt);
76b88427fbba69 Sidraya 2021-08-18 163 while (sgl) {
76b88427fbba69 Sidraya 2021-08-18 164 __free_page(sg_page(sgl));
76b88427fbba69 Sidraya 2021-08-18 165 sgl = sg_next(sgl);
76b88427fbba69 Sidraya 2021-08-18 166 }
76b88427fbba69 Sidraya 2021-08-18 167 sg_free_table(sgt);
76b88427fbba69 Sidraya 2021-08-18 168 kfree(sgt);
76b88427fbba69 Sidraya 2021-08-18 169 }
76b88427fbba69 Sidraya 2021-08-18 170
76b88427fbba69 Sidraya 2021-08-18 171 static int unified_map_km(struct heap *heap, struct buffer *buffer)
76b88427fbba69 Sidraya 2021-08-18 172 {
76b88427fbba69 Sidraya 2021-08-18 173 void *dev = buffer->device;
76b88427fbba69 Sidraya 2021-08-18 174 void *sgt = buffer->priv;
76b88427fbba69 Sidraya 2021-08-18 175 void *sgl = img_mmu_get_sgl(sgt);
76b88427fbba69 Sidraya 2021-08-18 176 unsigned int num_pages = sg_nents(sgl);
76b88427fbba69 Sidraya 2021-08-18 177 unsigned int orig_nents = img_mmu_get_orig_nents(sgt);
76b88427fbba69 Sidraya 2021-08-18 178 void **pages;
76b88427fbba69 Sidraya 2021-08-18 179 int ret;
76b88427fbba69 Sidraya 2021-08-18 180 pgprot_t prot;
76b88427fbba69 Sidraya 2021-08-18 181
76b88427fbba69 Sidraya 2021-08-18 182 dev_dbg(dev, "%s:%d buffer %d (0x%p)\n", __func__, __LINE__, buffer->id, buffer);
76b88427fbba69 Sidraya 2021-08-18 183
76b88427fbba69 Sidraya 2021-08-18 184 if (buffer->kptr) {
76b88427fbba69 Sidraya 2021-08-18 185 dev_warn(dev, "%s called for already mapped buffer %d\n", __func__, buffer->id);
76b88427fbba69 Sidraya 2021-08-18 186 return 0;
76b88427fbba69 Sidraya 2021-08-18 187 }
76b88427fbba69 Sidraya 2021-08-18 188
76b88427fbba69 Sidraya 2021-08-18 189 pages = kmalloc_array(num_pages, sizeof(void *), GFP_KERNEL);
76b88427fbba69 Sidraya 2021-08-18 190 if (!pages)
76b88427fbba69 Sidraya 2021-08-18 191 return -ENOMEM;
76b88427fbba69 Sidraya 2021-08-18 192
76b88427fbba69 Sidraya 2021-08-18 193 img_mmu_get_pages(pages, sgt);
76b88427fbba69 Sidraya 2021-08-18 194
76b88427fbba69 Sidraya 2021-08-18 195 prot = PAGE_KERNEL;
76b88427fbba69 Sidraya 2021-08-18 196 prot = pgprot_writecombine(prot);
76b88427fbba69 Sidraya 2021-08-18 @197 buffer->kptr = vmap((struct page **)pages, num_pages, VM_MAP, prot);
76b88427fbba69 Sidraya 2021-08-18 198 kfree(pages);
76b88427fbba69 Sidraya 2021-08-18 199 if (!buffer->kptr) {
76b88427fbba69 Sidraya 2021-08-18 200 dev_err(dev, "%s vmap failed!\n", __func__);
76b88427fbba69 Sidraya 2021-08-18 201 return -EFAULT;
76b88427fbba69 Sidraya 2021-08-18 202 }
76b88427fbba69 Sidraya 2021-08-18 203
76b88427fbba69 Sidraya 2021-08-18 204 ret = dma_map_sg(dev, sgl, orig_nents, DMA_FROM_DEVICE);
76b88427fbba69 Sidraya 2021-08-18 205
76b88427fbba69 Sidraya 2021-08-18 206 if (ret <= 0) {
76b88427fbba69 Sidraya 2021-08-18 207 dev_err(dev, "%s dma_map_sg failed!\n", __func__);
76b88427fbba69 Sidraya 2021-08-18 208 vunmap(buffer->kptr);
76b88427fbba69 Sidraya 2021-08-18 209 return -EFAULT;
76b88427fbba69 Sidraya 2021-08-18 210 }
76b88427fbba69 Sidraya 2021-08-18 211 dev_dbg(dev, "%s:%d buffer %d orig_nents %d nents %d\n", __func__,
76b88427fbba69 Sidraya 2021-08-18 212 __LINE__, buffer->id, orig_nents, ret);
76b88427fbba69 Sidraya 2021-08-18 213
76b88427fbba69 Sidraya 2021-08-18 214 img_mmu_set_sgt_nents(sgt, ret);
76b88427fbba69 Sidraya 2021-08-18 215
76b88427fbba69 Sidraya 2021-08-18 216 dev_dbg(dev, "%s:%d buffer %d vmap to 0x%p\n", __func__, __LINE__,
76b88427fbba69 Sidraya 2021-08-18 217 buffer->id, buffer->kptr);
76b88427fbba69 Sidraya 2021-08-18 218
76b88427fbba69 Sidraya 2021-08-18 219 return 0;
76b88427fbba69 Sidraya 2021-08-18 220 }
76b88427fbba69 Sidraya 2021-08-18 221
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 70986 bytes --]
next prev parent reply other threads:[~2021-08-19 6:00 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 14:10 [PATCH 00/30] TI Video Decoder driver upstreaming to v5.14-rc6 kernel sidraya.bj
2021-08-18 14:10 ` [PATCH 01/30] dt-bindings: Add binding for img,d5500-vxd for DRA8x sidraya.bj
2021-08-18 14:10 ` [PATCH 02/30] v4l: vxd-dec: Create mmu programming helper library sidraya.bj
2021-08-18 14:37 ` Greg KH
2021-08-18 14:10 ` [PATCH 03/30] v4l: vxd-dec: Create vxd_dec Mem Manager " sidraya.bj
2021-08-24 13:34 ` Dan Carpenter
2021-09-14 3:40 ` Sidraya Jayagond
2021-09-14 4:35 ` Greg KH
2021-09-20 18:07 ` Sidraya Jayagond
2021-08-18 14:10 ` [PATCH 04/30] v4l: vxd-dec: Add vxd " sidraya.bj
2021-08-18 14:10 ` [PATCH 05/30] v4l: vxd-dec: Add IMG VXD Video Decoder mem to mem drive sidraya.bj
2021-08-18 14:10 ` [PATCH 06/30] v4l: vxd-dec: Add hardware control modules sidraya.bj
2021-08-18 14:10 ` [PATCH 07/30] v4l: vxd-dec: Add vxd core module sidraya.bj
2021-08-18 14:10 ` [PATCH 08/30] v4l: vxd-dec: Add translation control modules sidraya.bj
2021-08-18 14:10 ` [PATCH 09/30] v4l: vxd-dec: Add idgen api modules sidraya.bj
2021-08-24 14:00 ` Dan Carpenter
2021-09-14 4:24 ` Sidraya Jayagond
2021-08-18 14:10 ` [PATCH 10/30] v4l: vxd-dec: Add utility modules sidraya.bj
2021-08-18 14:10 ` [PATCH 11/30] v4l: vxd-dec: Add TALMMU module sidraya.bj
2021-08-18 14:10 ` [PATCH 12/30] v4l: vxd-dec: Add VDEC MMU wrapper sidraya.bj
2021-08-18 14:10 ` [PATCH 13/30] v4l: vxd-dec: Add Bistream Preparser (BSPP) module sidraya.bj
2021-08-18 14:10 ` [PATCH 14/30] v4l: vxd-dec: Add common headers sidraya.bj
2021-08-18 14:10 ` [PATCH 15/30] v4l: vxd-dec: Add firmware interface headers sidraya.bj
2021-08-18 14:10 ` [PATCH 16/30] v4l: vxd-dec: Add pool api modules sidraya.bj
2021-08-18 14:10 ` [PATCH 17/30] v4l: vxd-dec: This patch implements resource manage component sidraya.bj
2021-08-18 14:10 ` [PATCH 18/30] v4l: vxd-dec: This patch implements pixel processing library sidraya.bj
2021-08-18 14:10 ` [PATCH 19/30] v4l:vxd-dec:vdecdd utility library sidraya.bj
2021-08-18 14:10 ` [PATCH 20/30] v4l:vxd-dec:Decoder resource component sidraya.bj
2021-08-18 14:10 ` [PATCH 21/30] v4l:vxd-dec:Decoder Core Component sidraya.bj
2021-08-18 14:10 ` [PATCH 22/30] v4l:vxd-dec:vdecdd headers added sidraya.bj
2021-08-18 14:10 ` [PATCH 23/30] v4l:vxd-dec:Decoder Component sidraya.bj
2021-08-18 14:10 ` [PATCH 24/30] v4l:vxd-dec: Add resource manager sidraya.bj
2021-08-18 14:38 ` Greg KH
2021-08-18 14:10 ` [PATCH 25/30] v4l: videodev2: Add 10bit definitions for NV12 and NV16 color formats sidraya.bj
2021-08-24 16:14 ` Nicolas Dufresne
2021-08-18 14:10 ` [PATCH 26/30] media: Kconfig: Add Video decoder kconfig and Makefile entries sidraya.bj
2021-08-18 14:10 ` [PATCH 27/30] media: platform: vxd: Kconfig: Add Video decoder Kconfig and Makefile sidraya.bj
2021-08-18 18:24 ` kernel test robot
2021-08-19 5:59 ` kernel test robot [this message]
2021-08-18 14:10 ` [PATCH 28/30] IMG DEC V4L2 Interface function implementations sidraya.bj
2021-08-18 19:22 ` kernel test robot
2021-08-18 14:10 ` [PATCH 29/30] arm64: dts: dra82: Add v4l2 vxd_dec device node sidraya.bj
2021-08-18 16:44 ` Nishanth Menon
2021-08-18 14:10 ` [PATCH 30/30] ARM64: ti_sdk_arm64_release_defconfig: Enable d5520 video decoder driver sidraya.bj
2021-08-18 14:25 ` Bajjuri, Praneeth
2021-08-18 16:35 ` Nishanth Menon
2021-08-24 13:06 ` [PATCH 00/30] TI Video Decoder driver upstreaming to v5.14-rc6 kernel Hans Verkuil
2021-08-24 13:36 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108191330.Z8vEIQLg-lkp@intel.com \
--to=lkp@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=praneeth@ti.com \
--cc=prashanth.ka@pathpartnertech.com \
--cc=praveen.ap@pathpartnertech.com \
--cc=sidraya.bj@pathpartnertech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).