From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f74.google.com (mail-ua1-f74.google.com [209.85.222.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 810DE5C82 for ; Mon, 12 Sep 2022 21:46:10 +0000 (UTC) Received: by mail-ua1-f74.google.com with SMTP id l36-20020ab01667000000b003b9b2a5bb51so740843uae.16 for ; Mon, 12 Sep 2022 14:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:from:subject:message-id:mime-version:date:from:to:cc:subject :date; bh=MLnObt6zyGNlUZeZEFTlRwd6ME4C5crSaLu9fRVEkDk=; b=GijQYHGGKwWbSF23cH9ICaVQFmj05rI1nUVD/vvAx3qrpszfnliUJK7YyB08pOymye gZDtQa+BwsrYcuM+aLvqJcs3ZOWEdbsHfyTD353Zl0vIaMkZXxcwo26iJuNzV8uGhtej ccke7EreWF7PQiGsN44hoJRscVySyu6513ywj3HbPlZUtKWW39CSJgdjSYNRtUaln4Sd FD4jEUB11cGgjIDcfLHO3ch5Bu8BTw8JOepyrnk2D4r4N6Sp5Ysrb1ocp3fopx8LofQ0 Z5xz1Xhfg25SR9/vkyYbMc2/NwwfYpEg52xlbfkolcTkZXD3hVNY+aVupqtvunA96OsR yWKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date; bh=MLnObt6zyGNlUZeZEFTlRwd6ME4C5crSaLu9fRVEkDk=; b=eOvSreRIlyygUatcZpY+m6WsRxfXgR4Oigu7+5zp0Aa/hrWHQhs4WzjLL5SdB//cHx YSn/FPlAidYBl131mP0zd7ccU3ggYp2fLMFKlig9Wvutzmg4oobyLj8MVDgS0UJFcJ6w dWJDU3YPZTHC2mKVpLFyNeAKDrTc8aGbStxUB03ofyMMSA9NY1gsChKCaSy1/RfdQfsE IRP7GJi1IvbZnXlAW1QxYAEJdMn1YQEvxB9AXgmTeBlRmZX2xVu9A+b/6qd7v+eF9fEu mrgbBEZsFcwu7FY/BCIY/OsrESs4U+Uu/uZFC5VBjJ3ifOaFkt9zfICxzCRbYcPyh/E1 tHJQ== X-Gm-Message-State: ACgBeo29e7iSKXzCO4pQG/iKFz3NEuhb1nTOvnHhSdYYH1QQhunp985n 9h6zaPBnsR3W+IrAr59cqqLDNe7naQ== X-Google-Smtp-Source: AA6agR5jsRUdlZ+bhJTNzFf9ZUErRQqlTOo1r7FaxXI7zoJ+qBN5MY8HjpaN4/oVyi/sNldrnOcuxSPJvw== X-Received: from nhuck.c.googlers.com ([fda3:e722:ac3:cc00:14:4d90:c0a8:39cc]) (user=nhuck job=sendgmr) by 2002:a67:ad15:0:b0:398:6aef:316b with SMTP id t21-20020a67ad15000000b003986aef316bmr4372894vsl.17.1663019169572; Mon, 12 Sep 2022 14:46:09 -0700 (PDT) Date: Mon, 12 Sep 2022 14:46:03 -0700 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.37.2.789.g6183377224-goog Message-ID: <20220912214607.929211-1-nhuck@google.com> Subject: [PATCH] staging: rtl8712: Fix return type of r8712_xmit_entry From: Nathan Huckleberry Cc: Nathan Huckleberry , Dan Carpenter , llvm@lists.linux.dev, Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Nathan Chancellor , Nick Desaulniers , Tom Rix , Sathish Kumar , "Fabio M. De Francesco" , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" The ndo_start_xmit field in net_device_ops is expected to be of type netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev). The mismatched return type breaks forward edge kCFI since the underlying function definition does not match the function hook definition. The return type of r8712_xmit_entry should be changed from int to netdev_tx_t. Reported-by: Dan Carpenter Link: https://github.com/ClangBuiltLinux/linux/issues/1703 Cc: llvm@lists.linux.dev Signed-off-by: Nathan Huckleberry --- drivers/staging/rtl8712/xmit_linux.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index 4a93839bf947..e84b9fa231cd 100644 --- a/drivers/staging/rtl8712/xmit_linux.c +++ b/drivers/staging/rtl8712/xmit_linux.c @@ -140,7 +140,7 @@ void r8712_xmit_complete(struct _adapter *padapter, struct xmit_frame *pxframe) pxframe->pkt = NULL; } -int r8712_xmit_entry(_pkt *pkt, struct net_device *netdev) +netdev_tx_t r8712_xmit_entry(_pkt *pkt, struct net_device *netdev) { struct xmit_frame *xmitframe = NULL; struct _adapter *adapter = netdev_priv(netdev); @@ -165,11 +165,11 @@ int r8712_xmit_entry(_pkt *pkt, struct net_device *netdev) } xmitpriv->tx_pkts++; xmitpriv->tx_bytes += xmitframe->attrib.last_txcmdsz; - return 0; + return NETDEV_TX_OK; _xmit_entry_drop: if (xmitframe) r8712_free_xmitframe(xmitpriv, xmitframe); xmitpriv->tx_drop++; dev_kfree_skb_any(pkt); - return 0; + return NETDEV_TX_OK; } -- 2.37.2.789.g6183377224-goog