From: Hans de Goede <hdegoede@redhat.com>
To: Fabio Aiuto <fabioaiuto83@gmail.com>, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 00/17] staging: rtl8723bs: remove 5Ghz code
Date: Tue, 22 Jun 2021 15:19:45 +0200 [thread overview]
Message-ID: <20bed383-adca-e2f0-bede-762707d052ac@redhat.com> (raw)
In-Reply-To: <cover.1624367071.git.fabioaiuto83@gmail.com>
Hi,
On 6/22/21 3:09 PM, Fabio Aiuto wrote:
> This patch series removes all occurences of 5Ghz code over the
> driver as required from driver's TODO list:
>
> - find and remove remaining code valid only for 5 GHz.
> most of the obvious one have been removed, but things
> like channel > 14 still exist.
>
> rtl8723bs work on 2.4Ghz band and supports 802.11bgn standards.
> So all code related to 802.11a/ac standard is removed, as well
> as code related to channel numbers above 14.
>
> VHT code is deleted as well, for it's related to 802.11ac.
>
> Comments are fixed accordingly and many unused variables are
> deleted.
>
> Every single patch of this series has been tested on a
> Lenovo Ideapad MIIX 300-10IBY except for the last one,
> for obvious reason (it deletes just the TODO item).
> So:
>
> Tested-by: Fabio Auto <fabioaiuto83@gmail.com>
From a quick scan the series looks ok to me now:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ------------------------------------------------
> Changes in v3:
> - delete a condition in patch 1 as pointed out by
> Hans
> - fix in 'Changes in v2' text (pointed out).
> Changes in v2:
> - drop v1 15/18 patch, for it deliberately
> does register writes as pointed out by Hans.
>
> Fabio Aiuto (17):
> staging: rtl8723bs: remove all 5Ghz network types
> staging: rtl8723bs: remove code related to unsupported channel
> bandwidth
> staging: rtl8723bs: remove unused enum items related to channel
> bonding
> staging: rtl8723bs: rename enum items related to channel bonding
> staging: rtl8723bs: remove 5Ghz field in struct registry_priv
> staging: rtl8723bs: remove struct rt_channel_plan_5g
> staging: rtl8723bs: remove all branchings between 2.4Ghz and 5Ghz band
> types
> staging: rtl8723bs: beautify prototypes in include/hal_com_phycfg.h
> staging: rtl8723bs: remove 5Ghz code related to channel plan
> definition
> staging: rtl8723bs: remove some unused 5Ghz macro definitions
> staging: rtl8723bs: remove 5Ghz code related to RF power calibration
> staging: rtl8723bs: remove VHT dead code
> staging: rtl8723bs: remove unused ODM_CMNINFO_BOARD_TYPE enum item
> staging: rtl8723bs: fix macro value for 2.4Ghz only device
> staging: rtl8723bs: remove obsolete 5Ghz comments
> staging: rtl8723bs: fix check allowing 5Ghz settings
> staging: rtl8723bs: remove item from TODO list
>
> drivers/staging/rtl8723bs/TODO | 2 -
> drivers/staging/rtl8723bs/core/rtw_ap.c | 11 +-
> .../staging/rtl8723bs/core/rtw_ieee80211.c | 22 +-
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 -
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 328 ++---
> .../staging/rtl8723bs/core/rtw_wlan_util.c | 29 +-
> drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 +-
> .../staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 4 +-
> .../staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 5 +-
> drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h | 1 -
> .../staging/rtl8723bs/hal/HalHWImg8723B_BB.c | 17 +-
> .../staging/rtl8723bs/hal/HalHWImg8723B_RF.c | 595 ++++-----
> .../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 19 +-
> drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 -
> drivers/staging/rtl8723bs/hal/hal_com.c | 241 ----
> .../staging/rtl8723bs/hal/hal_com_phycfg.c | 1059 +++--------------
> drivers/staging/rtl8723bs/hal/odm.c | 50 -
> drivers/staging/rtl8723bs/hal/odm.h | 42 +-
> drivers/staging/rtl8723bs/hal/odm_DIG.c | 2 -
> .../rtl8723bs/hal/odm_EdcaTurboCheck.c | 4 +-
> .../rtl8723bs/hal/odm_RegConfig8723B.c | 5 +-
> .../rtl8723bs/hal/odm_RegConfig8723B.h | 2 -
> drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 1 -
> .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 41 +-
> .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 43 +-
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 5 -
> .../rtl8723bs/include/Hal8192CPhyReg.h | 2 -
> drivers/staging/rtl8723bs/include/drv_types.h | 10 +-
> drivers/staging/rtl8723bs/include/hal_com.h | 62 +-
> .../rtl8723bs/include/hal_com_phycfg.h | 198 +--
> .../staging/rtl8723bs/include/hal_com_reg.h | 1 -
> drivers/staging/rtl8723bs/include/hal_data.h | 40 +-
> drivers/staging/rtl8723bs/include/hal_pg.h | 2 -
> drivers/staging/rtl8723bs/include/hal_phy.h | 10 -
> drivers/staging/rtl8723bs/include/ieee80211.h | 67 +-
> .../staging/rtl8723bs/include/rtl8723b_xmit.h | 21 -
> drivers/staging/rtl8723bs/include/rtw_ht.h | 4 -
> .../staging/rtl8723bs/include/rtw_mlme_ext.h | 52 +-
> drivers/staging/rtl8723bs/include/rtw_rf.h | 33 +-
> drivers/staging/rtl8723bs/include/wifi.h | 1 -
> .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 4 -
> .../staging/rtl8723bs/os_dep/ioctl_linux.c | 8 +-
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 13 +-
> drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 4 -
> 44 files changed, 640 insertions(+), 2439 deletions(-)
>
next prev parent reply other threads:[~2021-06-22 13:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 13:09 [PATCH v3 00/17] staging: rtl8723bs: remove 5Ghz code Fabio Aiuto
2021-06-22 13:09 ` [PATCH v3 01/17] staging: rtl8723bs: remove all 5Ghz network types Fabio Aiuto
2021-06-22 13:09 ` [PATCH v3 02/17] staging: rtl8723bs: remove code related to unsupported channel bandwidth Fabio Aiuto
2021-06-22 13:09 ` [PATCH v3 03/17] staging: rtl8723bs: remove unused enum items related to channel bonding Fabio Aiuto
2021-06-22 13:09 ` [PATCH v3 04/17] staging: rtl8723bs: rename " Fabio Aiuto
2021-06-22 13:09 ` [PATCH v3 05/17] staging: rtl8723bs: remove 5Ghz field in struct registry_priv Fabio Aiuto
2021-06-22 13:09 ` [PATCH v3 06/17] staging: rtl8723bs: remove struct rt_channel_plan_5g Fabio Aiuto
2021-06-22 13:09 ` [PATCH v3 07/17] staging: rtl8723bs: remove all branchings between 2.4Ghz and 5Ghz band types Fabio Aiuto
2021-06-22 13:09 ` [PATCH v3 08/17] staging: rtl8723bs: beautify prototypes in include/hal_com_phycfg.h Fabio Aiuto
2021-06-22 13:09 ` [PATCH v3 09/17] staging: rtl8723bs: remove 5Ghz code related to channel plan definition Fabio Aiuto
2021-06-22 13:09 ` [PATCH v3 10/17] staging: rtl8723bs: remove some unused 5Ghz macro definitions Fabio Aiuto
2021-06-22 13:09 ` [PATCH v3 11/17] staging: rtl8723bs: remove 5Ghz code related to RF power calibration Fabio Aiuto
2021-06-22 13:09 ` [PATCH v3 12/17] staging: rtl8723bs: remove VHT dead code Fabio Aiuto
2021-06-22 13:09 ` [PATCH v3 13/17] staging: rtl8723bs: remove unused ODM_CMNINFO_BOARD_TYPE enum item Fabio Aiuto
2021-06-22 13:09 ` [PATCH v3 14/17] staging: rtl8723bs: fix macro value for 2.4Ghz only device Fabio Aiuto
2021-06-22 13:09 ` [PATCH v3 15/17] staging: rtl8723bs: remove obsolete 5Ghz comments Fabio Aiuto
2021-06-22 13:10 ` [PATCH v3 16/17] staging: rtl8723bs: fix check allowing 5Ghz settings Fabio Aiuto
2021-06-22 13:10 ` [PATCH v3 17/17] staging: rtl8723bs: remove item from TODO list Fabio Aiuto
2021-06-22 13:19 ` Hans de Goede [this message]
2021-06-22 13:22 ` [PATCH v3 00/17] staging: rtl8723bs: remove 5Ghz code Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20bed383-adca-e2f0-bede-762707d052ac@redhat.com \
--to=hdegoede@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).