From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAE432FAD for ; Tue, 17 Aug 2021 07:02:29 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id d6so30157029edt.7 for ; Tue, 17 Aug 2021 00:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UFmYgHQVoxPuJsPynH02ftjkrBh0tl5MvF/mFLmK8vY=; b=WMW9FNP9R3dolzpH193woafwzBLLaKspQXrMN+UCxK7fyWvdEeOEQ29MqyUy6U3FVd jiwao0ij2hZYf+uVcrBtrUtpIF7fSu7E0gGwNVHT8iejcrQexSePT59XNCyOVIrBQSKD FclKzIrcXMsA0O9q54F33d/m+6qJ7NL17o3UzWsTtjXlT2pc2CnOgaQhKgHj/btUH0SU a8ww2PU7fz99e0AVbZnhVhlSP27K9EZRZklm/fbmB9pztHnQ9tT9b9S9Np9Wd0TdFHwu ghSBFm5+rJhKrOWX6/wdKhluxeIUVicRbINcZhpGnDXE0E/+1Gma2EUSn3CQAL+6pcQD /7tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UFmYgHQVoxPuJsPynH02ftjkrBh0tl5MvF/mFLmK8vY=; b=c7xq5KB/Iwtp49yk7V4PK9tgoJ4tuFx3iMZSivmTl1RuclxtmQr8KCgetOdKQdyHLj JCf6s6On5Cs3HkFr7veCfI7GN4tRCryKutmFmTWTBFdyh99QRuKr1GVTcXdio7I2G3Mj GQxc8axv9bFYn65Wn9UNBG6NA2wlvag1eoLL645vMzDKHwHRMIe3nQSgJxDOYelFACr3 G29E7R8fbd3KGLbtkav+UFGGkAAv3gbQaMLBQHgAQK8FEWuGJD2j6j/6jvKyhQMCVP3Q gu8VhtvrO/jkakkUzwSbhx8TabhUQccdXkya0HDDt/Hcf2HyAFqRyiTeAH0+5nAErYHA VO9g== X-Gm-Message-State: AOAM531zwpt6Sr8WOxdPC6AxmClvJScaIUD5YpCBqOxdPsRHt+SnUMqh 5BamGWpnJFmJ8n4cl46IWQM= X-Google-Smtp-Source: ABdhPJyyvtVN6v8ACSLA2KGbgoNOP+qQ0I2BmP0yw5MFg4DGt0KZ+a8e7aOoPneL+xKYzOrJxvuAfQ== X-Received: by 2002:a05:6402:274d:: with SMTP id z13mr2472971edd.386.1629183748321; Tue, 17 Aug 2021 00:02:28 -0700 (PDT) Received: from ?IPv6:2a02:8108:96c0:3b88::4058? ([2a02:8108:96c0:3b88::4058]) by smtp.gmail.com with ESMTPSA id g14sm571343edr.47.2021.08.17.00.02.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Aug 2021 00:02:27 -0700 (PDT) Subject: Re: [PATCH v2 1/3] staging: r8188eu: remove set but unused variable from rtl8188e_Add_RateATid To: Phillip Potter , gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, martin@kaiser.cx, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20210816234459.132239-1-phil@philpotter.co.uk> <20210816234459.132239-2-phil@philpotter.co.uk> From: Michael Straube Message-ID: <4f02cbe9-ee5e-dcef-4b53-08baf5ad22ce@gmail.com> Date: Tue, 17 Aug 2021 09:01:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20210816234459.132239-2-phil@philpotter.co.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/17/21 1:44 AM, Phillip Potter wrote: > Remove set but unused variable init_rate from the rtl8188e_Add_RateATid > function in hal/rtl8188eu_cmd.c, as this fixes a kernel test robot > warning. Removing the call to get_highest_rate_idx has no side effects > here so is safe. > > Reported-by: kernel test robot > Signed-off-by: Phillip Potter > --- > drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c b/drivers/staging/r8188eu/hal/rtl8188e_cmd.c > index 6cbda9ab6e3f..4302054c6c83 100644 > --- a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c > +++ b/drivers/staging/r8188eu/hal/rtl8188e_cmd.c > @@ -155,7 +155,7 @@ void rtl8188e_Add_RateATid(struct adapter *pAdapter, u32 bitmap, u8 arg, u8 rssi > { > struct hal_data_8188e *haldata = GET_HAL_DATA(pAdapter); > > - u8 macid, init_rate, raid, shortGIrate = false; > + u8 macid, raid, shortGIrate = false; > > macid = arg&0x1f; > > @@ -167,13 +167,8 @@ void rtl8188e_Add_RateATid(struct adapter *pAdapter, u32 bitmap, u8 arg, u8 rssi > > bitmap |= ((raid<<28)&0xf0000000); > > - init_rate = get_highest_rate_idx(bitmap&0x0fffffff)&0x3f; > - > shortGIrate = (arg&BIT(5)) ? true : false; > > - if (shortGIrate) > - init_rate |= BIT(6); > - > raid = (bitmap>>28) & 0x0f; > > bitmap &= 0x0fffffff; > Looks good to me. Acked-by: Michael Straube Thanks, Michael