From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D515029D6 for ; Thu, 24 Jun 2021 09:02:54 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 67B7E613BE; Thu, 24 Jun 2021 09:02:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624525373; bh=lEMGdk+QOQQbwsmw6YQ5VqGUddHqHIPANLPyfPqVKt0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UrQeqrnIpm5zF/hj66Yx3a/b5o9V3+aQU95w/W/vQ083llgYO4RVMgvSAoDffF/VB OcLlOwFzmEefRiSxsq51jjJsmbzEAPcpPqs0iWM+H2wl2JTo9f1ICuupfXDDoybeXb aaJmboshD5Om5wOEdG5lN9FIN03WUJIpRRoXaLMeh91KgJixoCMuaO/cCWCeEGQxOz frSnvfaNCg00HSL55TdkU2unBg2c+JnUSm+ZdQL9G6am34jdLkwwwczrzNSYbwyCFO uqCPBe+wgvame44iEEcvXB6GWVxcrUfQbkz8fn2saf0UfeSbEmcT1OB3ghnKMzZf2e E6UdGxS1+cPpg== Received: by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1lwLG6-003jrq-MI; Thu, 24 Jun 2021 11:02:50 +0200 From: Mauro Carvalho Chehab To: Greg Kroah-Hartman Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH RESEND v6 1/8] staging: phy-hi3670-usb3: do a some minor cleanups Date: Thu, 24 Jun 2021 11:01:05 +0200 Message-Id: <55db419e42fd3af72494acbe0ea0f0d1de8906ac.1624525118.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab Before moving this driver out of staging: 1. group some integers altogether; 2. Use: return some_function() instead of: ret = some_function(); return ret; This is just a cleanup. No functional changes. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/phy-hi3670-usb3.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/staging/hikey9xx/phy-hi3670-usb3.c b/drivers/staging/hikey9xx/phy-hi3670-usb3.c index e7e579ce0302..b9ffe08abaab 100644 --- a/drivers/staging/hikey9xx/phy-hi3670-usb3.c +++ b/drivers/staging/hikey9xx/phy-hi3670-usb3.c @@ -148,10 +148,8 @@ static int hi3670_phy_cr_clk(struct regmap *usb31misc) return ret; /* Clock down */ - ret = regmap_update_bits(usb31misc, USB_MISC_CFG54, - CFG54_USB31PHY_CR_CLK, 0); - - return ret; + return regmap_update_bits(usb31misc, USB_MISC_CFG54, + CFG54_USB31PHY_CR_CLK, 0); } static int hi3670_phy_cr_set_sel(struct regmap *usb31misc) @@ -215,17 +213,14 @@ static int hi3670_phy_cr_set_addr(struct regmap *usb31misc, u32 addr) return ret; reg = FIELD_PREP(CFG54_USB31PHY_CR_ADDR_MASK, addr); - ret = regmap_update_bits(usb31misc, USB_MISC_CFG54, - CFG54_USB31PHY_CR_ADDR_MASK, reg); - return ret; + return regmap_update_bits(usb31misc, USB_MISC_CFG54, + CFG54_USB31PHY_CR_ADDR_MASK, reg); } static int hi3670_phy_cr_read(struct regmap *usb31misc, u32 addr, u32 *val) { - int reg; - int i; - int ret; + int reg, i, ret; for (i = 0; i < 100; i++) { ret = hi3670_phy_cr_clk(usb31misc); @@ -286,9 +281,7 @@ static int hi3670_phy_cr_write(struct regmap *usb31misc, u32 addr, u32 val) if (ret) return ret; - ret = hi3670_phy_cr_wait_ack(usb31misc); - - return ret; + return hi3670_phy_cr_wait_ack(usb31misc); } static int hi3670_phy_set_params(struct hi3670_priv *priv) -- 2.31.1