linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Fabio Aiuto <fabioaiuto83@gmail.com>, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/17] staging: rtl8723bs: remove all 5Ghz network types
Date: Tue, 22 Jun 2021 14:41:36 +0200	[thread overview]
Message-ID: <5af94a0d-af54-818f-d2ae-62f099db3dea@redhat.com> (raw)
In-Reply-To: <56ec67b9-a4a3-48ec-efe0-493ddc30365d@redhat.com>

Hi,

On 6/22/21 2:41 PM, Hans de Goede wrote:
> Hi,
> 
> On 6/22/21 2:29 PM, Fabio Aiuto wrote:
>> remove all 5Ghz network types. rtl8723bs works on
>> 802.11bgn standards and on 2.4Ghz band.
>>
>> So remove all code related to 802.11a and 802.11ac
>> standards, which the device doesn't support.
>>
>> Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
>> ---
>>  drivers/staging/rtl8723bs/core/rtw_ap.c       | 10 +---
>>  .../staging/rtl8723bs/core/rtw_ieee80211.c    | 22 ++------
>>  drivers/staging/rtl8723bs/core/rtw_mlme.c     | 10 ----
>>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 55 -------------------
>>  .../staging/rtl8723bs/core/rtw_wlan_util.c    | 14 +----
>>  drivers/staging/rtl8723bs/hal/odm.c           | 30 ----------
>>  drivers/staging/rtl8723bs/hal/odm.h           |  3 -
>>  .../rtl8723bs/hal/odm_EdcaTurboCheck.c        |  4 +-
>>  drivers/staging/rtl8723bs/hal/sdio_halinit.c  |  5 --
>>  drivers/staging/rtl8723bs/include/hal_phy.h   |  3 -
>>  drivers/staging/rtl8723bs/include/ieee80211.h | 22 +-------
>>  drivers/staging/rtl8723bs/include/wifi.h      |  1 -
>>  drivers/staging/rtl8723bs/os_dep/os_intfs.c   |  2 +-
>>  13 files changed, 14 insertions(+), 167 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
>> index 23bbdf084631..b0abadd4b4dd 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
>> @@ -343,10 +343,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
>>  
>>  	if (pcur_network->Configuration.DSConfig > 14) {
>>  		if (tx_ra_bitmap & 0xffff000)
>> -			sta_band |= WIRELESS_11_5N;
>> -
>> -		if (tx_ra_bitmap & 0xff0)
>> -			sta_band |= WIRELESS_11A;
>> +			sta_band |= WIRELESS_INVALID;
> 
> sta_band will now not be touched if tx_ra_bitmap is say 0x20, where as
> before it would be ore-d with WIRELESS_11A. Please make the or-ing with
> WIRELESS_INVALID unconditional (removing both "if (tx_ra_bitmap & 0x...)"
> checks). Also make sure to reduce the indentation level of the
> sta_band |= WIRELESS_INVALID; by 1 tab when dropping the if.

p.s.

The rest of the set looks ok to me.

Regards,

Hans


  reply	other threads:[~2021-06-22 12:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 12:29 [PATCH v2 00/17] staging: rtl8723bs: remove 5Ghz code Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 01/17] staging: rtl8723bs: remove all 5Ghz network types Fabio Aiuto
2021-06-22 12:41   ` Hans de Goede
2021-06-22 12:41     ` Hans de Goede [this message]
2021-06-22 12:59     ` Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 02/17] staging: rtl8723bs: remove code related to unsupported channel bandwidth Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 03/17] staging: rtl8723bs: remove unused enum items related to channel bonding Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 04/17] staging: rtl8723bs: rename " Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 05/17] staging: rtl8723bs: remove 5Ghz field in struct registry_priv Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 06/17] staging: rtl8723bs: remove struct rt_channel_plan_5g Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 07/17] staging: rtl8723bs: remove all branchings between 2.4Ghz and 5Ghz band types Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 08/17] staging: rtl8723bs: beautify prototypes in include/hal_com_phycfg.h Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 09/17] staging: rtl8723bs: remove 5Ghz code related to channel plan definition Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 10/17] staging: rtl8723bs: remove some unused 5Ghz macro definitions Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 11/17] staging: rtl8723bs: remove 5Ghz code related to RF power calibration Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 12/17] staging: rtl8723bs: remove VHT dead code Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 13/17] staging: rtl8723bs: remove unused ODM_CMNINFO_BOARD_TYPE enum item Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 14/17] staging: rtl8723bs: fix macro value for 2.4Ghz only device Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 15/17] staging: rtl8723bs: remove obsolete 5Ghz comments Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 16/17] staging: rtl8723bs: fix check allowing 5Ghz settings Fabio Aiuto
2021-06-22 12:29 ` [PATCH v2 17/17] staging: rtl8723bs: remove item from TODO list Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5af94a0d-af54-818f-d2ae-62f099db3dea@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).