linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH 3/3] staging: rtl8192e: spaces preferred around that '<<' (ctx:VxV)
@ 2022-09-19 14:16 Aruna Hewapathirane
  2022-09-19 18:51 ` Philipp Hortmann
  0 siblings, 1 reply; 2+ messages in thread
From: Aruna Hewapathirane @ 2022-09-19 14:16 UTC (permalink / raw)
  To: gregkh
  Cc: f3sch.git, guozihua, linux-staging, aruna.hewapathirane, linux-kernel

This patch fixes 2 checkpatch CHECK issues

Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
---
 drivers/staging/rtl8192e/rtllib_tx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
index f651947f6b44..933f347fc17e 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -818,10 +818,10 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
 					 cpu_to_le16(rtllib_query_seqnum(ieee, skb_frag,
 							     header.addr1));
 				frag_hdr->seq_ctl =
-					 cpu_to_le16(le16_to_cpu(frag_hdr->seq_ctl)<<4 | i);
+					 cpu_to_le16(le16_to_cpu(frag_hdr->seq_ctl) << 4 | i);
 			} else {
 				frag_hdr->seq_ctl =
-					 cpu_to_le16(ieee->seq_ctrl[0]<<4 | i);
+					 cpu_to_le16(ieee->seq_ctrl[0] << 4 | i);
 			}
 			/* Put a SNAP header on the first fragment */
 			if (i == 0) {
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/3] staging: rtl8192e: spaces preferred around that '<<' (ctx:VxV)
  2022-09-19 14:16 [PATCH 3/3] staging: rtl8192e: spaces preferred around that '<<' (ctx:VxV) Aruna Hewapathirane
@ 2022-09-19 18:51 ` Philipp Hortmann
  0 siblings, 0 replies; 2+ messages in thread
From: Philipp Hortmann @ 2022-09-19 18:51 UTC (permalink / raw)
  To: Aruna Hewapathirane, gregkh
  Cc: f3sch.git, guozihua, linux-staging, linux-kernel

On 9/19/22 16:16, Aruna Hewapathirane wrote:
> This patch fixes 2 checkpatch CHECK issues
> 
> Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
> ---
>   drivers/staging/rtl8192e/rtllib_tx.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> index f651947f6b44..933f347fc17e 100644
> --- a/drivers/staging/rtl8192e/rtllib_tx.c
> +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> @@ -818,10 +818,10 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
>   					 cpu_to_le16(rtllib_query_seqnum(ieee, skb_frag,
>   							     header.addr1));
>   				frag_hdr->seq_ctl =
> -					 cpu_to_le16(le16_to_cpu(frag_hdr->seq_ctl)<<4 | i);
> +					 cpu_to_le16(le16_to_cpu(frag_hdr->seq_ctl) << 4 | i);
>   			} else {
>   				frag_hdr->seq_ctl =
> -					 cpu_to_le16(ieee->seq_ctrl[0]<<4 | i);
> +					 cpu_to_le16(ieee->seq_ctrl[0] << 4 | i);
>   			}
>   			/* Put a SNAP header on the first fragment */
>   			if (i == 0) {


Please remove the 3/3
add a V2 and a change history



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-19 18:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 14:16 [PATCH 3/3] staging: rtl8192e: spaces preferred around that '<<' (ctx:VxV) Aruna Hewapathirane
2022-09-19 18:51 ` Philipp Hortmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).