From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D443472 for ; Tue, 15 Jun 2021 12:11:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623759117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=catMU2sQUcY0cmzqi/0xf41u4VQHC7Rms2o/nd0B/O8=; b=BKgQaIvaEEyxC1ViL0hO2Lr1jXVDvtk1iKfad9DAhsoNZOa1iG3uiR6Xlb+IqEAG4yWuRY 8ORynIr0kuaMPhhArVTzkcJS/aT4S0XGoe7LW0RAS7GteTFmsnmkT4BpvPk3lEsag9pr6P DFWDkDY2q0PWzpCsNzIZEhz2vDCDoic= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-384-VIU8U43MOzimkYSLu5xeMw-1; Tue, 15 Jun 2021 08:11:56 -0400 X-MC-Unique: VIU8U43MOzimkYSLu5xeMw-1 Received: by mail-ed1-f72.google.com with SMTP id p24-20020aa7c8980000b0290393c37fdcb8so10906299eds.6 for ; Tue, 15 Jun 2021 05:11:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=catMU2sQUcY0cmzqi/0xf41u4VQHC7Rms2o/nd0B/O8=; b=jVTynggFYSkjxFMGCC/un36Qf/lrJQP9cx+uIphpZppcqbIeEBhSzAWIZz+kfXDv+d gIjX16TPfNGArCgUDZw+00wrFuTARhx3D05Zek/S8beJXZBk61Y1xqhwPyMGUcO7MxXa LbscU3aeBl8J19AhmZHXV1UycrB5DqAN0iiJxwIKuOJIiQsh/sszHkNhxzQFXTVAHqrt WLkbVnAbsMffIhCP6HnLfIZIdBa8KO9BXsyPphRWcHPJl/lLRI//g6rhfR0jCgpkNLxD 7qkNmVlhwO8TUSiFq7+IX7sZgBFioGq6At2IJbkRsjEqZRZNNzl0378TiuzMo4pR7gDS Z2hg== X-Gm-Message-State: AOAM533zqyca0KouR1JdGBiQ+iytlxC4TAkiBFUQIGfD2vRjeZ2pIZwA KWXEjPvRed2yFVZ8n/u0W2GAt9Ul19Pg+ZwV4PsYhvlVdPRuHBBu+NDcqQpEwO3/tDZ94fAefEe pUl/MTbycqURXayPf+YbKFmxs0g== X-Received: by 2002:a05:6402:4242:: with SMTP id g2mr2385994edb.350.1623759115445; Tue, 15 Jun 2021 05:11:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0eETMZ0KtHAEY/DHOOKsuF/qv/jjzcudE4oivsL7FfV+ozmnRx6Vs5McNXSzrFhYVzjTXlg== X-Received: by 2002:a05:6402:4242:: with SMTP id g2mr2385980edb.350.1623759115291; Tue, 15 Jun 2021 05:11:55 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id cx7sm11793276edb.65.2021.06.15.05.11.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Jun 2021 05:11:27 -0700 (PDT) Subject: Re: [PATCH 0/8] staging: rtl8723bs: remove unneeded files from tree To: Fabio Aiuto , gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: From: Hans de Goede Message-ID: <8109abbd-f7ae-2b88-4b99-98151322c843@redhat.com> Date: Tue, 15 Jun 2021 14:11:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 6/15/21 1:45 PM, Fabio Aiuto wrote: > This patchset removes some unneeded files. > > autoconf.h seems to be the output of some automatic > header file generation foreign to the linux kernel > configuration and build system. > > To toggle some part of code one is asked to > force an edit by hand on this file. > > Other unneeded definitions were deleted recently, > now we complete the job. > > Removed core/rtw_eeprom.c and include/drv_conf.h as well, > for they are excluded from the build process. > > Tested-by: Fabio Aiuto Thank you, series looks good to me: Reviewed-by: Hans de Goede for the series, Regards, Hans > > Fabio Aiuto (8): > staging: rtl8723bs: remove unused debug macro > staging: rtl8723bs: remove unneeded comments > staging: rtl8723bs: remove unused WAKEUP_GPIO_IDX macro definition > staging: rtl8723bs: remove unneeded DISABLE_BB_RF macro > staging: rtl8723bs: remove HAL_{BB,MAC,RF,FW}_ENABLE macros > staging: rtl8723bs: move LPS_RPWM_WAIT_MS macro > staging: rtl8723bs: remove include/autoconf.h header file from tree > staging: rtl8723bs: remove two unused files from tree > > drivers/staging/rtl8723bs/core/rtw_eeprom.c | 208 ------------------ > .../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 7 - > .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 16 -- > drivers/staging/rtl8723bs/hal/sdio_halinit.c | 15 -- > drivers/staging/rtl8723bs/include/autoconf.h | 50 ----- > drivers/staging/rtl8723bs/include/drv_conf.h | 19 -- > drivers/staging/rtl8723bs/include/drv_types.h | 1 - > .../staging/rtl8723bs/include/hal_btcoex.h | 2 + > drivers/staging/rtl8723bs/include/hal_phy.h | 14 -- > .../staging/rtl8723bs/include/rtl8723b_spec.h | 2 - > 10 files changed, 2 insertions(+), 332 deletions(-) > delete mode 100644 drivers/staging/rtl8723bs/core/rtw_eeprom.c > delete mode 100644 drivers/staging/rtl8723bs/include/autoconf.h > delete mode 100644 drivers/staging/rtl8723bs/include/drv_conf.h >