From: "libaokun (A)" <libaokun1@huawei.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: kernel test robot <lkp@intel.com>, <mchehab@kernel.org>,
<sakari.ailus@linux.intel.com>, <gregkh@linuxfoundation.org>,
<kaixuxia@tencent.com>, <gustavoars@kernel.org>,
<linux-media@vger.kernel.org>, <linux-staging@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, <kbuild-all@lists.01.org>,
<weiyongjun1@huawei.com>
Subject: Re: [PATCH -next v3] media: staging: atomisp: use list_splice_init in atomisp_compat_css20.c
Date: Thu, 17 Jun 2021 20:53:46 +0800 [thread overview]
Message-ID: <9595aed0-99b1-ed5c-3f89-fa69dba41cf0@huawei.com> (raw)
In-Reply-To: <YMtC/CmZeni2dD1W@smile.fi.intel.com>
Thank you for your advice.
I'll follow your advice strictly.
Best Regards.
在 2021/6/17 20:41, Andy Shevchenko 写道:
> On Thu, Jun 17, 2021 at 08:14:28PM +0800, libaokun (A) wrote:
>> Sorry, I only tested it with 'x86_64.config'.
>>
>> I'm about to send a patch v4 with the changes to fix the error under your
>> config.
> Please, do not top-post!
>
>
> Problem here that you tested without additional warnings enabled.
>
> Next time try to start with `make W=1 ...`
>
> If you have installed Sparse tool, the better option would be
> `make W=1 C=1 CF=-D__CHECK_ENDIAN__ ...`
>
>> 在 2021/6/17 16:52, kernel test robot 写道:
>>> Hi Baokun,
>>>
>>> Thank you for the patch! Yet something to improve:
>>>
>>> [auto build test ERROR on next-20210616]
>>>
>>> url: https://github.com/0day-ci/linux/commits/Baokun-Li/media-staging-atomisp-use-list_splice_init-in-atomisp_compat_css20-c/20210617-043443
>>> base: c7d4c1fd91ab4a6d2620497921a9c6bf54650ab8
>>> config: i386-allyesconfig (attached as .config)
>>> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>>> reproduce (this is a W=1 build):
>>> # https://github.com/0day-ci/linux/commit/05c714d7b4e1722a75f949e40c5305f3ba28d048
>>> git remote add linux-review https://github.com/0day-ci/linux
>>> git fetch --no-tags linux-review Baokun-Li/media-staging-atomisp-use-list_splice_init-in-atomisp_compat_css20-c/20210617-043443
>>> git checkout 05c714d7b4e1722a75f949e40c5305f3ba28d048
>>> # save the attached .config to linux build tree
>>> make W=1 ARCH=i386
>>>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c: In function 'atomisp_css_stop':
>>>>> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2156:50: error: 'struct atomisp_sub_device' has no member named 'asd'
>>> 2156 | list_splice_init(&asd->metadata_in_css[i], &asd->asd->metadata[i]);
>>> | ^~
>>> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2157:49: error: 'struct atomisp_sub_device' has no member named 'asd'
>>> 2157 | list_splice_init(&asd->metadata_ready[i], &asd->asd->metadata[i]);
>>> | ^~
>>> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2107:31: warning: unused variable 'md_buf' [-Wunused-variable]
>>> 2107 | struct atomisp_metadata_buf *md_buf;
>>> | ^~~~~~
>>> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2106:26: warning: unused variable 'dis_buf' [-Wunused-variable]
>>> 2106 | struct atomisp_dis_buf *dis_buf;
>>> | ^~~~~~~
prev parent reply other threads:[~2021-06-17 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 8:10 [PATCH -next v3] media: staging: atomisp: use list_splice_init in atomisp_compat_css20.c Baokun Li
2021-06-11 9:59 ` Andy Shevchenko
2021-06-17 8:52 ` kernel test robot
2021-06-17 12:14 ` libaokun (A)
2021-06-17 12:41 ` Andy Shevchenko
2021-06-17 12:53 ` libaokun (A) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9595aed0-99b1-ed5c-3f89-fa69dba41cf0@huawei.com \
--to=libaokun1@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=kaixuxia@tencent.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lkp@intel.com \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).