linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Nam Cao <namcaov@gmail.com>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: forest@alittletooquiet.net, gregkh@linuxfoundation.org,
	 linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: vt6655: replace spin_lock_irqsave with spin_lock
Date: Thu, 15 Sep 2022 19:10:08 +0200	[thread overview]
Message-ID: <CA+sZ8B__mUdYxCBqzD4TGAKKcaa1FtLsrJCQD=b9aYBKJhZUTA@mail.gmail.com> (raw)
In-Reply-To: <1a1d346e-be81-19a5-5cb7-8b5ac896d835@gmail.com>

On Wed, Sep 14, 2022 at 8:55 PM Philipp Hortmann
<philipp.g.hortmann@gmail.com> wrote:
>
> On 9/14/22 10:00, Nam Cao wrote:
> > In vt6655 driver, there is a single interrupt handler: vnt_interrupt(),
> > and it does not take the spinlock. The interrupt handler only schedules
> > a workqueue, and the spinlock is taken in this workqueue. Thus, there is
> > no need to use spin_lock_irqsave, as the spinlock is never taken by an
> > interrupt. Replace spin_lock_irqsave (and spin_unlock_irqsave) with
> > spin_lock (and spin_unlock).
> >
> > Signed-off-by: Nam Cao <namcaov@gmail.com>
>
> Hi Nam,
>
> I am lol ... my computer freezed (you don mind if I do not try this
> patch again? Please send a v2) ;-)
> I was digging for the log see below. (kern.log)
> I hope you can do something with it.

Thank you so much for testing the patch and providing the log. I think my patch
introduces deadlock, which caused your computer to freeze. My bad, sorry about
that. I may send v2 in the future, when I fully understand what is going on.

Best regards,
Nam

  reply	other threads:[~2022-09-15 17:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14  8:00 [PATCH] staging: vt6655: replace spin_lock_irqsave with spin_lock Nam Cao
2022-09-14 18:55 ` Philipp Hortmann
2022-09-15 17:10   ` Nam Cao [this message]
2022-09-15  8:45 ` Greg KH
2022-09-15 17:14   ` Nam Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+sZ8B__mUdYxCBqzD4TGAKKcaa1FtLsrJCQD=b9aYBKJhZUTA@mail.gmail.com' \
    --to=namcaov@gmail.com \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).