From: Phillip Potter <phil@philpotter.co.uk>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Dan Carpenter <dan.carpenter@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-staging@lists.linux.dev,
Fabio Aiuto <fabioaiuto83@gmail.com>,
Martin Kaiser <martin@kaiser.cx>
Subject: Re: [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver
Date: Wed, 28 Jul 2021 23:17:04 +0100 [thread overview]
Message-ID: <CAA=Fs0=bQt8Msaw_CjgjAsmQFjm6U3bag76K9uKHVfMPaehtvg@mail.gmail.com> (raw)
In-Reply-To: <YQGoLPnL8s2buxFe@kroah.com>
On Wed, 28 Jul 2021 at 19:55, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Jul 28, 2021 at 01:41:15PM -0500, Larry Finger wrote:
> > On 7/28/21 1:14 PM, Greg KH wrote:
> > > Hm, I thought this would be in better shape than it is.
> > >
> > > Right now we have 107 .c and .h files in drivers/staging/rtl8188eu/ that
> > > come to a total of 44597 lines.
> > >
> > > So we are taking double the size here?
> > >
> > > I'm all for putting a "better" driver in here, but this feels odd to
> > > me... Is there major new functionality here that is not in the existing
> > > driver to justify this?
> > >
> > > Ok, let's see how this goes, I'll give it a few weeks to see how much
> > > can easily be fixed up to hopefully get back to at least close the
> > > existing driver size...
> >
> > The major new functionality is that the new one uses cfg80211, whereas the
> > old one uses the WEXT calls.
>
> Ok, that's worth it alone.
>
> > It really is an improvement. It just needs a severe cleanup.
> >
> > I warned you that this code was rough. It took me several weeks to get the
> > old one "ready" for staging. I never devoted that effort to the new one, and
> > you wanted it in a place where multiple authors could improve it.
>
> Fair enough, I did ask for it :)
>
> I'll go through and do a license cleanup tomorrow morning to start with,
> that should knock a bunch of lines off right away...
>
> thanks,
>
> greg k-h
Just stripping the debug code out of this version again will free up
quite a few lines I think as well :-) Will get started on that.
Regards,
Phil
prev parent reply other threads:[~2021-07-28 22:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 23:22 [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver Phillip Potter
2021-07-27 23:22 ` [PATCH v4 1/6] staging: r8188eu: introduce new core dir for " Phillip Potter
2021-07-27 23:22 ` [PATCH v4 2/6] staging: r8188eu: introduce new hal " Phillip Potter
2021-07-27 23:22 ` [PATCH v4 3/6] staging: r8188eu: introduce new os_dep " Phillip Potter
2021-07-27 23:22 ` [PATCH v4 4/6] staging: r8188eu: introduce new include " Phillip Potter
2021-07-27 23:22 ` [PATCH v4 5/6] staging: r8188eu: introduce new supporting files " Phillip Potter
2021-07-27 23:22 ` [PATCH v4 6/6] staging: r8188eu: attach newly imported driver to build system Phillip Potter
2021-07-28 7:46 ` [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver Martin Kaiser
2021-07-28 16:00 ` Phillip Potter
2021-07-29 13:37 ` Martin Kaiser
2021-07-29 14:00 ` Greg KH
2021-07-29 16:47 ` Larry Finger
2021-08-01 17:50 ` Martin Kaiser
2021-07-28 18:14 ` Greg KH
2021-07-28 18:41 ` Larry Finger
2021-07-28 18:55 ` Greg KH
2021-07-28 22:17 ` Phillip Potter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA=Fs0=bQt8Msaw_CjgjAsmQFjm6U3bag76K9uKHVfMPaehtvg@mail.gmail.com' \
--to=phil@philpotter.co.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).