From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA5072FB2 for ; Tue, 15 Jun 2021 08:41:56 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 579B361413 for ; Tue, 15 Jun 2021 08:41:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623746516; bh=DOqkVmnBr80KyQKj5AB82+ytMFP18EFZJKipaflcsy0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Ka8rw4ixk0Wloh4el+pbnwNGpFhUGQ4CoZGE35yxnEcDn3sLFq3O9RVry4JkUc3sL bmYQlwsKwK2eIOJGGQpGOgRPKYQfxvuSvMPfiQ+H/O2Ai5dbFhzSiFUeGtZcOF3oO6 jfTSuQsCSgvn4brhCxNnbB2du6lGvUWyQJEkfUxTUMaEZWegX2Gzp9ZbSjI+kmlGOk aOFSGuEsdUd02va9aAy2F3BgpIs615TGqZfM6JN896vxt7dD5q4OdgSoGbCX/9ytKn 7ArzznK9rT8Ii6qZfb4zy/H3YF1LFXuqublKdEOUk1zZGFBOMwtRXgfNhJ/uExUZDL PoepvUPRFUwCQ== Received: by mail-wm1-f43.google.com with SMTP id c84so884730wme.5 for ; Tue, 15 Jun 2021 01:41:56 -0700 (PDT) X-Gm-Message-State: AOAM533Ky1vHDQREFEftgHk4lB3MNO8iJl0URS/5iuMCbzdEgB2TTS5f YtW4WopOGygnaJ5HNjBCpXG7Lsx9CbT8igWbxU0= X-Google-Smtp-Source: ABdhPJxaQoNcNsZ00Pqi6S1MjwkYI6mlR4YjuOa9Sfkn6PYpJUxlyeUCejATypHdd5AYLoYMq78YjYfGyYxcHZdkwQM= X-Received: by 2002:a1c:c90f:: with SMTP id f15mr3915283wmb.142.1623746514904; Tue, 15 Jun 2021 01:41:54 -0700 (PDT) X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210614103409.3154127-1-arnd@kernel.org> <20210614103409.3154127-8-arnd@kernel.org> <2d988daa-cb25-9f0d-8309-99f4de2a1e58@xs4all.nl> In-Reply-To: <2d988daa-cb25-9f0d-8309-99f4de2a1e58@xs4all.nl> From: Arnd Bergmann Date: Tue, 15 Jun 2021 10:39:50 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 7/8] media: subdev: fix compat_ioctl32 To: Hans Verkuil Cc: Laurent Pinchart , Mauro Carvalho Chehab , "Lad, Prabhakar" , Eduardo Valentin , Sakari Ailus , Greg Kroah-Hartman , Vaibhav Gupta , Liu Shixin , Jacopo Mondi , Andy Shevchenko , Linux Kernel Mailing List , Linux Media Mailing List , linux-staging@lists.linux.dev Content-Type: text/plain; charset="UTF-8" On Tue, Jun 15, 2021 at 10:27 AM Hans Verkuil wrote: > On 14/06/2021 19:18, Laurent Pinchart wrote: > > > > Should we drop v4l2_subdev_core_ops.compat_ioctl32 and call > > v4l2_subdev_core_ops.ioctl from subdev_do_compat_ioctl32() ? New drivers > > should design custom ioctls in a way that doesn't require compat code. > > I agree, we can drop it completely. I agree about new drivers defining their ioctls in a compatible way, though Ideally I'd say subdev drivers should not use custom ioctls at all. There are two other drivers that define private subdev ioctls and that lack a working compat handler: - the omap3 isp driver would not work in compat mode, though I don't think there are any 64-bit SoCs using this hardware. The Sitara AM6 and J72 SoCs are the only chips in that family at the moment, but these don't seem to include any image processor. - The Intel Atom ISP driver has a broken compat ioctl handler that I remove in this series, but the v4l2_subdev_core_ops->compat_ioctl32 callback would be the correct place to hook these up if they do not get fixed. > I'll skip this patch, but I'll take the other 7 patches and make a v3 PR with > updated Reviewed-by tags from Laurent. Thanks! Arnd