From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D97170 for ; Wed, 2 Jun 2021 14:28:12 +0000 (UTC) Received: by mail-oo1-f49.google.com with SMTP id v13-20020a4aa40d0000b02902052145a469so590999ool.3 for ; Wed, 02 Jun 2021 07:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=why64ASda6N09T/+Pwk+bfH6/nnxuW96QOGPqoMB+sM=; b=himWBiHE+VwxlklDa6IC/8V2dgK5fHFbNVESgDjbuQkANYRI9k0+hKXBLAbaEuxicz uLcOW2dY/k9sQjzclIR4InK9NJ5+38dQ7yEmw8F1vjSSqslzVNKFvxaKTKOQnN0H/Kia 9vsvC27W49445LgbTn18qjoyk4NjDGgjL35SFVLmDfm/6yfBSlpYGRlmX6WOeXQuXvn4 UN4ylBkDbb2vP150ZIvMXmqauG8i2nmtTWt3ca36LLMbOI3CyBUC2nUomEVwRjU5txfL Agc1Cpgxcbv97HUroQY6VKa8FGmEq501uN4IXGhu9IaniGyLy4JH0QSuDfK4196sAcd0 TebQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=why64ASda6N09T/+Pwk+bfH6/nnxuW96QOGPqoMB+sM=; b=CfGuC8p/BzafONm74dsV8k3rs0I+tZPkmlMcyrqpj80Xo/8Ss+yfRQZKkyG9CitdQq AV3pPBVjVkY50r21IQgdOYXKVGg7Q00uvO/ayawhfEN2INUDbGpwWaSI7Yq0woe089o5 5ojDXCMJHl0/BU23HwXuepxaZX+yciUn0la2PHtIMAgA+SenpSzc9uYH0Fj5gkr6F6L1 izLJq43dOchbxNkgZm0XNbqby1GXAVWoVIZoME4V7DH6cIWtxEnvKMzWzb2z0T7kXSXi eIj7DDb/tReJPpawmnuAP3WdatYDzzHeAXtrveQv7OkEja+CuJ/niTM24pzbUgDD0RKm ISiA== X-Gm-Message-State: AOAM532U7ayKaTA3N/DH6yEvVxXfmim/KBBJQVgFEEC4NdQtPo5Vd0/w M9LFg3p+crllhWj8aVj+qJ30BNxIDJJEJuvAu5o= X-Google-Smtp-Source: ABdhPJxepnMcyOj6FxxdtG9fSGVa2ciFY7Sih7dFE8PhB6aUFACp+QiahnamVGV7J9Q0DPtOO/4MWYKTn6cIfZqLdBs= X-Received: by 2002:a4a:e084:: with SMTP id w4mr24438208oos.59.1622644091377; Wed, 02 Jun 2021 07:28:11 -0700 (PDT) X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210602133659.46158-1-manikishanghantasala@gmail.com> <9a3878fd-3b59-76f5-ddc7-625c66f9fee8@ieee.org> In-Reply-To: <9a3878fd-3b59-76f5-ddc7-625c66f9fee8@ieee.org> From: Manikishan Ghantasala Date: Wed, 2 Jun 2021 19:57:35 +0530 Message-ID: Subject: Re: [PATCH] staging: greybus: fixed the coding style, labels should not be indented. To: Alex Elder Cc: Rui Miguel Silva , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sending this mail again as I missed to reply to all. Hi Alex, I agree those are called bit-field member names rather than labels. But the reason I mentioned is because the ./scripts/checkpatch.pl gave out a warning saying "labels should not be indented". Sorry for the confusion in the name I referred to. So, I think this change is needed as I feel this is not following the coding-style by having indent before the width for bit field member. I went through other places in source code to make sure this is correct, and sent the patch after confirmation. Regards, Manikishan Ghantasala On Wed, 2 Jun 2021 at 19:13, Alex Elder wrote: > > On 6/2/21 8:36 AM, sh4nnu wrote: > > From: Manikishan Ghantasala > > > > staging: greybus: gpio.c: Clear coding-style problem > > "labels should not be indented" by removing indentation. > > These are not labels. > > I don't really understand what you're doing here. > > Can you please explain why you think this needs changing? > > -Alex > > > Signed-off-by: Manikishan Ghantasala > > --- > > drivers/staging/greybus/gpio.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c > > index 7e6347fe93f9..4661f4a251bd 100644 > > --- a/drivers/staging/greybus/gpio.c > > +++ b/drivers/staging/greybus/gpio.c > > @@ -20,9 +20,9 @@ > > struct gb_gpio_line { > > /* The following has to be an array of line_max entries */ > > /* --> make them just a flags field */ > > - u8 active: 1, > > - direction: 1, /* 0 = output, 1 = input */ > > - value: 1; /* 0 = low, 1 = high */ > > + u8 active:1, > > + direction:1, /* 0 = output, 1 = input */ > > + value:1; /* 0 = low, 1 = high */ > > u16 debounce_usec; > > > > u8 irq_type; > > >