From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 558E56D00 for ; Tue, 15 Jun 2021 12:38:14 +0000 (UTC) Received: by mail-ot1-f54.google.com with SMTP id 6-20020a9d07860000b02903e83bf8f8fcso14079646oto.12 for ; Tue, 15 Jun 2021 05:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ficQ6Tww5rQWbuZhPE3EU+jqogC/DlraVO6vAn62sH8=; b=Lp+48USM5gnu+eeiY9Ryndm4K5fG/VsCibPh6LcsrDucCKozYimMQbl3c5s+M9nTd2 kWSmLb1v/6huguWcIj5VMtNX8v8JJ3iEFARDXK3PZcl0yhm4u8om8kGk9jl2uHnjvCqc T1ZVitgGHX3+mzf1uc5QBYfeBS1gEfgQdebwp6YZos97rmVDouzW2Eo4Df+Teos8bytb h3l3fzGY0JAm+muk3HTuDiEmkPUiX/s/1c9WE/HreoqIlVEFbftB4UEICL+CGx5P5/mt EmWgnENkf3qQ03D6T0tBhGTEZcJLbm94Z9GBugQeNIn86VAeehW9NMChjaNfoR5cOp3y fNWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ficQ6Tww5rQWbuZhPE3EU+jqogC/DlraVO6vAn62sH8=; b=IDq1FpOMWMuD8+xg7MSKTrBf4vY1gol8n987L6npEMrKUa8Y2qSyEahxihZE7KPsn7 YXn7UcFGKMgy+3VbFN4chcX5gP/zSFJmeJboqxR+1lEIy27sVxGKZol3s93Esz3GBLAG VbfRV3Yq+grk8JssUd70j0LfAx4obEwaDzOqANOXBE4NOzpKhFiWzHHCMDrEI6ZqsdYe Vbl9iHsZBWhWWYo1a7TJJcWnHuEE/U/7WZOWcJ1yO8iXzH8W79tHXqFfhqh/VilezbSk nEfQ1xZDeRQGhQUhjgkhfeJIeEsxh/RRYPp7+3uSpv51x9b4FHTN7vMvZATikqtnIHwO YNRA== X-Gm-Message-State: AOAM531QyaZaDdoZ71uFMNE4VAZiOyX/Lu7mPnCt6tfcq7tgtGJjArmH CJGl4KNzrn/UWjRNHf5WTI65mOjwrwKqxO+ZStk= X-Google-Smtp-Source: ABdhPJw0GeGfibEnccUzSpoNh5NwbGf8dGBP93VtfjUh74h4iIR91O5ulOPCrMrUMeeckCmb0NxMwdAgQVTm490yoMU= X-Received: by 2002:a05:6830:99:: with SMTP id a25mr17941206oto.72.1623760693573; Tue, 15 Jun 2021 05:38:13 -0700 (PDT) X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210614100617.28753-1-sergio.paracuellos@gmail.com> <20210614100617.28753-2-sergio.paracuellos@gmail.com> In-Reply-To: From: Sergio Paracuellos Date: Tue, 15 Jun 2021 14:38:02 +0200 Message-ID: Subject: Re: [PATCH v2 1/3] MIPS: ralink: Define PCI_IOBASE To: Greg KH Cc: linux-staging@lists.linux.dev, NeilBrown , "open list:MIPS" , Thomas Bogendoerfer , Ilya Lipnitskiy , John Crispin Content-Type: text/plain; charset="UTF-8" On Tue, Jun 15, 2021 at 1:51 PM Greg KH wrote: > > On Mon, Jun 14, 2021 at 12:06:15PM +0200, Sergio Paracuellos wrote: > > PCI_IOBASE is used to create VM maps for PCI I/O ports, it is > > required by generic PCI drivers to make memory mapped I/O range > > work. Hence define it for ralink architectures to be able to > > avoid parsing manually IO ranges in PCI generic driver code. > > Function 'plat_mem_setup' for ralink is using 'set_io_port_base' > > call using '0xa0000000' as address, so use the same address in > > the definition to align things. > > > > Signed-off-by: Sergio Paracuellos > > --- > > arch/mips/include/asm/mach-ralink/spaces.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > create mode 100644 arch/mips/include/asm/mach-ralink/spaces.h > > > > diff --git a/arch/mips/include/asm/mach-ralink/spaces.h b/arch/mips/include/asm/mach-ralink/spaces.h > > new file mode 100644 > > index 000000000000..87d085c9ad61 > > --- /dev/null > > +++ b/arch/mips/include/asm/mach-ralink/spaces.h > > @@ -0,0 +1,10 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef __ASM_MACH_RALINK_SPACES_H_ > > +#define __ASM_MACH_RALINK_SPACES_H_ > > + > > +#define PCI_IOBASE _AC(0xa0000000, UL) > > +#define PCI_IOSIZE SZ_16M > > +#define IO_SPACE_LIMIT (PCI_IOSIZE - 1) > > + > > +#include > > +#endif > > -- > > 2.25.1 > > > > > > I really can't take a change outside of drivers/staging/ for a staging > driver. > > So unless you can get a MIPS maintainer to ACK this, I can't accept > this change, sorry. I know, I was expecting Thomas to ACK this, if it is ok. Thomas, what do you think about this? Best regards, Sergio Paracuellos > > greg k-h