From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-staging@lists.linux.dev,
Greg KH <gregkh@linuxfoundation.org>,
NeilBrown <neil@brown.name>
Subject: Re: [PATCH 5/5] staging: mt7621-pci: parse some dt properties from root port child nodes
Date: Mon, 7 Jun 2021 09:11:13 +0200 [thread overview]
Message-ID: <CAMhs-H9MC7weYpkdZy_eNw01-tc+6DU58tciQt7J8BtSqazGxw@mail.gmail.com> (raw)
In-Reply-To: <20210607065934.GM1955@kadam>
Hi Dan,
On Mon, Jun 7, 2021 at 8:59 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Sat, Jun 05, 2021 at 09:30:23AM +0200, Sergio Paracuellos wrote:
> > Properties 'clocks', 'resets' and 'phys' have been moved from parent
> > node to the root port childs. Hence we have to adapt the way device
> > tree is parsed in driver code to properly align things and make all
> > the stuff work.
> >
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
>
> It sounds like this commit needs a fixes tag? What does "to properly
> align things and make all the stuff work." in terms of what the user
> sees?
I submitted this driver to get mainlined and when bindings have been
reviewed I've been told to move this stuff into child nodes. Until now
all was also being properly working but with these properties defined
in the parent node. So I don't think any Fixes tag is needed here. So
hopefully changes on this patchset are the last need to get this
properly mainlined. I've been told to just make a 'git mv' without
zero changes from the staging driver, that's why I am submitting
changes to staging before.
>
> regards,
> dan carpenter
Best regards,
Sergio Paracuellos
>
next prev parent reply other threads:[~2021-06-07 7:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 7:30 [PATCH 0/5] staging: mt7621-pci: some required changes after first review Sergio Paracuellos
2021-06-05 7:30 ` [PATCH 1/5] staging: mt7621-pci: make cleaner 'mt7621_pcie_enable_ports' Sergio Paracuellos
2021-06-05 7:30 ` [PATCH 2/5] staging: mt7621-pci: remove 'RALINK_PCI_BAR0SETUP_ADDR' definition Sergio Paracuellos
2021-06-05 7:30 ` [PATCH 3/5] staging: mt7621-pci: use {readl|writel}_relaxed instead of readl/writel Sergio Paracuellos
2021-06-05 7:30 ` [PATCH 4/5] staging: mt7621-dts: move some properties into root port child nodes Sergio Paracuellos
2021-06-05 7:30 ` [PATCH 5/5] staging: mt7621-pci: parse some dt properties from " Sergio Paracuellos
2021-06-07 6:59 ` Dan Carpenter
2021-06-07 7:11 ` Sergio Paracuellos [this message]
2021-06-07 10:37 ` Dan Carpenter
2021-06-07 11:10 ` Sergio Paracuellos
2021-06-07 11:30 ` Sergio Paracuellos
2021-06-07 12:05 ` Dan Carpenter
2021-06-07 12:09 ` Sergio Paracuellos
2021-06-07 13:20 ` Dan Carpenter
2021-06-07 14:17 ` Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMhs-H9MC7weYpkdZy_eNw01-tc+6DU58tciQt7J8BtSqazGxw@mail.gmail.com \
--to=sergio.paracuellos@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=neil@brown.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).