From: Mitali Borkar <mitaliborkar810@gmail.com>
To: Joe Perches <joe@perches.com>, gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com, mitali_s@me.iitr.ac.in
Subject: Re: [PATCH v4 3/3] staging: rtl8192e: remove unnecessary parentheses
Date: Tue, 13 Apr 2021 07:33:04 +0530 [thread overview]
Message-ID: <YHT72MuY6mQ+JPGL@kali> (raw)
In-Reply-To: <d82c4f4be48b645983a7f922f1791ebf098b22c5.camel@perches.com>
On Mon, Apr 12, 2021 at 01:46:54PM -0700, Joe Perches wrote:
> On Mon, 2021-04-12 at 16:52 +0530, Mitali Borkar wrote:
> > Removed unnecessary parentheses because they must be used only when it
> > is necessary or they improve readability.
> > Reported by checkpatch.
>
> I gave you feedback about the memset changes.
> Please use it.
> https://lore.kernel.org/lkml/f5fe04d62b22eb5e09c299e769d9b9d8917f119c.camel@perches.com/
>
I am sorry Sir, I missed this. I will make required changes now.
> > Changes from v3:- No changes.
> > Changes from v2:- Rectified spelling mistake in subject description.
> > Changes has been made in v3.
> > Changes from v1:- No changes.
> []
> > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> []
> > @@ -646,13 +646,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
> > pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
> > pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
> >
> >
> > - memset((void *)(&(pHTInfo->SelfHTCap)), 0,
> > + memset((void *)(&pHTInfo->SelfHTCap), 0,
> > sizeof(pHTInfo->SelfHTCap));
>
> memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap);
>
> etc...
>
next prev parent reply other threads:[~2021-04-13 2:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 11:21 [PATCH v4 0/3] staging: rtl8192e: cleanup patchset for style issues Mitali Borkar
2021-04-12 11:21 ` [PATCH v4 1/3] staging: rtl8192e: remove parentheses around boolean expression Mitali Borkar
2021-04-12 11:21 ` [PATCH v4 2/3] staging: rtl8192e: remove unnecessary ftrace-like logging Mitali Borkar
2021-04-12 11:22 ` [PATCH v4 3/3] staging: rtl8192e: remove unnecessary parentheses Mitali Borkar
2021-04-12 20:46 ` Joe Perches
2021-04-13 2:03 ` Mitali Borkar [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-11 11:34 [PATCH v4 0/3] staging: rtl8192e: modified log message Mitali Borkar
2021-04-11 11:35 ` [PATCH v4 3/3] staging: rtl8192e: remove unnecessary parentheses Mitali Borkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHT72MuY6mQ+JPGL@kali \
--to=mitaliborkar810@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mitali_s@me.iitr.ac.in \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).