From: Mitali Borkar <mitaliborkar810@gmail.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com, mitali_s@me.iitr.ac.in
Subject: Re: [PATCH v2 3/4] staging: media: intel-ipu3: reduce length of line
Date: Tue, 13 Apr 2021 16:26:36 +0530 [thread overview]
Message-ID: <YHV45I6ZDsXNwdiG@kali> (raw)
In-Reply-To: <20210413104432.GU3@paasikivi.fi.intel.com>
On Tue, Apr 13, 2021 at 01:44:32PM +0300, Sakari Ailus wrote:
> On Tue, Apr 13, 2021 at 04:13:04PM +0530, Mitali Borkar wrote:
> > On Tue, Apr 13, 2021 at 01:01:34PM +0300, Sakari Ailus wrote:
> > > Hi Mitali,
> > >
> > > Thanks for the update.
> > >
> > > On Tue, Apr 13, 2021 at 10:46:06AM +0530, Mitali Borkar wrote:
> > > > Reduced length of the line under 80 characters to meet linux-kernel
> > > > coding style.
> > > >
> > > > Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> > > > ---
> > > >
> > > > Changes from v1:- Reduced length of the line under 80 characters
> > > >
> > > > drivers/staging/media/ipu3/include/intel-ipu3.h | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/staging/media/ipu3/include/intel-ipu3.h b/drivers/staging/media/ipu3/include/intel-ipu3.h
> > > > index 6a72c81d2b67..52dcc6cdcffc 100644
> > > > --- a/drivers/staging/media/ipu3/include/intel-ipu3.h
> > > > +++ b/drivers/staging/media/ipu3/include/intel-ipu3.h
> > > > @@ -247,7 +247,8 @@ struct ipu3_uapi_ae_ccm {
> > > > */
> > > > struct ipu3_uapi_ae_config {
> > > > struct ipu3_uapi_ae_grid_config grid_cfg __aligned(32);
> > > > - struct ipu3_uapi_ae_weight_elem weights[IPU3_UAPI_AE_WEIGHTS] __aligned(32);
> > > > + struct ipu3_uapi_ae_weight_elem weights[IPU3_UAPI_AE_WEIGHTS]
> > > > + __aligned(32);
> > >
> > > Do you still have the other two patches in your tree? This doesn't apply
> > > here due to the different attribute syntax.
> > >
> > I have patch 1/6 and 2/6 in my tree which you asked me to drop.
>
> Could you drop them and then submit v3?
>
I am extremely sorry Sir, but I am still learning to use git, drop them
means to delete those commits? Even if I delete those, this patch was
made after those, so the changes I made then will remain as it is, so
what to do now?
> Thanks.
>
> --
> Sakari Ailus
next prev parent reply other threads:[~2021-04-13 10:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 5:15 [PATCH v2 0/4] staging: media: intel-ipu3: Cleanup patchset for style issues Mitali Borkar
2021-04-13 5:15 ` [PATCH v2 1/4] staging: media: intel-ipu3: remove unnecessary blank line Mitali Borkar
2021-04-13 5:15 ` [PATCH v2 2/4] staging: media: intel-ipu3: reduce length of line Mitali Borkar
2021-04-13 5:16 ` [PATCH v2 3/4] " Mitali Borkar
2021-04-13 10:01 ` Sakari Ailus
2021-04-13 10:43 ` Mitali Borkar
2021-04-13 10:44 ` Sakari Ailus
2021-04-13 10:56 ` Mitali Borkar [this message]
2021-04-13 11:11 ` Sakari Ailus
2021-04-13 12:43 ` [Outreachy kernel] " Fabio M. De Francesco
2021-04-13 5:16 ` [PATCH v2 4/4] staging: media: intel-ipu3: remove space before tabs Mitali Borkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHV45I6ZDsXNwdiG@kali \
--to=mitaliborkar810@gmail.com \
--cc=bingbu.cao@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mitali_s@me.iitr.ac.in \
--cc=outreachy-kernel@googlegroups.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).