From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9543D72 for ; Tue, 15 Jun 2021 21:15:30 +0000 (UTC) Received: by mail-wr1-f54.google.com with SMTP id f2so114805wri.11 for ; Tue, 15 Jun 2021 14:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6hvY4p5FF5eRnjuVWtkxhk1sjqpIeEICM36lTpspsRo=; b=UNOtbmg8IykFWJLTe3LZrUM4+emn9ygP8Nv4M3/uEvjow42Pcb416HxY+4EHahSdUU tC559WSm7kLd8z6ITAzHvA1XM08bIpw9z9CW4fqEWt614jnc2B6mIhsawAyI0e7/8owk l92MiF/aan37AdvW06wh4j+2s12JAyL96I0/J4uZHB97CpieJ4JhoidZ1kR9U8mIvtsd EwN8x3rRq3RPYw907Cev0iP/DhVhhstIcxe7x3cXbdJMIexmeNhHYipaPG0CjEEAyWu+ LZcBm3eIsF95JPoyv/47eX7K+oeR386PDpjeMLJp45+TWRD19IBaAQPktB9hK6JHliAJ Pn1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6hvY4p5FF5eRnjuVWtkxhk1sjqpIeEICM36lTpspsRo=; b=Jpyn394ohrncu8B6R/Rx56vvsUV9brTOSwwUUAApLg7INaGbAd1zDCFaM3ysPz8cZu ZLULdvQs8S/8wwxeku9mZOXieBod/LA+Nhv66sxULQZ1pZh5nxaJgZA4XNpWVZVX5T0j D9YIAEtXGWseRWX9Sgwuu0OzqxvH93cVy3vfzm9P6ISZRAL5ZNFYfBQChs4FMNhhf0+7 VvG8F8EFH7e8JTzqcj9lm1oWCizPZQibw3EdlKllWv1MuJYOqeh4KloSBtEm8DX5gxWz 9VcueQg97z1G6kmko7CFZzXpSvoO+3dLhatDqlRKUrh2pC1XOgRNkAoSZRpSXyT+cG6X snGA== X-Gm-Message-State: AOAM530no7x8E7FmbjvYiN0D8ZoPRzyq05/u1zehsgGer0JPK9Bn+Kod gB+hOLTkCWl39Zx1o2Ywu8VzYQ== X-Google-Smtp-Source: ABdhPJztyfH6kHtajiE7qiBm6RgPWmSj0Q+K26uQGnvOp3Fi0OO9sbkUR3pRTNVBepiTBY7SFOuYmw== X-Received: by 2002:adf:de91:: with SMTP id w17mr1256773wrl.352.1623791729144; Tue, 15 Jun 2021 14:15:29 -0700 (PDT) Received: from KernelVM (2.0.5.1.1.6.3.8.5.c.c.3.f.b.d.3.0.0.0.0.6.1.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:df16:0:3dbf:3cc5:8361:1502]) by smtp.gmail.com with ESMTPSA id u15sm3032636wmq.48.2021.06.15.14.15.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 14:15:28 -0700 (PDT) Date: Tue, 15 Jun 2021 22:15:26 +0100 From: Phillip Potter To: Dan Carpenter Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 03/28] staging: rtl8188eu: remove all DBG_88E calls from core/rtw_mlme_ext.c Message-ID: References: <20210615001507.1171-1-phil@philpotter.co.uk> <20210615001507.1171-4-phil@philpotter.co.uk> <20210615103213.GA1861@kadam> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210615103213.GA1861@kadam> On Tue, Jun 15, 2021 at 01:32:13PM +0300, Dan Carpenter wrote: > On Tue, Jun 15, 2021 at 01:14:42AM +0100, Phillip Potter wrote: > > @@ -4510,8 +4311,7 @@ void mlmeext_joinbss_event_callback(struct adapter *padapter, int join_res) > > rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_CONNECT, 0); > > > > exit_mlmeext_joinbss_event_callback: > > - > > - DBG_88E("=>%s\n", __func__); > > + return; > > } > > You'll have to delete the return and the exit_mlmeext_joinbss_event_callback > label in a follow on patch because it introduces a checkpatch warning. > > (I'm not concerned about introducing checkpatch warnings in this patch > too much because fixing them in one got makes the patch a little more > complicated to review. So it's not necessarily even a wrong thing to > introduce a checkpatch warning. Just remember to remove it later. Or > don't remember because eventually someone else will take care of it). > > regards, > dan carpenter > > > > > void mlmeext_sta_add_event_callback(struct adapter *padapter, struct sta_info *psta) > Dear Dan, Thanks, I'll get this done. Regards, Phil