linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Larry.Finger@lwfinger.net, dan.carpenter@oracle.com,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH 0/7] Fixup unused variables and warnings
Date: Wed, 16 Jun 2021 08:58:37 +0100	[thread overview]
Message-ID: <YMmvLfJmoso0xWdJ@equinox> (raw)
In-Reply-To: <YMmnKSWJNIk/XJR7@kroah.com>

On Wed, Jun 16, 2021 at 09:24:25AM +0200, Greg KH wrote:
> On Tue, Jun 15, 2021 at 11:36:00PM +0100, Phillip Potter wrote:
> > This series fixes an empty goto label by removing it and converting its
> > associated goto to a return. It also changes a decrement operator to
> > prefix to make it clearer, and provide expected behaviour. Finally, it
> > removes a lot of unused variables warned about by the kernel test robot,
> > which are a result of my previous DBG_88E removal series, and removes an
> > entire function as well which is surplus to requirements.
> > 
> > Phillip Potter (7):
> >   staging: rtl8188eu: remove empty label from
> >     mlmeext_joinbss_event_callback
> >   staging: rtl8188eu: use prefix decrement operator on trycnt variable
> >   staging: rtl8188eu: remove unused variables from core/rtw_efuse.c
> >   staging: rtl8188eu: remove unused variables from core/rtw_mlme_ext.c
> >   staging: rtl8188eu: remove unused variable from os_dep/ioctl_linux.c
> >   staging: rtl8188eu: remove unused variables from hal/rtl8188e_cmd.c
> >   staging: rtl8188eu: remove _dbg_dump_tx_info function
> 
> In the future, can you use "staging: rtl8188eu:" on the prefix of your
> 0/X email so these can be caught easier by those of us who filter on
> stuff like this?
> 
> And thanks for fixing these so quickly, I'll go apply them now.
> 
> thanks,
> 
> greg k-h

Dear Greg,

Yes, absolutely, my apologies. I don't know why I wasn't doing this
already, seems obvious in hindsight - I put it down to my brain
malfunctioning :-) Many thanks for taking the patches.

Regards,
Phil

      reply	other threads:[~2021-06-16  7:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 22:36 [PATCH 0/7] Fixup unused variables and warnings Phillip Potter
2021-06-15 22:36 ` [PATCH 1/7] staging: rtl8188eu: remove empty label from mlmeext_joinbss_event_callback Phillip Potter
2021-06-15 22:36 ` [PATCH 2/7] staging: rtl8188eu: use prefix decrement operator on trycnt variable Phillip Potter
2021-06-15 22:36 ` [PATCH 3/7] staging: rtl8188eu: remove unused variables from core/rtw_efuse.c Phillip Potter
2021-06-15 22:36 ` [PATCH 4/7] staging: rtl8188eu: remove unused variables from core/rtw_mlme_ext.c Phillip Potter
2021-06-15 22:36 ` [PATCH 5/7] staging: rtl8188eu: remove unused variable from os_dep/ioctl_linux.c Phillip Potter
2021-06-15 22:36 ` [PATCH 6/7] staging: rtl8188eu: remove unused variables from hal/rtl8188e_cmd.c Phillip Potter
2021-06-15 22:36 ` [PATCH 7/7] staging: rtl8188eu: remove _dbg_dump_tx_info function Phillip Potter
2021-06-16  7:24 ` [PATCH 0/7] Fixup unused variables and warnings Greg KH
2021-06-16  7:58   ` Phillip Potter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMmvLfJmoso0xWdJ@equinox \
    --to=phil@philpotter.co.uk \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).