From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BCDE71 for ; Thu, 17 Jun 2021 13:26:38 +0000 (UTC) IronPort-SDR: aPk4bigbR3BwLKNN4CPNS5UWvmiQvNCW3tEZRRQXGRF83fWAtvEb8cFFe27vvc0HJv+F6kcY4W +aOJLq3aTpgw== X-IronPort-AV: E=McAfee;i="6200,9189,10017"; a="206186126" X-IronPort-AV: E=Sophos;i="5.83,280,1616482800"; d="scan'208";a="206186126" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2021 06:26:38 -0700 IronPort-SDR: CsOA3JyKINmJL7mwTbegK0PA8EHx/ohm0UjvZyEXLhIQQfcu3Ow9ZDnmv91mlKuqkqMKeVrEd+ oMIwGT7e+qZA== X-IronPort-AV: E=Sophos;i="5.83,280,1616482800"; d="scan'208";a="554399326" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2021 06:26:34 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1lts2R-003LwZ-Hl; Thu, 17 Jun 2021 16:26:31 +0300 Date: Thu, 17 Jun 2021 16:26:31 +0300 From: Andy Shevchenko To: Baokun Li Cc: mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, kaixuxia@tencent.com, gustavoars@kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, weiyongjun1@huawei.com, yuehaibing@huawei.com, yangjihong1@huawei.com, yukuai3@huawei.com, Hulk Robot Subject: Re: [PATCH -next v5] media: staging: atomisp: use list_splice_init in atomisp_compat_css20.c Message-ID: References: <20210617125357.675562-1-libaokun1@huawei.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210617125357.675562-1-libaokun1@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Jun 17, 2021 at 08:53:57PM +0800, Baokun Li wrote: > Using list_splice_init() instead of entire while-loops > in atomisp_compat_css20.c. > > Reported-by: Hulk Robot > Signed-off-by: Baokun Li > --- > V1->V2: > CC mailist > V2->V3: > Using list_move_tail() -> Using list_splice_init() > V3->V4: > Remove redundant 'asd->' > V4->V5: > Add the version information for 'V3->V4:' What about drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2107:31: warning: unused variable 'md_buf' [-Wunused-variable] 2107 | struct atomisp_metadata_buf *md_buf; drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2106:26: warning: unused variable 'dis_buf' [-Wunused-variable] 2106 | struct atomisp_dis_buf *dis_buf; drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:2105:26: warning: unused variable 's3a_buf' [-Wunused-variable] 2105 | struct atomisp_s3a_buf *s3a_buf; ? -- With Best Regards, Andy Shevchenko