From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Saptarshi Patra <saptarshi.patra.22@gmail.com>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <christian@brauner.io>,
"Hridya Valsaraju" <hridya@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] media: usb: uvc: uvc_driver: Added a function pr_info() in uvc_driver and staging: android: Decleared file operation with const keyword in android keyword
Date: Thu, 15 Jul 2021 23:04:06 +0300 [thread overview]
Message-ID: <YPCUtj9LC+i0/98g@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210715194911.8267-1-saptarshi.patra.22@gmail.com>
Hi Saptarshi,
On Fri, Jul 16, 2021 at 01:19:10AM +0530, Saptarshi Patra wrote:
> media: usb: uvc: uvc_driver: Decleared a function called
> pr_info() with a string input "I changed uvcvideo driver in the Linux
> Kernel"
>
> Added the function pr_info() to see the message / input string using dmesg
I'm curious, could you explain why you think this should be merged in
the upstream kernel ? I fear the kernel log may get a bit too verbose if
everybody added their own little message :-)
> staging: android: Decleared file operation with const keyword
Don't combine multiple independent changes in a single patch.
> Warning found by the checkpatch.pl script
>
> Signed-off-by: Saptarshi Patra <saptarshi.patra.22@gmail.com>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 2 +-
> drivers/staging/android/ashmem.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 9a791d8ef200..0b47ca75091b 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2352,7 +2352,7 @@ static int uvc_probe(struct usb_interface *intf,
> (const struct uvc_device_info *)id->driver_info;
> int function;
> int ret;
> -
> + pr_info("I changed uvcvideo driver in the Linux Kernel\n");
> /* Allocate memory for the device and initialize it. */
> dev = kzalloc(sizeof(*dev), GFP_KERNEL);
> if (dev == NULL)
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index ddbde3f8430e..4c6b420fbf4d 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>
> static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
> {
> - static struct file_operations vmfile_fops;
> + static const struct file_operations vmfile_fops;
You haven't compiled this, have you ?
> struct ashmem_area *asma = file->private_data;
> int ret = 0;
>
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2021-07-15 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 19:49 [PATCH] media: usb: uvc: uvc_driver: Added a function pr_info() in uvc_driver and staging: android: Decleared file operation with const keyword in android keyword Saptarshi Patra
2021-07-15 20:04 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPCUtj9LC+i0/98g@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=maco@android.com \
--cc=mchehab@kernel.org \
--cc=saptarshi.patra.22@gmail.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).