From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABF4872 for ; Mon, 20 Sep 2021 14:50:31 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0E13761107; Mon, 20 Sep 2021 14:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632149431; bh=9pU2Px7mezF2Yu32jqcKn+xxSxkgO7EdGavMtlDHqBg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0QAo/yBnmrTldboO+68acUmTtVXP740q/TzAJOaKb/Zm9S1/N+MUKkJyhtA9HkAc9 vUQqwqYdlnn9NpfQW6vNYTNzvt9sUp2rcItwLYB4ALIYPYjL2zBUU9XA0wjpr50UGx 3T/YxkXo9Xy7DK6bfWSyCgfLW/OqwABvZHAYNVrw= Date: Mon, 20 Sep 2021 16:50:29 +0200 From: Greg KH To: Joshua de Block Cc: dan.carpenter@oracle.com, forest@alittletooquiet.net, aldas60@gmail.com, linux-staging@lists.linux.dev Subject: Re: [PATCH v2] staging: vt6656: Fix warning message generated by checkpatch.pl Message-ID: References: <20210916140551.GK2088@kadam> <20210920143107.3203-1-deblockj0482@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210920143107.3203-1-deblockj0482@gmail.com> On Mon, Sep 20, 2021 at 09:31:08AM -0500, Joshua de Block wrote: > Description: Address the following checkpatch warning: > * WARNING: Unnecessary ftrace-like logging - prefer using ftrace > > Signed-off-by: Joshua de Block > --- > drivers/staging/vt6656/rxtx.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c > index a31947f2620d..5839b34b2e93 100644 > --- a/drivers/staging/vt6656/rxtx.c > +++ b/drivers/staging/vt6656/rxtx.c > @@ -58,8 +58,6 @@ static struct vnt_usb_send_context > struct vnt_usb_send_context *context = NULL; > int ii; > > - dev_dbg(&priv->usb->dev, "%s\n", __func__); > - > for (ii = 0; ii < priv->num_tx_context; ii++) { > if (!priv->tx_context[ii]) > return NULL; > -- > 2.30.2 > > Hi Dan, > > Thanks for catching that. I've modified my commit. > > Joshua > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot