From: Khadija Kamran <kamrankhadijadj@gmail.com>
To: outreachy@lists.linux.dev
Cc: Vaibhav Hiremath <hvaibhav.linux@gmail.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: greybus: merge split lines
Date: Tue, 21 Mar 2023 21:21:35 +0500 [thread overview]
Message-ID: <ZBnZj3JbTOsplHvw@khadija-virtual-machine> (raw)
In-Reply-To: <ZBgYsqkpdYpGQniB@khadija-virtual-machine>
On Mon, Mar 20, 2023 at 01:26:33PM +0500, Khadija Kamran wrote:
> If condition and spin_unlock_...() call is split into two lines, merge
> them to form a single line.
>
> Suggested-by: Deepak R Varma drv@mailo.com
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
>
> Changes in v3:
> - Removing tab to fix line length results in a new checkpatch warning,
> so let the fix length be as it is.
> Changes in v2:
> - Rephrased he subject and description
> - Merged if_condition() and spin_unlock...() into one line
> - Link to patch:
> https://lore.kernel.org/outreachy/ZAusnKYVTGvO5zoi@khadija-virtual-machine/
>
> Link to first patch:
> https://lore.kernel.org/outreachy/ZAtkW6g6DwPg%2FpDp@khadija-virtual-machine/
>
> drivers/staging/greybus/arche-platform.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index fcbd5f71eff2..6890710afdfc 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -176,12 +176,10 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
> * Check we are not in middle of irq thread
> * already
> */
> - if (arche_pdata->wake_detect_state !=
> - WD_STATE_COLDBOOT_START) {
> + if (arche_pdata->wake_detect_state != WD_STATE_COLDBOOT_START) {
> arche_platform_set_wake_detect_state(arche_pdata,
> WD_STATE_COLDBOOT_TRIG);
> - spin_unlock_irqrestore(&arche_pdata->wake_lock,
> - flags);
> + spin_unlock_irqrestore(&arche_pdata->wake_lock, flags);
> return IRQ_WAKE_THREAD;
> }
> }
> --
> 2.34.1
>
Hey Outreachy Mentors,
Kindly take a look at this patch and let me know if it is okay to work
on this file or should I look for other cleanup patches.
Thank you for your time.
Regards,
Khadija
next prev parent reply other threads:[~2023-03-21 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 8:26 [PATCH v3] staging: greybus: merge split lines Khadija Kamran
2023-03-21 16:21 ` Khadija Kamran [this message]
2023-03-21 16:35 ` Alison Schofield
2023-03-27 10:26 ` Khadija Kamran
2023-03-27 17:17 ` Alison Schofield
2023-03-27 21:00 ` Khadija Kamran
2023-03-22 9:08 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBnZj3JbTOsplHvw@khadija-virtual-machine \
--to=kamrankhadijadj@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=hvaibhav.linux@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).