From: Julia Lawall <julia.lawall@inria.fr>
To: Sumitra Sharma <sumitraartsy@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
outreachy@lists.linux.dev, johan@kernel.org, elder@kernel.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] staging: greybus: Inline pwm_chip_to_gb_pwm_chip()
Date: Sun, 26 Mar 2023 07:51:50 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2303260751290.3294@hadrien> (raw)
In-Reply-To: <20230326052420.GA179105@sumitra.com>
On Sat, 25 Mar 2023, Sumitra Sharma wrote:
> On Sat, Mar 25, 2023 at 09:55:45AM +0100, Greg KH wrote:
> > On Sat, Mar 25, 2023 at 01:31:10AM -0700, Sumitra Sharma wrote:
> > > Convert 'pwm_chip_to_gb_pwm_chip' from a macro to a static
> > > inline function, to make the relevant types apparent in the
> > > definition and to benefit from the type checking performed by
> > > the compiler at call sites.
> > >
> > > Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> > > ---
> > > drivers/staging/greybus/pwm.c | 6 ++++--
> > > 1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c
> > > index 3fda172239d2..88da1d796f13 100644
> > > --- a/drivers/staging/greybus/pwm.c
> > > +++ b/drivers/staging/greybus/pwm.c
> > > @@ -21,9 +21,11 @@ struct gb_pwm_chip {
> > > struct pwm_chip chip;
> > > struct pwm_chip *pwm;
> > > };
> > > -#define pwm_chip_to_gb_pwm_chip(chip) \
> > > - container_of(chip, struct gb_pwm_chip, chip)
> > >
> > > +static inline struct gb_pwm_chip *pwm_chip_to_gb_pwm_chip(struct pwm_chip *chip)
> > > +{
> > > + return container_of(chip, struct gb_pwm_chip, chip);
> > > +}
> > >
> > > static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
> > > {
> > > --
> > > 2.25.1
> > >
> > >
> >
> > This patch didn't apply due to changes made in my tree by a patch from
> > someone else before yours. Can you rebase it and resend?
> >
>
> Hi greg,
>
> I am confused, will that be a totally new patch or a new version(v4 in
> this case)?
New version.
julia
>
> Regards,
>
> Sumitra
>
> > thanks,
> >
> > greg k-h
>
>
next prev parent reply other threads:[~2023-03-26 5:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 8:23 [PATCH v3 0/3] staging: greybus: Use Inline fuctions Sumitra Sharma
2023-03-25 8:23 ` [PATCH v3 1/3] staging: greybus: Inline gpio_chip_to_gb_gpio_controller() Sumitra Sharma
2023-03-25 8:31 ` [PATCH v3 2/3] staging: greybus: Inline gb_audio_manager_module() Sumitra Sharma
2023-03-25 8:31 ` [PATCH v3 3/3] staging: greybus: Inline pwm_chip_to_gb_pwm_chip() Sumitra Sharma
2023-03-25 8:55 ` Greg KH
2023-03-26 5:24 ` Sumitra Sharma
2023-03-26 5:51 ` Julia Lawall [this message]
2023-03-26 6:38 ` Sumitra Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2303260751290.3294@hadrien \
--to=julia.lawall@inria.fr \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=sumitraartsy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).