From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C96876D0E for ; Fri, 25 Jun 2021 07:46:12 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 50C17613C0; Fri, 25 Jun 2021 07:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624607172; bh=zCr7xakHM20j5t0qB7rt1N3MWJ4ELpuHzWFgieOCIbk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=new0Vv6Pz1K5A7hRfSwlIQnMARbTBTypdGwWhgzFO9NZ2e0SMHx+o3gaQw372ONA/ R+capB3W5F1GbbXJ99s5hjKh72OCHKcsAkQlKnny7OOPeWDYZMOfJH6hM0oPIRY3lE ZTyBbOvbzQL10CDaFmzxsue+4pN60BgJdaDpxu5MXdZrhMqNMq8y+4Sf7e/xLEUmoG vM4guCUPyyLVQTLj7vLZ4KEO/qZxNPV1I5h6SgKTqQD8DfL1vKbaj74Qdfp1q7wZNO SrZFsH0qIujo9QaUElE5w+L0RJR+HvigRQx5tVv9qNfU4DjlvoR9CEI8vemanarVKY q9lppC7UAflHQ== Received: by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1lwgXS-004aeM-Eo; Fri, 25 Jun 2021 09:46:10 +0200 From: Mauro Carvalho Chehab To: Greg Kroah-Hartman Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , "Lee Jones" , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v8 05/12] staging: hi6421-spmi-pmic: use devm_request_threaded_irq() Date: Fri, 25 Jun 2021 09:45:57 +0200 Message-Id: X-Mailer: git-send-email 2.31.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab Use devm_request_threaded_irq() in order to simplify the driver. Suggested-by: Lee Jones Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c index 29ac53684ad2..2b55acdaad85 100644 --- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c +++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c @@ -250,9 +250,11 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev) ddata->irqs[i] = virq; } - ret = request_threaded_irq(ddata->irq, hi6421_spmi_irq_handler, NULL, - IRQF_TRIGGER_LOW | IRQF_SHARED | IRQF_NO_SUSPEND, - "pmic", ddata); + ret = devm_request_threaded_irq(dev, + ddata->irq, hi6421_spmi_irq_handler, + NULL, + IRQF_TRIGGER_LOW | IRQF_SHARED | IRQF_NO_SUSPEND, + "pmic", ddata); if (ret < 0) { dev_err(dev, "Failed to start IRQ handling thread: error %d\n", ret); @@ -270,13 +272,6 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev) return ret; } -static void hi6421_spmi_pmic_remove(struct spmi_device *pdev) -{ - struct hi6421_spmi_pmic *ddata = dev_get_drvdata(&pdev->dev); - - free_irq(ddata->irq, ddata); -} - static const struct of_device_id pmic_spmi_id_table[] = { { .compatible = "hisilicon,hi6421-spmi" }, { } @@ -289,7 +284,6 @@ static struct spmi_driver hi6421_spmi_pmic_driver = { .of_match_table = pmic_spmi_id_table, }, .probe = hi6421_spmi_pmic_probe, - .remove = hi6421_spmi_pmic_remove, }; module_spmi_driver(hi6421_spmi_pmic_driver); -- 2.31.1