From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Liu Shixin <liushixin2@huawei.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 2/2] staging: r8188eu: use eth_broadcast_addr() to assign broadcast address
Date: Tue, 08 Jun 2021 09:45:49 -0700 [thread overview]
Message-ID: <b77a3e7b0923344e8c5b9b17f4788d28f3ccfb4f.camel@perches.com> (raw)
In-Reply-To: <YL96vz4okNehxCBG@kroah.com>
On Tue, 2021-06-08 at 16:12 +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 08, 2021 at 10:16:20PM +0800, Liu Shixin wrote:
> > Use eth_broadcast_addr() to assign broadcast address.
>
> That says what you do, but not _why_ you are doing this?
>
> Why make this change? What benifit does it provide?
The commit message is clear and concise as using available kernel
mechanisms is better than homegrown or duplicative ones.
Are you asking merely becuse Liu Shixin hasn't had many staging
commits?
next prev parent reply other threads:[~2021-06-08 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 14:16 [PATCH -next 2/2] staging: r8188eu: use eth_broadcast_addr() to assign broadcast address Liu Shixin
2021-06-08 14:12 ` Greg Kroah-Hartman
2021-06-08 16:45 ` Joe Perches [this message]
2021-06-08 17:01 ` Greg Kroah-Hartman
2021-06-08 17:34 ` Joe Perches
2021-06-09 3:01 ` Liu Shixin
2021-06-09 6:53 ` Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b77a3e7b0923344e8c5b9b17f4788d28f3ccfb4f.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=liushixin2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).