From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ashish Kalra <eashishkalra@gmail.com>
Cc: Abheek Dhawan <adawesomeguy222@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Romain Perier <romain.perier@gmail.com>,
Waiman Long <longman@redhat.com>,
Allen Pais <apais@linux.microsoft.com>,
Ivan Safonov <insafonov@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) warning
Date: Fri, 23 Apr 2021 23:11:05 -0700 [thread overview]
Message-ID: <bc8873a274bf489ad856386a9d9ee1110de4c4d3.camel@perches.com> (raw)
In-Reply-To: <YIOz6o8gwHv+cAN7@kroah.com>
On Sat, 2021-04-24 at 08:00 +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 23, 2021 at 08:56:19PM +0530, Ashish Kalra wrote:
> > On Thu, Apr 22, 2021 at 10:43:13AM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Apr 20, 2021 at 02:31:42PM +0530, Ashish Kalra wrote:
> > > > Upon running sparse, "warning: incorrect type in argument 1 (different address spaces)
> > > > is brought to notice for this file.let's add correct typecast to make it cleaner and
> > > > silence the Sparse warning.
[]
> > struct p80211ioctl_req {
> > char name[WLAN_DEVNAMELEN_MAX];
> > - caddr_t data;
> > + void __user *data;
> >
> > Does this looks ok to you and is there any other check possible if this is ok?
>
> Wait, what is "caddr_t"? Try unwinding that mess first...
Might not be that simple.
include/linux/types.h:typedef __kernel_caddr_t caddr_t;
include/uapi/linux/coda.h:typedef void * caddr_t;
include/uapi/asm-generic/posix_types.h:typedef char * __kernel_caddr_t;
next prev parent reply other threads:[~2021-04-24 6:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 9:01 [PATCH] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) warning Ashish Kalra
2021-04-22 8:43 ` Greg Kroah-Hartman
2021-04-23 15:26 ` Ashish Kalra
2021-04-24 5:59 ` Greg Kroah-Hartman
2021-04-24 6:00 ` Greg Kroah-Hartman
2021-04-24 6:11 ` Joe Perches [this message]
2021-04-24 8:15 ` Ashish Kalra
2021-04-24 8:28 ` Greg Kroah-Hartman
2021-04-27 12:23 ` ashish
2021-04-27 12:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc8873a274bf489ad856386a9d9ee1110de4c4d3.camel@perches.com \
--to=joe@perches.com \
--cc=adawesomeguy222@gmail.com \
--cc=apais@linux.microsoft.com \
--cc=eashishkalra@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=insafonov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=longman@redhat.com \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).