linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Yang Yingliang <yangyingliang@huawei.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-staging@lists.linux.dev>,
	<linux-media@vger.kernel.org>, <mchehab@kernel.org>,
	<sakari.ailus@linux.intel.com>
Subject: Re: [PATCH -next resend] media: staging: media: atomisp: pci: fix error return code in atomisp_pci_probe()
Date: Thu, 17 Jun 2021 22:06:15 +0800	[thread overview]
Message-ID: <f6340eca-dcf6-770a-1296-8143df42d506@huawei.com> (raw)
In-Reply-To: <20210617135824.GO1901@kadam>


On 2021/6/17 21:58, Dan Carpenter wrote:
> Looks good.
>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> But next time please use v2 in the subject instead of "resend".  "resend"
> means that the process broke down somehow and we ignored your first
> patch.
>
> On Thu, Jun 17, 2021 at 09:55:00PM +0800, Yang Yingliang wrote:
>> If init_atomisp_wdts() fails, atomisp_pci_probe() need return
>> error code.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
> Put a note here under the --- cut off line to say what happened since
> the last version.
>
> v2: style change
OK

Thanks,
Yang
>
>
>>   drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
> regards,
> dan carpenter
>
> .

      reply	other threads:[~2021-06-17 14:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 13:55 [PATCH -next resend] media: staging: media: atomisp: pci: fix error return code in atomisp_pci_probe() Yang Yingliang
2021-06-17 13:58 ` Dan Carpenter
2021-06-17 14:06   ` Yang Yingliang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6340eca-dcf6-770a-1296-8143df42d506@huawei.com \
    --to=yangyingliang@huawei.com \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).