linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Nam Cao <namcaov@gmail.com>
To: forest@alittletooquiet.net, gregkh@linuxfoundation.org
Cc: namcaov@gmail.com, philipp.g.hortmann@gmail.com,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: [RFC PATCH 2/5] staging: vt6655: change vnt_receive_frame return type to void
Date: Thu, 15 Sep 2022 22:29:33 +0200	[thread overview]
Message-ID: <f727ea04703858920f6da694676ec323469e7b97.1663273218.git.namcaov@gmail.com> (raw)
In-Reply-To: <cover.1663273218.git.namcaov@gmail.com>

The function vnt_receive_frame's returned value is not used anywhere.
Furthermore, it always return true. Change its return type to void.

Signed-off-by: Nam Cao <namcaov@gmail.com>
---
 drivers/staging/vt6655/dpc.c | 8 ++++----
 drivers/staging/vt6655/dpc.h | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/vt6655/dpc.c b/drivers/staging/vt6655/dpc.c
index c6ed3537f439..9f2128f5d3c3 100644
--- a/drivers/staging/vt6655/dpc.c
+++ b/drivers/staging/vt6655/dpc.c
@@ -115,7 +115,7 @@ static bool vnt_rx_data(struct vnt_private *priv, struct sk_buff *skb,
 	return true;
 }
 
-bool vnt_receive_frame(struct vnt_private *priv, struct vnt_rx_desc *curr_rd)
+void vnt_receive_frame(struct vnt_private *priv, struct vnt_rx_desc *curr_rd)
 {
 	struct vnt_rd_info *rd_info = curr_rd->rd_info;
 	struct sk_buff *skb;
@@ -133,13 +133,13 @@ bool vnt_receive_frame(struct vnt_private *priv, struct vnt_rx_desc *curr_rd)
 		/* Frame Size error drop this packet.*/
 		dev_dbg(&priv->pcid->dev, "Wrong frame size %d\n", frame_size);
 		dev_kfree_skb_irq(skb);
-		return true;
+		return;
 	}
 
 	if (vnt_rx_data(priv, skb, frame_size))
-		return true;
+		return;
 
 	dev_kfree_skb_irq(skb);
 
-	return true;
+	return;
 }
diff --git a/drivers/staging/vt6655/dpc.h b/drivers/staging/vt6655/dpc.h
index 40364c0ab7f6..f67c1ef23171 100644
--- a/drivers/staging/vt6655/dpc.h
+++ b/drivers/staging/vt6655/dpc.h
@@ -16,6 +16,6 @@
 
 #include "device.h"
 
-bool vnt_receive_frame(struct vnt_private *priv, struct vnt_rx_desc *curr_rd);
+void vnt_receive_frame(struct vnt_private *priv, struct vnt_rx_desc *curr_rd);
 
 #endif /* __RXTX_H__ */
-- 
2.25.1


  parent reply	other threads:[~2022-09-15 20:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 20:29 [RFC PATCH 0/5] staging: vt6655: Implement allocation failure handling Nam Cao
2022-09-15 20:29 ` [RFC PATCH 1/5] staging: vt6655: remove redundant if condition Nam Cao
2022-09-15 20:29 ` Nam Cao [this message]
2022-09-19  9:45   ` [RFC PATCH 2/5] staging: vt6655: change vnt_receive_frame return type to void Dan Carpenter
2022-09-27 11:36     ` Nam Cao
2022-09-15 20:29 ` [RFC PATCH 3/5] staging: vt6655: split device_alloc_rx_buf Nam Cao
2022-09-19  9:36   ` Dan Carpenter
2022-09-27 11:39     ` Nam Cao
2022-09-15 20:29 ` [RFC PATCH 4/5] staging: vt6655: change device_alloc_rx_buf's argument Nam Cao
2022-09-15 20:29 ` [RFC PATCH 5/5] staging: vt6655: implement allocation failure handling Nam Cao
2022-09-19 10:12   ` Dan Carpenter
2022-09-27 11:54     ` Nam Cao
2022-09-15 20:58 ` [RFC PATCH 0/5] staging: vt6655: Implement " Philipp Hortmann
2022-09-16  7:11   ` Nam Cao
2022-09-16  7:38     ` Dan Carpenter
2022-09-19  9:36       ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f727ea04703858920f6da694676ec323469e7b97.1663273218.git.namcaov@gmail.com \
    --to=namcaov@gmail.com \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).