From: David Laight <David.Laight@ACULAB.COM>
To: 'Colin King' <colin.king@canonical.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] staging: r8188eu: Fix while-loop that iterates only once
Date: Tue, 29 Jun 2021 21:53:20 +0000 [thread overview]
Message-ID: <ff4444d1d2204539945ded9bf06c94e6@AcuMS.aculab.com> (raw)
In-Reply-To: <20210629163624.41543-1-colin.king@canonical.com>
From: Colin King
> Sent: 29 June 2021 17:36
>
> The while-loop only iterates once becase the post increment test of count
> being non-zero is false on the first iteration because count is zero. Fix
> this by incrementing count using pre-increment. Static analysis found the
> issue on the count > POLLING_LLT_THRESHOLD check always being false since
> the loop currently just iterates once.
But that is a very strange 'loop bottom'.
...
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
> b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
> index d1086699f952..db57f04e7e56 100644
> --- a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
> +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
> @@ -185,7 +185,7 @@ static s32 _LLTWrite(struct adapter *padapter, u32 address, u32 data)
> break;
> }
> udelay(5);
> - } while (count++);
> + } while (++count);
Unless 'count' is negative that might as well be 'while (1)'
with count incremented elsewhere.
Perhaps the loop top should be:
for (count = 0;; count++) {
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-06-29 21:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 16:36 Colin King
2021-06-29 21:53 ` David Laight [this message]
2021-06-30 6:44 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff4444d1d2204539945ded9bf06c94e6@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=Larry.Finger@lwfinger.net \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--subject='RE: [PATCH] staging: r8188eu: Fix while-loop that iterates only once' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).