* [PATCH 00/25] Fix some PM runtime issues at the media subsystem
@ 2021-05-05 9:41 Mauro Carvalho Chehab
2021-05-05 9:42 ` [PATCH 21/25] media: sunxi: fix pm_runtime_get_sync() usage count Mauro Carvalho Chehab
2021-05-06 15:11 ` [PATCH 00/25] Fix some PM runtime issues at the media subsystem Mauro Carvalho Chehab
0 siblings, 2 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2021-05-05 9:41 UTC (permalink / raw)
Cc: linuxarm, mauro.chehab, Mauro Carvalho Chehab, Lad, Prabhakar,
Paul J. Murphy, Andrzej Pietrasiewicz, Andy Gross,
Bjorn Andersson, Chen-Yu Tsai, Daniele Alessandrelli,
Ezequiel Garcia, Fabio Estevam, Jacek Anaszewski, Jernej Skrabec,
Krzysztof Kozlowski, Marek Szyprowski, Matthias Brugger,
Mauro Carvalho Chehab, Maxime Ripard, NXP Linux Team,
Pengutronix Kernel Team, Philipp Zabel, Rui Miguel Silva,
Sakari Ailus, Sascha Hauer, Shawn Guo, Stanimir Varbanov,
Steve Longerbeam, Sylwester Nawrocki, linux-arm-kernel,
linux-arm-msm, linux-kernel, linux-media, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-samsung-soc,
linux-staging, linux-sunxi
As part of an effort to cleanup pm_runtime*get* calls, I detected a number
of issues at the media subsystem.
Most of the patches here were submitted previously at:
https://lore.kernel.org/linux-media/cover.1619621413.git.mchehab+huawei@kernel.org/
This series contain just the bug fixes and other related issues that are
present with the current code on media.
It address the points from the existing reviews. I also did my own
set of reviews, in order to avoid regressions.
Changes from v4 of the previous changeset:
- reworked i2c/css RPM get logic;
- dropped two patches that could cause regressions;
- am437x: keep using pm_runtime_get_sync on suspend/resume;
- atmel: fix the returned code and add a print on failures at start streaming;
- simplify some checks for return code > 0;
- mdk-vcodec: properly handle RPM errors at device on logic;
- venus: rework venus_sys_error_handler() logic;
- sti/delta: fix an issue at the error checking logic.
Mauro Carvalho Chehab (25):
staging: media: rkvdec: fix pm_runtime_get_sync() usage count
staging: media: imx7-mipi-csis: fix pm_runtime_get_sync() usage count
media: venus: Rework error fail recover logic
media: s5p_cec: decrement usage count if disabled
media: i2c: ccs-core: return the right error code at suspend
media: i2c: imx334: fix the pm runtime get logic
media: exynos-gsc: don't resume at remove time
media: atmel: properly get pm_runtime
media: hantro: do a PM resume earlier
media: marvel-ccic: fix some issues when getting pm_runtime
media: mdk-mdp: fix pm_runtime_get_sync() usage count
media: rcar_fdp1: simplify error check logic at fdp_open()
media: rcar_fdp1: fix pm_runtime_get_sync() usage count
media: renesas-ceu: Properly check for PM errors
media: s5p: fix pm_runtime_get_sync() usage count
media: am437x: fix pm_runtime_get_sync() usage count
media: sh_vou: fix pm_runtime_get_sync() usage count
media: mtk-vcodec: fix PM runtime get logic
media: s5p-jpeg: fix pm_runtime_get_sync() usage count
media: sti/delta: use pm_runtime_resume_and_get()
media: sunxi: fix pm_runtime_get_sync() usage count
media: sti/bdisp: fix pm_runtime_get_sync() usage count
media: exynos4-is: fix pm_runtime_get_sync() usage count
media: exynos-gsc: fix pm_runtime_get_sync() usage count
media: i2c: ccs-core: fix pm_runtime_get_sync() usage count
drivers/media/cec/platform/s5p/s5p_cec.c | 7 ++-
drivers/media/i2c/ccs/ccs-core.c | 41 ++++++++-----
drivers/media/i2c/imx334.c | 7 ++-
drivers/media/platform/am437x/am437x-vpfe.c | 15 ++++-
drivers/media/platform/atmel/atmel-isc-base.c | 30 +++++++---
drivers/media/platform/atmel/atmel-isi.c | 19 ++++--
drivers/media/platform/exynos-gsc/gsc-core.c | 11 ++--
drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 +-
.../media/platform/exynos4-is/fimc-capture.c | 6 +-
drivers/media/platform/exynos4-is/fimc-is.c | 4 +-
.../platform/exynos4-is/fimc-isp-video.c | 3 +-
drivers/media/platform/exynos4-is/fimc-isp.c | 7 +--
drivers/media/platform/exynos4-is/fimc-lite.c | 5 +-
drivers/media/platform/exynos4-is/fimc-m2m.c | 5 +-
drivers/media/platform/exynos4-is/media-dev.c | 9 +--
drivers/media/platform/exynos4-is/mipi-csis.c | 10 ++--
.../media/platform/marvell-ccic/mcam-core.c | 9 ++-
drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 6 +-
.../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 4 +-
.../platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 8 ++-
.../platform/mtk-vcodec/mtk_vcodec_dec_pm.h | 2 +-
drivers/media/platform/qcom/venus/core.c | 59 +++++++++++++++----
drivers/media/platform/rcar_fdp1.c | 28 ++++++---
drivers/media/platform/renesas-ceu.c | 4 +-
drivers/media/platform/s5p-jpeg/jpeg-core.c | 5 +-
drivers/media/platform/sh_vou.c | 6 +-
drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 7 ++-
drivers/media/platform/sti/delta/delta-v4l2.c | 8 +--
.../sunxi/sun8i-rotate/sun8i_rotate.c | 2 +-
drivers/staging/media/hantro/hantro_drv.c | 7 ++-
drivers/staging/media/imx/imx7-mipi-csis.c | 7 +--
drivers/staging/media/rkvdec/rkvdec.c | 2 +-
32 files changed, 220 insertions(+), 127 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 21/25] media: sunxi: fix pm_runtime_get_sync() usage count
2021-05-05 9:41 [PATCH 00/25] Fix some PM runtime issues at the media subsystem Mauro Carvalho Chehab
@ 2021-05-05 9:42 ` Mauro Carvalho Chehab
2021-05-06 15:11 ` [PATCH 00/25] Fix some PM runtime issues at the media subsystem Mauro Carvalho Chehab
1 sibling, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2021-05-05 9:42 UTC (permalink / raw)
Cc: linuxarm, mauro.chehab, Mauro Carvalho Chehab, Chen-Yu Tsai,
Jernej Skrabec, Mauro Carvalho Chehab, Maxime Ripard,
linux-arm-kernel, linux-kernel, linux-media, linux-sunxi,
Jonathan Cameron
The pm_runtime_get_sync() internally increments the
dev->power.usage_count without decrementing it, even on errors.
Replace it by the new pm_runtime_resume_and_get(), introduced by:
commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
in order to properly decrement the usage counter, avoiding
a potential PM usage counter leak.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c b/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c
index 3f81dd17755c..fbcca59a0517 100644
--- a/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c
+++ b/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c
@@ -494,7 +494,7 @@ static int rotate_start_streaming(struct vb2_queue *vq, unsigned int count)
struct device *dev = ctx->dev->dev;
int ret;
- ret = pm_runtime_get_sync(dev);
+ ret = pm_runtime_resume_and_get(dev);
if (ret < 0) {
dev_err(dev, "Failed to enable module\n");
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 00/25] Fix some PM runtime issues at the media subsystem
2021-05-05 9:41 [PATCH 00/25] Fix some PM runtime issues at the media subsystem Mauro Carvalho Chehab
2021-05-05 9:42 ` [PATCH 21/25] media: sunxi: fix pm_runtime_get_sync() usage count Mauro Carvalho Chehab
@ 2021-05-06 15:11 ` Mauro Carvalho Chehab
1 sibling, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2021-05-06 15:11 UTC (permalink / raw)
Cc: linuxarm, mauro.chehab, Lad, Prabhakar, Paul J. Murphy,
Andrzej Pietrasiewicz, Andy Gross, Bjorn Andersson, Chen-Yu Tsai,
Daniele Alessandrelli, Ezequiel Garcia, Fabio Estevam,
Jacek Anaszewski, Jernej Skrabec, Krzysztof Kozlowski,
Marek Szyprowski, Matthias Brugger, Mauro Carvalho Chehab,
Maxime Ripard, NXP Linux Team, Pengutronix Kernel Team,
Philipp Zabel, Rui Miguel Silva, Sakari Ailus, Sascha Hauer,
Shawn Guo, Stanimir Varbanov, Steve Longerbeam,
Sylwester Nawrocki, linux-arm-kernel, linux-arm-msm,
linux-kernel, linux-media, linux-mediatek, linux-renesas-soc,
linux-rockchip, linux-samsung-soc, linux-staging, linux-sunxi
Em Wed, 5 May 2021 11:41:50 +0200
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> escreveu:
> As part of an effort to cleanup pm_runtime*get* calls, I detected a number
> of issues at the media subsystem.
>
> Most of the patches here were submitted previously at:
>
> https://lore.kernel.org/linux-media/cover.1619621413.git.mchehab+huawei@kernel.org/
>
> This series contain just the bug fixes and other related issues that are
> present with the current code on media.
Series merged on my stage tree, at:
https://git.linuxtv.org/media_stage.git/log/
I'll be merging it at media_tree (either for 5.13 or 5.14) after the
end of the merge window (likely next week).
Please let me know if you find any problems on it.
PS.: please notice that my stage tree can be rebased.
Regards,
Mauro
>
> It address the points from the existing reviews. I also did my own
> set of reviews, in order to avoid regressions.
>
> Changes from v4 of the previous changeset:
>
> - reworked i2c/css RPM get logic;
> - dropped two patches that could cause regressions;
> - am437x: keep using pm_runtime_get_sync on suspend/resume;
> - atmel: fix the returned code and add a print on failures at start streaming;
> - simplify some checks for return code > 0;
> - mdk-vcodec: properly handle RPM errors at device on logic;
> - venus: rework venus_sys_error_handler() logic;
> - sti/delta: fix an issue at the error checking logic.
>
> Mauro Carvalho Chehab (25):
> staging: media: rkvdec: fix pm_runtime_get_sync() usage count
> staging: media: imx7-mipi-csis: fix pm_runtime_get_sync() usage count
> media: venus: Rework error fail recover logic
> media: s5p_cec: decrement usage count if disabled
> media: i2c: ccs-core: return the right error code at suspend
> media: i2c: imx334: fix the pm runtime get logic
> media: exynos-gsc: don't resume at remove time
> media: atmel: properly get pm_runtime
> media: hantro: do a PM resume earlier
> media: marvel-ccic: fix some issues when getting pm_runtime
> media: mdk-mdp: fix pm_runtime_get_sync() usage count
> media: rcar_fdp1: simplify error check logic at fdp_open()
> media: rcar_fdp1: fix pm_runtime_get_sync() usage count
> media: renesas-ceu: Properly check for PM errors
> media: s5p: fix pm_runtime_get_sync() usage count
> media: am437x: fix pm_runtime_get_sync() usage count
> media: sh_vou: fix pm_runtime_get_sync() usage count
> media: mtk-vcodec: fix PM runtime get logic
> media: s5p-jpeg: fix pm_runtime_get_sync() usage count
> media: sti/delta: use pm_runtime_resume_and_get()
> media: sunxi: fix pm_runtime_get_sync() usage count
> media: sti/bdisp: fix pm_runtime_get_sync() usage count
> media: exynos4-is: fix pm_runtime_get_sync() usage count
> media: exynos-gsc: fix pm_runtime_get_sync() usage count
> media: i2c: ccs-core: fix pm_runtime_get_sync() usage count
>
> drivers/media/cec/platform/s5p/s5p_cec.c | 7 ++-
> drivers/media/i2c/ccs/ccs-core.c | 41 ++++++++-----
> drivers/media/i2c/imx334.c | 7 ++-
> drivers/media/platform/am437x/am437x-vpfe.c | 15 ++++-
> drivers/media/platform/atmel/atmel-isc-base.c | 30 +++++++---
> drivers/media/platform/atmel/atmel-isi.c | 19 ++++--
> drivers/media/platform/exynos-gsc/gsc-core.c | 11 ++--
> drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 +-
> .../media/platform/exynos4-is/fimc-capture.c | 6 +-
> drivers/media/platform/exynos4-is/fimc-is.c | 4 +-
> .../platform/exynos4-is/fimc-isp-video.c | 3 +-
> drivers/media/platform/exynos4-is/fimc-isp.c | 7 +--
> drivers/media/platform/exynos4-is/fimc-lite.c | 5 +-
> drivers/media/platform/exynos4-is/fimc-m2m.c | 5 +-
> drivers/media/platform/exynos4-is/media-dev.c | 9 +--
> drivers/media/platform/exynos4-is/mipi-csis.c | 10 ++--
> .../media/platform/marvell-ccic/mcam-core.c | 9 ++-
> drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 6 +-
> .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 4 +-
> .../platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 8 ++-
> .../platform/mtk-vcodec/mtk_vcodec_dec_pm.h | 2 +-
> drivers/media/platform/qcom/venus/core.c | 59 +++++++++++++++----
> drivers/media/platform/rcar_fdp1.c | 28 ++++++---
> drivers/media/platform/renesas-ceu.c | 4 +-
> drivers/media/platform/s5p-jpeg/jpeg-core.c | 5 +-
> drivers/media/platform/sh_vou.c | 6 +-
> drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 7 ++-
> drivers/media/platform/sti/delta/delta-v4l2.c | 8 +--
> .../sunxi/sun8i-rotate/sun8i_rotate.c | 2 +-
> drivers/staging/media/hantro/hantro_drv.c | 7 ++-
> drivers/staging/media/imx/imx7-mipi-csis.c | 7 +--
> drivers/staging/media/rkvdec/rkvdec.c | 2 +-
> 32 files changed, 220 insertions(+), 127 deletions(-)
>
Thanks,
Mauro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-06 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-05 9:41 [PATCH 00/25] Fix some PM runtime issues at the media subsystem Mauro Carvalho Chehab
2021-05-05 9:42 ` [PATCH 21/25] media: sunxi: fix pm_runtime_get_sync() usage count Mauro Carvalho Chehab
2021-05-06 15:11 ` [PATCH 00/25] Fix some PM runtime issues at the media subsystem Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).