From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D6C77B for ; Fri, 15 Apr 2022 18:26:46 +0000 (UTC) Received: by mail-ed1-f52.google.com with SMTP id 11so5715625edw.0 for ; Fri, 15 Apr 2022 11:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IiEEMcnc8dyMVnBJRf8MBjYNQSDHZ+TAbtPueaX++m0=; b=XlyJgGlEKw1+nZmDqLlTFmkpRbE3WY6xFRWI29Ehk3YkJS42+sroJQPzN2D6UZAaTO Dk4PkGS/yk/DjxDprFA5+I+AMs7pCnfcCdg1AtYAQL3yuiVxetD0tq3x3aTBurzQlVuM 93h0RU+gr6RmWzxcz2zEQ9QNYBLtjSJcCTzEQnir3MVaCwvybVDECwX6eUKEQn6VVfvC LTMbMkf/CGKNdftyt7Si0DkDsrmapJcb3SdCvCNBjeS4bsRhav+7UX1Dh0m+qJPhKRiU rJZW47By9XhQxEMklWuVQyoIT9vvNKK+i2xU0Pr4Bb2v/+ddexNSwJwK9M7dSo29Qiq8 zslw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IiEEMcnc8dyMVnBJRf8MBjYNQSDHZ+TAbtPueaX++m0=; b=yY+TyITxI5tqadf3wFhqoEPqe62vz/GQiOePQhiL2b0WCvV2XfHR4JPkWszJRJPLtB eU9RrhwmwxeejpUfaNC/bUvgM/zYq7rkGWgd4EbGbWkDQEJ20eA4tOn8Yzb/Ofu62xIs mwVmzsgGt8MgLENuJ6xprpuiHOjL3ssanRczJ6xr1/+3S8vYMvmQXIulWOXME5jpcAVu 8F9HEQHEdChUO5j0SjyhGVR2nSvRV1ophL7Yl/dw/5fbs7W79RsJf4M6ZugXqYGsFfAF yVsVIHBUkxUAh9iAsr0/7asVQEESzAP2nNQOL2rNQvzlcC5FM3KaxhpASZSAfmRkkjyX TRVA== X-Gm-Message-State: AOAM531yZJUupnW2JuF32gBKy6SLqdczXgBv+UolSG6zgax/5Xm+RSeX pSNxDmn1AHNMOp4pRjLDG/Y= X-Google-Smtp-Source: ABdhPJzE85rlxtGMZSL07NJOiy1Xzm62tnxA5MAw9j5i4vVTV49Kks/7gyXFAgjcN+z8CCTqudY4UA== X-Received: by 2002:a05:6402:84e:b0:422:b76c:bef8 with SMTP id b14-20020a056402084e00b00422b76cbef8mr497096edz.238.1650047204478; Fri, 15 Apr 2022 11:26:44 -0700 (PDT) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id z2-20020a1709063a0200b006e05b7ce3efsm1910625eje.107.2022.04.15.11.26.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 11:26:44 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Alessandro Zummo , Alexandre Belloni , Samuel Holland Cc: Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] rtc: sun6i: Add NVMEM provider Date: Fri, 15 Apr 2022 20:26:43 +0200 Message-ID: <10062096.nUPlyArG6x@jernej-laptop> In-Reply-To: <20220413231731.56709-1-samuel@sholland.org> References: <20220413231731.56709-1-samuel@sholland.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne =C4=8Detrtek, 14. april 2022 ob 01:17:30 CEST je Samuel Holland napisal= (a): > The sun6i RTC provides 32 bytes of general-purpose data registers. > They can be used to save data in the always-on RTC power domain. > The registers are writable via 32-bit MMIO accesses only. >=20 > Expose them with a NVMEM provider so they can be used by other drivers. >=20 > Signed-off-by: Samuel Holland Acked-by: Jernej Skrabec Best regards, Jernej > --- >=20 > drivers/rtc/rtc-sun6i.c | 42 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) >=20 > diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c > index 5b3e4da63406..755aeb82a285 100644 > --- a/drivers/rtc/rtc-sun6i.c > +++ b/drivers/rtc/rtc-sun6i.c > @@ -71,6 +71,10 @@ > #define SUN6I_LOSC_OUT_GATING 0x0060 > #define SUN6I_LOSC_OUT_GATING_EN_OFFSET 0 >=20 > +/* General-purpose data */ > +#define SUN6I_GP_DATA 0x0100 > +#define SUN6I_GP_DATA_SIZE 0x20 > + > /* > * Get date values > */ > @@ -662,6 +666,39 @@ static const struct rtc_class_ops sun6i_rtc_ops =3D { > .alarm_irq_enable =3D sun6i_rtc_alarm_irq_enable > }; >=20 > +static int sun6i_rtc_nvmem_read(void *priv, unsigned int offset, void > *_val, size_t bytes) +{ > + struct sun6i_rtc_dev *chip =3D priv; > + u32 *val =3D _val; > + int i; > + > + for (i =3D 0; i < bytes / 4; ++i) > + val[i] =3D readl(chip->base + SUN6I_GP_DATA + offset + 4 *=20 i); > + > + return 0; > +} > + > +static int sun6i_rtc_nvmem_write(void *priv, unsigned int offset, void > *_val, size_t bytes) +{ > + struct sun6i_rtc_dev *chip =3D priv; > + u32 *val =3D _val; > + int i; > + > + for (i =3D 0; i < bytes / 4; ++i) > + writel(val[i], chip->base + SUN6I_GP_DATA + offset + 4 *=20 i); > + > + return 0; > +} > + > +static struct nvmem_config sun6i_rtc_nvmem_cfg =3D { > + .type =3D NVMEM_TYPE_BATTERY_BACKED, > + .reg_read =3D sun6i_rtc_nvmem_read, > + .reg_write =3D sun6i_rtc_nvmem_write, > + .size =3D SUN6I_GP_DATA_SIZE, > + .word_size =3D 4, > + .stride =3D 4, > +}; > + > #ifdef CONFIG_PM_SLEEP > /* Enable IRQ wake on suspend, to wake up from RTC. */ > static int sun6i_rtc_suspend(struct device *dev) > @@ -795,6 +832,11 @@ static int sun6i_rtc_probe(struct platform_device > *pdev) if (ret) > return ret; >=20 > + sun6i_rtc_nvmem_cfg.priv =3D chip; > + ret =3D devm_rtc_nvmem_register(chip->rtc, &sun6i_rtc_nvmem_cfg); > + if (ret) > + return ret; > + > dev_info(&pdev->dev, "RTC enabled\n"); >=20 > return 0;