* [PATCH V2 0/2] arch: Cleanup unused functions @ 2021-05-30 4:53 guoren 2021-05-30 4:53 ` [PATCH V2 1/2] riscv: " guoren 2021-05-30 4:53 ` [PATCH V2 2/2] microblaze: " guoren 0 siblings, 2 replies; 6+ messages in thread From: guoren @ 2021-05-30 4:53 UTC (permalink / raw) To: guoren, anup.patel, palmerdabbelt, arnd Cc: linux-riscv, linux-kernel, linux-arch, linux-sunxi, Guo Ren From: Guo Ren <guoren@linux.alibaba.com> These functions haven't been used, so just remove them. The patch has been tested with riscv, but I only use grep to check the microblaze's. Changes since v1: - Separate into two patches - Add Reviewed-by & Acked-by Guo Ren (2): riscv: Cleanup unused functions microblaze: Cleanup unused functions arch/microblaze/include/asm/page.h | 3 --- arch/riscv/include/asm/page.h | 10 ---------- 2 files changed, 13 deletions(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2 1/2] riscv: Cleanup unused functions 2021-05-30 4:53 [PATCH V2 0/2] arch: Cleanup unused functions guoren @ 2021-05-30 4:53 ` guoren 2021-06-09 0:18 ` Palmer Dabbelt 2021-05-30 4:53 ` [PATCH V2 2/2] microblaze: " guoren 1 sibling, 1 reply; 6+ messages in thread From: guoren @ 2021-05-30 4:53 UTC (permalink / raw) To: guoren, anup.patel, palmerdabbelt, arnd Cc: linux-riscv, linux-kernel, linux-arch, linux-sunxi, Guo Ren From: Guo Ren <guoren@linux.alibaba.com> These functions haven't been used, so just remove them. The patch has been tested with riscv. Signed-off-by: Guo Ren <guoren@linux.alibaba.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Anup Patel <anup@brainfault.org> Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com> Acked-by: Palmer Dabbelt <palmerdabbelt@google.com> --- arch/riscv/include/asm/page.h | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/arch/riscv/include/asm/page.h b/arch/riscv/include/asm/page.h index 6a7761c..a1b888f 100644 --- a/arch/riscv/include/asm/page.h +++ b/arch/riscv/include/asm/page.h @@ -37,16 +37,6 @@ #ifndef __ASSEMBLY__ -#define PAGE_UP(addr) (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1))) -#define PAGE_DOWN(addr) ((addr)&(~((PAGE_SIZE)-1))) - -/* align addr on a size boundary - adjust address up/down if needed */ -#define _ALIGN_UP(addr, size) (((addr)+((size)-1))&(~((size)-1))) -#define _ALIGN_DOWN(addr, size) ((addr)&(~((size)-1))) - -/* align addr on a size boundary - adjust address up if needed */ -#define _ALIGN(addr, size) _ALIGN_UP(addr, size) - #define clear_page(pgaddr) memset((pgaddr), 0, PAGE_SIZE) #define copy_page(to, from) memcpy((to), (from), PAGE_SIZE) -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2 1/2] riscv: Cleanup unused functions 2021-05-30 4:53 ` [PATCH V2 1/2] riscv: " guoren @ 2021-06-09 0:18 ` Palmer Dabbelt 0 siblings, 0 replies; 6+ messages in thread From: Palmer Dabbelt @ 2021-06-09 0:18 UTC (permalink / raw) To: guoren Cc: guoren, Anup Patel, Arnd Bergmann, linux-riscv, linux-kernel, linux-arch, linux-sunxi, guoren On Sat, 29 May 2021 21:53:27 PDT (-0700), guoren@kernel.org wrote: > From: Guo Ren <guoren@linux.alibaba.com> > > These functions haven't been used, so just remove them. The patch > has been tested with riscv. > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > Reviewed-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Anup Patel <anup@brainfault.org> > Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com> > Acked-by: Palmer Dabbelt <palmerdabbelt@google.com> > --- > arch/riscv/include/asm/page.h | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/arch/riscv/include/asm/page.h b/arch/riscv/include/asm/page.h > index 6a7761c..a1b888f 100644 > --- a/arch/riscv/include/asm/page.h > +++ b/arch/riscv/include/asm/page.h > @@ -37,16 +37,6 @@ > > #ifndef __ASSEMBLY__ > > -#define PAGE_UP(addr) (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1))) > -#define PAGE_DOWN(addr) ((addr)&(~((PAGE_SIZE)-1))) > - > -/* align addr on a size boundary - adjust address up/down if needed */ > -#define _ALIGN_UP(addr, size) (((addr)+((size)-1))&(~((size)-1))) > -#define _ALIGN_DOWN(addr, size) ((addr)&(~((size)-1))) > - > -/* align addr on a size boundary - adjust address up if needed */ > -#define _ALIGN(addr, size) _ALIGN_UP(addr, size) > - > #define clear_page(pgaddr) memset((pgaddr), 0, PAGE_SIZE) > #define copy_page(to, from) memcpy((to), (from), PAGE_SIZE) Thanks, this is on for-next. I'm assuming you want the other one to go through the microblaze tree, and it looks like it's already been picked up. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2 2/2] microblaze: Cleanup unused functions 2021-05-30 4:53 [PATCH V2 0/2] arch: Cleanup unused functions guoren 2021-05-30 4:53 ` [PATCH V2 1/2] riscv: " guoren @ 2021-05-30 4:53 ` guoren 2021-05-31 12:24 ` Michal Simek 1 sibling, 1 reply; 6+ messages in thread From: guoren @ 2021-05-30 4:53 UTC (permalink / raw) To: guoren, anup.patel, palmerdabbelt, arnd Cc: linux-riscv, linux-kernel, linux-arch, linux-sunxi, Guo Ren, Michal Simek From: Guo Ren <guoren@linux.alibaba.com> These functions haven't been used, so just remove them. The patch just uses grep to verify. Signed-off-by: Guo Ren <guoren@linux.alibaba.com> Reviewed-by: Anup Patel <anup@brainfault.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Michal Simek <monstr@monstr.eu> --- arch/microblaze/include/asm/page.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/microblaze/include/asm/page.h b/arch/microblaze/include/asm/page.h index bf681f2..ce55097 100644 --- a/arch/microblaze/include/asm/page.h +++ b/arch/microblaze/include/asm/page.h @@ -35,9 +35,6 @@ #define ARCH_SLAB_MINALIGN L1_CACHE_BYTES -#define PAGE_UP(addr) (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1))) -#define PAGE_DOWN(addr) ((addr)&(~((PAGE_SIZE)-1))) - /* * PAGE_OFFSET -- the first address of the first page of memory. With MMU * it is set to the kernel start address (aligned on a page boundary). -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2 2/2] microblaze: Cleanup unused functions 2021-05-30 4:53 ` [PATCH V2 2/2] microblaze: " guoren @ 2021-05-31 12:24 ` Michal Simek 2021-05-31 12:32 ` Guo Ren 0 siblings, 1 reply; 6+ messages in thread From: Michal Simek @ 2021-05-31 12:24 UTC (permalink / raw) To: guoren, anup.patel, palmerdabbelt, arnd Cc: linux-riscv, linux-kernel, linux-arch, linux-sunxi, Guo Ren On 5/30/21 6:53 AM, guoren@kernel.org wrote: > From: Guo Ren <guoren@linux.alibaba.com> > > These functions haven't been used, so just remove them. The patch > just uses grep to verify. > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > Reviewed-by: Anup Patel <anup@brainfault.org> > Reviewed-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Michal Simek <monstr@monstr.eu> > --- > arch/microblaze/include/asm/page.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/microblaze/include/asm/page.h b/arch/microblaze/include/asm/page.h > index bf681f2..ce55097 100644 > --- a/arch/microblaze/include/asm/page.h > +++ b/arch/microblaze/include/asm/page.h > @@ -35,9 +35,6 @@ > > #define ARCH_SLAB_MINALIGN L1_CACHE_BYTES > > -#define PAGE_UP(addr) (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1))) > -#define PAGE_DOWN(addr) ((addr)&(~((PAGE_SIZE)-1))) > - > /* > * PAGE_OFFSET -- the first address of the first page of memory. With MMU > * it is set to the kernel start address (aligned on a page boundary). > Ah ok. you have sent v2. Will take this version instead of previous one. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2 2/2] microblaze: Cleanup unused functions 2021-05-31 12:24 ` Michal Simek @ 2021-05-31 12:32 ` Guo Ren 0 siblings, 0 replies; 6+ messages in thread From: Guo Ren @ 2021-05-31 12:32 UTC (permalink / raw) To: Michal Simek Cc: Anup Patel, Palmer Dabbelt, Arnd Bergmann, linux-riscv, Linux Kernel Mailing List, linux-arch, linux-sunxi, Guo Ren On Mon, May 31, 2021 at 8:25 PM Michal Simek <monstr@monstr.eu> wrote: > > > > On 5/30/21 6:53 AM, guoren@kernel.org wrote: > > From: Guo Ren <guoren@linux.alibaba.com> > > > > These functions haven't been used, so just remove them. The patch > > just uses grep to verify. > > > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > Reviewed-by: Anup Patel <anup@brainfault.org> > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com> > > Cc: Arnd Bergmann <arnd@arndb.de> > > Cc: Michal Simek <monstr@monstr.eu> > > --- > > arch/microblaze/include/asm/page.h | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/arch/microblaze/include/asm/page.h b/arch/microblaze/include/asm/page.h > > index bf681f2..ce55097 100644 > > --- a/arch/microblaze/include/asm/page.h > > +++ b/arch/microblaze/include/asm/page.h > > @@ -35,9 +35,6 @@ > > > > #define ARCH_SLAB_MINALIGN L1_CACHE_BYTES > > > > -#define PAGE_UP(addr) (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1))) > > -#define PAGE_DOWN(addr) ((addr)&(~((PAGE_SIZE)-1))) > > - > > /* > > * PAGE_OFFSET -- the first address of the first page of memory. With MMU > > * it is set to the kernel start address (aligned on a page boundary). > > > > Ah ok. you have sent v2. Will take this version instead of previous one. No need, they are the same, Thx. > > Thanks, > Michal > > -- > Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 > w: www.monstr.eu p: +42-0-721842854 > Maintainer of Linux kernel - Xilinx Microblaze > Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs > U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/ ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-09 0:18 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-05-30 4:53 [PATCH V2 0/2] arch: Cleanup unused functions guoren 2021-05-30 4:53 ` [PATCH V2 1/2] riscv: " guoren 2021-06-09 0:18 ` Palmer Dabbelt 2021-05-30 4:53 ` [PATCH V2 2/2] microblaze: " guoren 2021-05-31 12:24 ` Michal Simek 2021-05-31 12:32 ` Guo Ren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).