From: Roman Beranek <roman.beranek@prusa3d.cz>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lee Jones" <lee.jones@linaro.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@siol.net>
Cc: linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-sunxi@googlegroups.com,
Roman Beranek <roman.beranek@prusa3d.com>
Subject: [PATCH] pwm: sun4i: Round delay time up to a nearest jiffy
Date: Wed, 28 Apr 2021 02:19:46 +0200 [thread overview]
Message-ID: <20210428001946.1059426-1-roman.beranek@prusa3d.com> (raw)
More often than not, a PWM period may span nowhere near as far
as 1 jiffy, yet it still must be waited upon before the channel
is disabled.
Signed-off-by: Roman Beranek <roman.beranek@prusa3d.com>
---
drivers/pwm/pwm-sun4i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
index ce5c4fc8d..f4b991048 100644
--- a/drivers/pwm/pwm-sun4i.c
+++ b/drivers/pwm/pwm-sun4i.c
@@ -285,7 +285,7 @@ static int sun4i_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
val = (duty & PWM_DTY_MASK) | PWM_PRD(period);
sun4i_pwm_writel(sun4i_pwm, val, PWM_CH_PRD(pwm->hwpwm));
sun4i_pwm->next_period[pwm->hwpwm] = jiffies +
- nsecs_to_jiffies(cstate.period + 1000);
+ nsecs_to_jiffies(cstate.period) + 1;
if (state->polarity != PWM_POLARITY_NORMAL)
ctrl &= ~BIT_CH(PWM_ACT_STATE, pwm->hwpwm);
--
2.31.1
next reply other threads:[~2021-04-28 0:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 0:19 Roman Beranek [this message]
2021-04-28 6:13 ` [PATCH] pwm: sun4i: Round delay time up to a nearest jiffy Uwe Kleine-König
2021-04-28 12:14 ` Roman Beránek
2021-04-29 12:04 ` Uwe Kleine-König
2021-04-30 2:19 ` Roman Beránek
2021-04-30 6:41 ` Uwe Kleine-König
2021-04-30 7:17 ` Roman Beranek
2021-04-30 9:51 ` Uwe Kleine-König
2021-04-30 15:10 ` Roman Beranek
2021-04-30 16:18 ` [linux-sunxi] " dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428001946.1059426-1-roman.beranek@prusa3d.com \
--to=roman.beranek@prusa3d.cz \
--cc=jernej.skrabec@siol.net \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=roman.beranek@prusa3d.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).