archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] usb: musb-new: Extend and move Allwinner quirk into Kconfig
@ 2021-05-05 12:51 Andre Przywara
  0 siblings, 0 replies; only message in thread
From: Andre Przywara @ 2021-05-05 12:51 UTC (permalink / raw)
  To: Marek Vasut
  Cc: Jernej Skrabec, Samuel Holland, Jagan Teki, u-boot, linux-sunxi,

All newer Allwinner SoCs (since about 2013) miss the CONFIGDATA register
in their MUSB implementation, so they need a quirk to hardcode this.

Currently this quirk depends on listing the SoCs affected in musb_reg.h,
which means that this list needs to grow with every new chip.

Move the quirk feature into Kconfig, next to PIO_ONLY, and change the
default to y (for Allwinner builds), while listing the early
implementations as exceptions.

This fixes USB peripheral operation on some newer SoCs, which were not
explicitly listed before.

Tested on H6, H616, R40 (which were broken before), and also on the H5
and A20, for regressions.

Signed-off-by: Andre Przywara <>

a bit more elaborate than the first version, but hopefully cleaner and
more robust this time: we should never need to add anything to get new
SoCs covered.


Changelog v1 .. v2:
- Add Kconfig variable
- Switch to listing the exceptions instead of all affected SoCs

 drivers/usb/musb-new/Kconfig     | 10 ++++++++++
 drivers/usb/musb-new/musb_regs.h |  3 +--
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/musb-new/Kconfig b/drivers/usb/musb-new/Kconfig
index 6cf8a2b60b6..fd6f4109b0e 100644
--- a/drivers/usb/musb-new/Kconfig
+++ b/drivers/usb/musb-new/Kconfig
@@ -89,3 +89,13 @@ config USB_MUSB_PIO_ONLY
 	  All data is copied between memory and FIFO by the CPU.
 	  DMA controllers are ignored.
+	bool "Hardcode MUSB CONFIGDATA register"
+	depends on USB_MUSB_SUNXI
+	default n if MACH_SUN4I || MACH_SUN5I || MACH_SUN6I || MACH_SUN7I || MACH_SUN8I_A23
+	default y
+	help
+	  Newer Allwinner SoCs do not implement the MUSB_CONFIGDATA register,
+	  so it always reads 0. Select this option to override this and
+	  return a hardcoded value instead.
diff --git a/drivers/usb/musb-new/musb_regs.h b/drivers/usb/musb-new/musb_regs.h
index c4d7203b851..e9362f6def3 100644
--- a/drivers/usb/musb-new/musb_regs.h
+++ b/drivers/usb/musb-new/musb_regs.h
@@ -431,8 +431,7 @@ static inline u8 musb_read_ulpi_buscontrol(void __iomem *mbase)
 static inline u8 musb_read_configdata(void __iomem *mbase)
-#if defined CONFIG_MACH_SUN8I_A33 || defined CONFIG_MACH_SUN8I_A83T || \
-		defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I
 	/* <Sigh> allwinner saves a reg, and we need to hardcode this */
 	return 0xde;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-05-05 12:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-05 12:51 [PATCH v2] usb: musb-new: Extend and move Allwinner quirk into Kconfig Andre Przywara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).