From: Maxime Ripard <maxime@cerno.tech>
To: Samuel Holland <samuel@sholland.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Arnaud Ferraris <arnaud.ferraris@collabora.com>
Subject: Re: [PATCH v3 7/7] arm64: dts: allwinner: pinephone: Set audio card name
Date: Fri, 7 May 2021 10:09:42 +0200 [thread overview]
Message-ID: <20210507080942.lxysxdbrviv3ys7m@gilmour> (raw)
In-Reply-To: <20210430035859.3487-8-samuel@sholland.org>
[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]
Hi,
On Thu, Apr 29, 2021 at 10:58:59PM -0500, Samuel Holland wrote:
> From: Arnaud Ferraris <arnaud.ferraris@collabora.com>
>
> Add the "PinePhone" name to the sound card: this will make
> upstreaming an ALSA UCM config easier as we can use a unique name.
>
> It also avoids an issue where the default card name is truncated.
>
> Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
> [Samuel: Split out change, updated commit message]
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> index 51cbfdc12936..02712f85f6bd 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> @@ -433,6 +433,7 @@ ®_rtc_ldo {
>
> &sound {
> status = "okay";
> + simple-audio-card,name = "PinePhone";
> simple-audio-card,aux-devs = <&codec_analog>, <&speaker_amp>;
> simple-audio-card,widgets = "Microphone", "Headset Microphone",
> "Microphone", "Internal Microphone",
Isn't that reported to the userspace? I'm not sure we can just change it
without breaking it.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-05-07 8:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 3:58 [PATCH v3 0/7] PinePhone BT audio bringup Samuel Holland
2021-04-30 3:58 ` [PATCH v3 1/7] ASoC: dt-bindings: sun8i-codec: Increase #sound-dai-cells Samuel Holland
2021-04-30 21:46 ` Rob Herring
2021-04-30 3:58 ` [PATCH v3 2/7] ARM: dts: sun8i-a33: Allow using multiple codec DAIs Samuel Holland
2021-04-30 3:58 ` [PATCH v3 3/7] arm64: dts: allwinner: a64: " Samuel Holland
2021-04-30 3:58 ` [PATCH v3 4/7] arm64: dts: allwinner: a64: Add pinmux nodes for AIF2/AIF3 Samuel Holland
2021-04-30 3:58 ` [PATCH v3 5/7] arm64: dts: allwinner: a64: Allow multiple DAI links Samuel Holland
2021-04-30 3:58 ` [PATCH v3 6/7] arm64: dts: allwinner: pinephone: Add support for Bluetooth audio Samuel Holland
2021-04-30 3:58 ` [PATCH v3 7/7] arm64: dts: allwinner: pinephone: Set audio card name Samuel Holland
2021-05-07 8:09 ` Maxime Ripard [this message]
2021-05-10 1:54 ` Samuel Holland
2021-05-24 12:08 ` Maxime Ripard
2021-05-07 8:09 ` [PATCH v3 0/7] PinePhone BT audio bringup Maxime Ripard
2021-05-11 8:26 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507080942.lxysxdbrviv3ys7m@gilmour \
--to=maxime@cerno.tech \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.ferraris@collabora.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).