linux-sunxi.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: sun8i: v3s: enable emac for zero Dock
@ 2021-05-22 20:50 Andreas Rehn
  2021-05-22 21:36 ` Andre Przywara
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Andreas Rehn @ 2021-05-22 20:50 UTC (permalink / raw)
  To: mripard, wens, jernej.skrabec; +Cc: linux-sunxi, linux-kernel, Andreas Rehn

dwmac-sun8i supports v3s and
Licheepi-zero Dock provides an ethernet port

Signed-off-by: Andreas Rehn <rehn.andreas86@gmail.com>
---
 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
index db5cd0b8574b..2d78b7a52fd3 100644
--- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
+++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
@@ -94,3 +94,8 @@ button-800 {
 		voltage = <800000>;
 	};
 };
+
+&emac {
+	allwinner,leds-active-low;
+	status = "okay";
+};
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: sun8i: v3s: enable emac for zero Dock
  2021-05-22 20:50 [PATCH] ARM: dts: sun8i: v3s: enable emac for zero Dock Andreas Rehn
@ 2021-05-22 21:36 ` Andre Przywara
  2021-05-22 22:23 ` [PATCH v2] " Andreas Rehn
  2021-05-25 17:31 ` [PATCH v3] " Andreas Rehn
  2 siblings, 0 replies; 7+ messages in thread
From: Andre Przywara @ 2021-05-22 21:36 UTC (permalink / raw)
  To: Andreas Rehn, Icenowy Zheng
  Cc: mripard, wens, jernej.skrabec, linux-sunxi, linux-kernel,
	Linux ARM Mailing List

On Sat, 22 May 2021 22:50:39 +0200
Andreas Rehn <rehn.andreas86@gmail.com> wrote:

> dwmac-sun8i supports v3s and
> Licheepi-zero Dock provides an ethernet port

As the other boards do it, and since we only take .dts files unchanged
into U-Boot: please add the alias here as well.

Icenowy, can you confirm that this works?

Cheers,
Andre

> 
> Signed-off-by: Andreas Rehn <rehn.andreas86@gmail.com>
> ---
>  arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> index db5cd0b8574b..2d78b7a52fd3 100644
> --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> @@ -94,3 +94,8 @@ button-800 {
>  		voltage = <800000>;
>  	};
>  };
> +
> +&emac {
> +	allwinner,leds-active-low;
> +	status = "okay";
> +};


^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH v2] ARM: dts: sun8i: v3s: enable emac for zero Dock
  2021-05-22 20:50 [PATCH] ARM: dts: sun8i: v3s: enable emac for zero Dock Andreas Rehn
  2021-05-22 21:36 ` Andre Przywara
@ 2021-05-22 22:23 ` Andreas Rehn
  2021-05-25  8:06   ` Maxime Ripard
  2021-05-25 17:31 ` [PATCH v3] " Andreas Rehn
  2 siblings, 1 reply; 7+ messages in thread
From: Andreas Rehn @ 2021-05-22 22:23 UTC (permalink / raw)
  To: mripard, wens, jernej.skrabec; +Cc: linux-sunxi, linux-kernel, Andreas Rehn

dwmac-sun8i supports v3s and
Licheepi-zero Dock provides an ethernet port

Signed-off-by: Andreas Rehn <rehn.andreas86@gmail.com>
---
Changes in v2:
	- add ethernet0 alias.

 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
index db5cd0b8574b..4d564028f286 100644
--- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
+++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
@@ -49,6 +49,10 @@ / {
 	compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero",
 		     "allwinner,sun8i-v3s";
 
+	aliases {
+		ethernet0 = &emac;
+	};
+
 	leds {
 		/* The LEDs use PG0~2 pins, which conflict with MMC1 */
 		status = "disabled";
@@ -94,3 +98,8 @@ button-800 {
 		voltage = <800000>;
 	};
 };
+
+&emac {
+	allwinner,leds-active-low;
+	status = "okay";
+};
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] ARM: dts: sun8i: v3s: enable emac for zero Dock
  2021-05-22 22:23 ` [PATCH v2] " Andreas Rehn
@ 2021-05-25  8:06   ` Maxime Ripard
  0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2021-05-25  8:06 UTC (permalink / raw)
  To: Andreas Rehn; +Cc: wens, jernej.skrabec, linux-sunxi, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]

Hi Andreas,

On Sun, May 23, 2021 at 12:23:29AM +0200, Andreas Rehn wrote:
> dwmac-sun8i supports v3s and
> Licheepi-zero Dock provides an ethernet port
> 
> Signed-off-by: Andreas Rehn <rehn.andreas86@gmail.com>
> ---
> Changes in v2:
> 	- add ethernet0 alias.
> 
>  arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> index db5cd0b8574b..4d564028f286 100644
> --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> @@ -49,6 +49,10 @@ / {
>  	compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero",
>  		     "allwinner,sun8i-v3s";
>  
> +	aliases {
> +		ethernet0 = &emac;
> +	};
> +
>  	leds {
>  		/* The LEDs use PG0~2 pins, which conflict with MMC1 */
>  		status = "disabled";
> @@ -94,3 +98,8 @@ button-800 {
>  		voltage = <800000>;
>  	};
>  };
> +
> +&emac {
> +	allwinner,leds-active-low;
> +	status = "okay";
> +};

We use alphabetical order for phandle derefences

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH v3] ARM: dts: sun8i: v3s: enable emac for zero Dock
  2021-05-22 20:50 [PATCH] ARM: dts: sun8i: v3s: enable emac for zero Dock Andreas Rehn
  2021-05-22 21:36 ` Andre Przywara
  2021-05-22 22:23 ` [PATCH v2] " Andreas Rehn
@ 2021-05-25 17:31 ` Andreas Rehn
  2021-05-26 23:16   ` Andre Przywara
  2 siblings, 1 reply; 7+ messages in thread
From: Andreas Rehn @ 2021-05-25 17:31 UTC (permalink / raw)
  To: mripard, wens, jernej.skrabec
  Cc: rfried.dev, linux-sunxi, linux-kernel, Andreas Rehn

dwmac-sun8i supports v3s and
Licheepi-zero Dock provides an ethernet port
furthermore, align nodes in alphabetical order

Signed-off-by: Andreas Rehn <rehn.andreas86@gmail.com>
---
Changes in v3:
	- align nodes in alphabetical order
Changes in v2:
	- add ethernet0 alias.
 .../boot/dts/sun8i-v3s-licheepi-zero-dock.dts   | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
index db5cd0b8574b..752ad05c8f83 100644
--- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
+++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
@@ -49,16 +49,18 @@ / {
 	compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero",
 		     "allwinner,sun8i-v3s";
 
+	aliases {
+		ethernet0 = &emac;
+	};
+
 	leds {
 		/* The LEDs use PG0~2 pins, which conflict with MMC1 */
 		status = "disabled";
 	};
 };
 
-&mmc1 {
-	broken-cd;
-	bus-width = <4>;
-	vmmc-supply = <&reg_vcc3v3>;
+&emac {
+	allwinner,leds-active-low;
 	status = "okay";
 };
 
@@ -94,3 +96,10 @@ button-800 {
 		voltage = <800000>;
 	};
 };
+
+&mmc1 {
+	broken-cd;
+	bus-width = <4>;
+	vmmc-supply = <&reg_vcc3v3>;
+	status = "okay";
+};
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH v3] ARM: dts: sun8i: v3s: enable emac for zero Dock
  2021-05-25 17:31 ` [PATCH v3] " Andreas Rehn
@ 2021-05-26 23:16   ` Andre Przywara
  2021-05-31  9:45     ` Maxime Ripard
  0 siblings, 1 reply; 7+ messages in thread
From: Andre Przywara @ 2021-05-26 23:16 UTC (permalink / raw)
  To: Andreas Rehn
  Cc: mripard, wens, jernej.skrabec, rfried.dev, linux-sunxi, linux-kernel

On Tue, 25 May 2021 19:31:59 +0200
Andreas Rehn <rehn.andreas86@gmail.com> wrote:

> dwmac-sun8i supports v3s and
> Licheepi-zero Dock provides an ethernet port
> furthermore, align nodes in alphabetical order
> 
> Signed-off-by: Andreas Rehn <rehn.andreas86@gmail.com>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
> Changes in v3:
> 	- align nodes in alphabetical order
> Changes in v2:
> 	- add ethernet0 alias.
>  .../boot/dts/sun8i-v3s-licheepi-zero-dock.dts   | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> index db5cd0b8574b..752ad05c8f83 100644
> --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> @@ -49,16 +49,18 @@ / {
>  	compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero",
>  		     "allwinner,sun8i-v3s";
>  
> +	aliases {
> +		ethernet0 = &emac;
> +	};
> +
>  	leds {
>  		/* The LEDs use PG0~2 pins, which conflict with MMC1 */
>  		status = "disabled";
>  	};
>  };
>  
> -&mmc1 {
> -	broken-cd;
> -	bus-width = <4>;
> -	vmmc-supply = <&reg_vcc3v3>;
> +&emac {
> +	allwinner,leds-active-low;
>  	status = "okay";
>  };
>  
> @@ -94,3 +96,10 @@ button-800 {
>  		voltage = <800000>;
>  	};
>  };
> +
> +&mmc1 {
> +	broken-cd;
> +	bus-width = <4>;
> +	vmmc-supply = <&reg_vcc3v3>;
> +	status = "okay";
> +};


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v3] ARM: dts: sun8i: v3s: enable emac for zero Dock
  2021-05-26 23:16   ` Andre Przywara
@ 2021-05-31  9:45     ` Maxime Ripard
  0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2021-05-31  9:45 UTC (permalink / raw)
  To: Andre Przywara
  Cc: Andreas Rehn, wens, jernej.skrabec, rfried.dev, linux-sunxi,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

On Thu, May 27, 2021 at 12:16:14AM +0100, Andre Przywara wrote:
> On Tue, 25 May 2021 19:31:59 +0200
> Andreas Rehn <rehn.andreas86@gmail.com> wrote:
> 
> > dwmac-sun8i supports v3s and
> > Licheepi-zero Dock provides an ethernet port
> > furthermore, align nodes in alphabetical order
> > 
> > Signed-off-by: Andreas Rehn <rehn.andreas86@gmail.com>
> 
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Applied, thanks
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-05-31  9:45 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-22 20:50 [PATCH] ARM: dts: sun8i: v3s: enable emac for zero Dock Andreas Rehn
2021-05-22 21:36 ` Andre Przywara
2021-05-22 22:23 ` [PATCH v2] " Andreas Rehn
2021-05-25  8:06   ` Maxime Ripard
2021-05-25 17:31 ` [PATCH v3] " Andreas Rehn
2021-05-26 23:16   ` Andre Przywara
2021-05-31  9:45     ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).