From: Andre Przywara <andre.przywara@arm.com>
To: Andreas Rehn <rehn.andreas86@gmail.com>
Cc: mripard@kernel.org, wens@csie.org, jernej.skrabec@gmail.com,
rfried.dev@gmail.com, linux-sunxi@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ARM: dts: sun8i: v3s: enable emac for zero Dock
Date: Thu, 27 May 2021 00:16:14 +0100 [thread overview]
Message-ID: <20210527001614.2edfc630@slackpad.fritz.box> (raw)
In-Reply-To: <20210525173159.183415-1-rehn.andreas86@gmail.com>
On Tue, 25 May 2021 19:31:59 +0200
Andreas Rehn <rehn.andreas86@gmail.com> wrote:
> dwmac-sun8i supports v3s and
> Licheepi-zero Dock provides an ethernet port
> furthermore, align nodes in alphabetical order
>
> Signed-off-by: Andreas Rehn <rehn.andreas86@gmail.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
> Changes in v3:
> - align nodes in alphabetical order
> Changes in v2:
> - add ethernet0 alias.
> .../boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> index db5cd0b8574b..752ad05c8f83 100644
> --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> @@ -49,16 +49,18 @@ / {
> compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero",
> "allwinner,sun8i-v3s";
>
> + aliases {
> + ethernet0 = &emac;
> + };
> +
> leds {
> /* The LEDs use PG0~2 pins, which conflict with MMC1 */
> status = "disabled";
> };
> };
>
> -&mmc1 {
> - broken-cd;
> - bus-width = <4>;
> - vmmc-supply = <®_vcc3v3>;
> +&emac {
> + allwinner,leds-active-low;
> status = "okay";
> };
>
> @@ -94,3 +96,10 @@ button-800 {
> voltage = <800000>;
> };
> };
> +
> +&mmc1 {
> + broken-cd;
> + bus-width = <4>;
> + vmmc-supply = <®_vcc3v3>;
> + status = "okay";
> +};
next prev parent reply other threads:[~2021-05-26 23:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 20:50 [PATCH] ARM: dts: sun8i: v3s: enable emac for zero Dock Andreas Rehn
2021-05-22 21:36 ` Andre Przywara
2021-05-22 22:23 ` [PATCH v2] " Andreas Rehn
2021-05-25 8:06 ` Maxime Ripard
2021-05-25 17:31 ` [PATCH v3] " Andreas Rehn
2021-05-26 23:16 ` Andre Przywara [this message]
2021-05-31 9:45 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527001614.2edfc630@slackpad.fritz.box \
--to=andre.przywara@arm.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=rehn.andreas86@gmail.com \
--cc=rfried.dev@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).