From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01A8770 for ; Fri, 4 Jun 2021 05:03:21 +0000 (UTC) Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 722CC240029 for ; Fri, 4 Jun 2021 06:55:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1622782547; bh=TTyTROyQXjsSXo74wJBHn6lqKWQ3+EbGHja6XTO7Rds=; h=Date:From:To:Cc:Subject:From; b=b4kfkQdftGPZQAMXH5LvwkFcZ3zhObfnY0zCw1HWa3vz1OjKz0xIDlQZfAUqaYm8n LEzDIeuIPtgW+cna1vw2q7i1wnM3oFCyxkSEA+W10Mt7I3CRYrP+A9ukIObzFVybPW pMClWvFX+BOQV2lPrTodITHK5rXrTxjmGbUTwKcFW1rUQUb1/w0DWPByV2HRJQMX/A 2icvC+zVgqIzhPQSq2W2c6YEOu0PV+VnOzM+DGMS+tgOEnXNRHlASnZ7hzPZRlQDME 9LASZa1tebUvbv6Ie5EVrYQPsgmQlntWn/Ef8HlLZU61ngXarVx6ERq9Tfp56/pUbZ gKf2dD0fGmqfg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Fx9Sc48Wdz6tm9; Fri, 4 Jun 2021 06:55:44 +0200 (CEST) Date: Fri, 4 Jun 2021 04:55:43 +0000 From: Wilken Gottwalt To: Suman Anna Cc: Bjorn Andersson , Rob Herring , Mathieu Poirier , Maxime Ripard , Chen-Yu Tsai , , , , , Subject: Re: [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding Message-ID: <20210604065543.3d71ca53@monster.powergraphx.local> In-Reply-To: <20210603144216.10327-1-s-anna@ti.com> References: <20210603144216.10327-1-s-anna@ti.com> X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 3 Jun 2021 09:42:16 -0500 Suman Anna wrote: > The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched > $id and fails to compile the example due to undefined args specifier > values for clocks and resets. Fix both of these issues. > > Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock") > Signed-off-by: Suman Anna > --- > Hi Wilken, > > This fixes the warnings for now on linux-next, but I think the example > should be including sun6i-a31-ccu.h files instead to be accurate, and > those files are missing the definitions for CLK_BUS_SPINLOCK and > RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental > patch on top. > > regards > Suman Hi Suman, thank you for fixing this. I would have fix it the same way for now, so it is fine for me. But I will keep an eye on it. greetings, Will > .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml > b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml index > 733c3d01e56c..10e5a53e447b 100644 --- > a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml +++ > b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > %YAML 1.2 > --- > -$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml# > +$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-a31-hwspinlock.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs > @@ -36,6 +36,9 @@ additionalProperties: false > > examples: > - | > + #include > + #include > + > hwlock@1c18000 { > compatible = "allwinner,sun6i-a31-hwspinlock"; > reg = <0x01c18000 0x1000>;