linux-sunxi.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch, airlied@linux.ie, alexander.deucher@amd.com,
	christian.koenig@amd.com, Xinhui.Pan@amd.com,
	james.qian.wang@arm.com, liviu.dudau@arm.com,
	mihail.atanassov@arm.com, brian.starkey@arm.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	inki.dae@samsung.com, jy0922.shim@samsung.com,
	sw0312.kim@samsung.com, kyungmin.park@samsung.com,
	krzysztof.kozlowski@canonical.com, xinliang.liu@linaro.org,
	tiantao6@hisilicon.com, john.stultz@linaro.org,
	kong.kongxinwei@hisilicon.com, puck.chen@hisilicon.com,
	laurentiu.palcu@oss.nxp.com, l.stach@pengutronix.de,
	p.zabel@pengutronix.de, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com, chunkuang.hu@kernel.org,
	matthias.bgg@gmail.com, bskeggs@redhat.com, tomba@kernel.org,
	hjc@rock-chips.com, heiko@sntech.de, yannick.fertre@foss.st.com,
	philippe.cornu@foss.st.com, mcoquelin.stm32@gmail.com,
	alexandre.torgue@foss.st.com, wens@csie.org,
	jernej.skrabec@gmail.com, thierry.reding@gmail.com,
	jonathanh@nvidia.com, jyri.sarha@iki.fi, emma@anholt.net,
	linux-graphics-maintainer@vmware.com, zackr@vmware.com,
	hyun.kwon@xilinx.com, laurent.pinchart@ideasonboard.com,
	michal.simek@xilinx.com, jani.nikula@linux.intel.com,
	rodrigo.vivi@intel.com, linux@armlinux.org.uk,
	kieran.bingham+renesas@ideasonboard.com,
	rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com,
	hamohammed.sa@gmail.com
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	nouveau@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH v4 02/27] drm/hibmc: Call drm_irq_uninstall() unconditionally
Date: Fri, 25 Jun 2021 10:21:57 +0200	[thread overview]
Message-ID: <20210625082222.3845-3-tzimmermann@suse.de> (raw)
In-Reply-To: <20210625082222.3845-1-tzimmermann@suse.de>

Remove the check around drm_irq_uninstall(). The same test is
done by the function internally. The tested state in irq_enabled
is considered obsolete and should not be used by KMS drivers.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Tian Tao <tiantao6@hisilicon.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index f4bc5386574a..f8ef711bbe5d 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -253,8 +253,7 @@ static int hibmc_unload(struct drm_device *dev)
 {
 	drm_atomic_helper_shutdown(dev);
 
-	if (dev->irq_enabled)
-		drm_irq_uninstall(dev);
+	drm_irq_uninstall(dev);
 
 	pci_disable_msi(to_pci_dev(dev->dev));
 
-- 
2.32.0


  parent reply	other threads:[~2021-06-25  8:22 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25  8:21 [PATCH v4 00/27] Deprecate struct drm_device.irq_enabled Thomas Zimmermann
2021-06-25  8:21 ` [PATCH v4 01/27] drm/amdgpu: Track IRQ state in local device state Thomas Zimmermann
2021-06-25  8:21 ` Thomas Zimmermann [this message]
2021-06-25  8:21 ` [PATCH v4 03/27] drm/radeon: " Thomas Zimmermann
2021-06-25  8:21 ` [PATCH v4 04/27] drm: Don't test for IRQ support in VBLANK ioctls Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 05/27] drm/armada: Don't set struct drm_device.irq_enabled Thomas Zimmermann
2021-06-28  6:23   ` Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 06/27] drm/i915: Track IRQ state in local device state Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 07/27] drm/komeda: Don't set struct drm_device.irq_enabled Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 08/27] drm/malidp: " Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 09/27] drm/exynos: " Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 10/27] drm/kirin: " Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 11/27] drm/imx: " Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 12/27] drm/imx/dcss: " Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 13/27] drm/mediatek: " Thomas Zimmermann
2021-08-09 13:08   ` Chun-Kuang Hu
2021-06-25  8:22 ` [PATCH v4 14/27] drm/nouveau: " Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 15/27] drm/omapdrm: Track IRQ state in local device state Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 16/27] drm/rcar-du: Don't set struct drm_device.irq_enabled Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 17/27] drm/rockchip: " Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 18/27] drm/sti: " Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 19/27] drm/stm: " Thomas Zimmermann
2021-06-29  9:18   ` yannick Fertre
2021-06-25  8:22 ` [PATCH v4 20/27] drm/sun4i: " Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 21/27] drm/tegra: " Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 22/27] drm/tidss: Don't use " Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 23/27] drm/vc4: Don't set " Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 24/27] drm/vkms: " Thomas Zimmermann
2021-06-26  8:55   ` Melissa Wen
2021-06-25  8:22 ` [PATCH v4 25/27] drm/vmwgfx: " Thomas Zimmermann
2021-06-26  2:41   ` Zack Rusin
2021-06-25  8:22 ` [PATCH v4 26/27] drm/xlnx: " Thomas Zimmermann
2021-06-25  8:22 ` [PATCH v4 27/27] drm/zte: " Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210625082222.3845-3-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=brian.starkey@arm.com \
    --cc=bskeggs@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emma@anholt.net \
    --cc=festevam@gmail.com \
    --cc=hamohammed.sa@gmail.com \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=hyun.kwon@xilinx.com \
    --cc=inki.dae@samsung.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=james.qian.wang@arm.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=jonathanh@nvidia.com \
    --cc=jy0922.shim@samsung.com \
    --cc=jyri.sarha@iki.fi \
    --cc=kernel@pengutronix.de \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=kong.kongxinwei@hisilicon.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=kyungmin.park@samsung.com \
    --cc=l.stach@pengutronix.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=laurentiu.palcu@oss.nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-graphics-maintainer@vmware.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=liviu.dudau@arm.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=melissa.srw@gmail.com \
    --cc=michal.simek@xilinx.com \
    --cc=mihail.atanassov@arm.com \
    --cc=mripard@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=p.zabel@pengutronix.de \
    --cc=philippe.cornu@foss.st.com \
    --cc=puck.chen@hisilicon.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=rodrigosiqueiramelo@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=sw0312.kim@samsung.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiantao6@hisilicon.com \
    --cc=tomba@kernel.org \
    --cc=wens@csie.org \
    --cc=xinliang.liu@linaro.org \
    --cc=yannick.fertre@foss.st.com \
    --cc=zackr@vmware.com \
    --subject='Re: [PATCH v4 02/27] drm/hibmc: Call drm_irq_uninstall() unconditionally' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox