From: Maxime Ripard <maxime@cerno.tech>
To: fengzheng923@gmail.com
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
wens@csie.org, jernej.skrabec@gmail.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller
Date: Mon, 28 Jun 2021 14:46:34 +0200 [thread overview]
Message-ID: <20210628124634.radw3ywstfdl2fqw@gilmour> (raw)
In-Reply-To: <20210625090721.6183-1-fengzheng923@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2749 bytes --]
On Fri, Jun 25, 2021 at 05:07:21AM -0400, fengzheng923@gmail.com wrote:
> From: Ban Tao <fengzheng923@gmail.com>
>
> DT binding documentation for this new ASoC driver.
>
> Signed-off-by: Ban Tao <fengzheng923@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> ---
> v1->v2:
> 1.Fix some build errors.
> ---
> v2->v3:
> 1.Fix some build errors.
> ---
> v3->v4:
> 1.None.
> ---
> .../sound/allwinner,sun50i-h6-dmic.yaml | 68 +++++++++++++++++++
> 1 file changed, 68 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml
> new file mode 100644
> index 000000000000..d9107685b78d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/allwinner,sun50i-h6-dmic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Allwinner H6 DMIC Device Tree Bindings
> +
> +maintainers:
> + - Ban Tao <fengzheng923@gmail.com>
> +
> +properties:
> + "#sound-dai-cells":
> + const: 0
> +
> + compatible:
> + const: allwinner,sun50i-h6-dmic
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: Bus Clock
> + - description: Module Clock
> +
> + clock-names:
> + items:
> + - const: bus
> + - const: mod
> +
> + dmas:
> + items:
> + - description: RX DMA Channel
> +
> + dma-names:
> + items:
> + - const: rx
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - "#sound-dai-cells"
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - dmas
> + - dma-names
> + - resets
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + dmic: dmic@5095000 {
> + #sound-dai-cells = <0>;
> + compatible = "allwinner,sun50i-h6-dmic";
> + reg = <0x05095000 0x400>;
> + clocks = <&ccu 101>, <&ccu 100>;
> + clock-names = "bus", "mod";
> + dmas = <&dma 7>;
> + dma-names = "rx";
> + resets = <&ccu 42>;
> + };
You can keep the clock and reset indices, it's more readable that way,
you just have to add the headers dt-bindings/clock/sun50i-h6-ccu.h and
dt-bindings/reset/sun50i-h6-ccu.h like what
Documentation/devicetree/bindings/iommu/allwinner,sun50i-h6-iommu.yaml
is doing.
Also, this controller has an interrupt. Even if the driver doesn't use
it it should be in the binding.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2021-06-28 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 9:07 [PATCH v4 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller fengzheng923
2021-06-28 12:46 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628124634.radw3ywstfdl2fqw@gilmour \
--to=maxime@cerno.tech \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fengzheng923@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).